https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Something in master has broken "Search to hold" - getting this error message when trying to add a hold (just the start of the error message):

Template process failed: undef error - Not an ARRAY reference at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 95. at /kohadevbox/koha/C4/Templates.pm line 122

in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 122

119: 120: my $data; 121: binmode( STDOUT, ":utf8" ); 122: $template->process( $self->filename, $vars, \$data ) 123: || die "Template process failed: ", $template->error(); 124: return $data; 125: }

Show function arguments

Placing a hold works fine on 19.11.x. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393 --- Comment #4 from David Nind <david@davidnind.com> --- Thanks Katrin! Will keep an eye out and retest once it's resolved... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97139|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 97514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97514&action=edit Bug 24393: Remove event attributes from patron clubs list template This patch removes some instances of the "onclick" attributes from the template that lists patron clubs and templates. To test, apply the patch and go to Tools -> Patron clubs. - Test the process of deleting a club template. Clicking the "Delete" button should trigger a confirmation. Confirming should delete the template. - Test the process of deleting a club. In the "Clubs" section of the page, click the "Actions" menu next to any club. Clicking the "Delete" link should trigger a confirmation. Confirming should delete the club. - Also in the "Clubs" section of the page, find a club which has enrollments. Select "Search to hold" from the "Actions" menu. It should take you to the advanced search. On the search results page you should have the option to place a hold for the club you selected. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97514|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97599&action=edit Bug 24393: Remove event attributes from patron clubs list template This patch removes some instances of the "onclick" attributes from the template that lists patron clubs and templates. To test, apply the patch and go to Tools -> Patron clubs. - Test the process of deleting a club template. Clicking the "Delete" button should trigger a confirmation. Confirming should delete the template. - Test the process of deleting a club. In the "Clubs" section of the page, click the "Actions" menu next to any club. Clicking the "Delete" link should trigger a confirmation. Confirming should delete the club. - Also in the "Clubs" section of the page, find a club which has enrollments. Select "Search to hold" from the "Actions" menu. It should take you to the advanced search. On the search results page you should have the option to place a hold for the club you selected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.