[Bug 29456] New: Notice overview on Patron Category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Bug ID: 29456 Summary: Notice overview on Patron Category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 127518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127518&action=edit visual When looking at the Patron Category overview, a library gets a glimpse at all the pieces of that patron category. One of the pieces is the summary of notices, currently, the last notice that is listed is called "unknown'- which should be named "auto-renew- see screenshot. This should have the correct text instead of unknown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |rel_21_05_candidate, | |rel_21_11_candidate Depends on| |18532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 [Bug 18532] Messaging preferences for auto renewals -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127692&action=edit Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category The new message appears in the list on the edit view, but the list view is showing "unknown" Test plan: Set AutoRenewalNotices to "according to patron messaging prefs" Edit a patron category Tick all the checkboxes On the category list view you should see a correct display in the "Messaging" column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Notice overview on Patron |"Auto renewal" notice shown |Category |as "unknown" on the patron | |category list view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127692|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 127693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127693&action=edit Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category The new message appears in the list on the edit view, but the list view is showing "unknown" Test plan: Set AutoRenewalNotices to "according to patron messaging prefs" Edit a patron category Tick all the checkboxes On the category list view you should see a correct display in the "Messaging" column Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Kelly McElligott <kelly@bywatersolutions.com> --- Works great! Signing off through sandboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Auto renewal" notice shown |"Auto renewal" and "Hold |as "unknown" on the patron |reminder" notice shown as |category list view |"unknown" on the patron | |category list view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127693|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127783&action=edit Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category The new message appears in the list on the edit view, but the list view is showing "unknown" Test plan: Set AutoRenewalNotices to "according to patron messaging prefs" Edit a patron category Tick all the checkboxes On the category list view you should see a correct display in the "Messaging" column Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127784&action=edit Bug 29456: Add Hold_Reminder description to patron categories overview page This was missed when initially adding the notice. To test: - Go to Administraiton > patron categories - Edit a patron category and check "Hold reminder" in messaging preferences, save. - Go to the overview page and verify it shows as 'Unknown'. - Apply patch. - Descrpition should now display. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Strictly speaking this is a string patch, but as the string already exists in other spots, I believe we could be lucky here. And an English string showing would also be better than "Unknown". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 18532 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate, | |rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Bug 29456 depends on bug 18532, which changed state. Bug 18532 Summary: Messaging preferences for auto renewals https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org