[Bug 19489] New: Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab /Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Bug ID: 19489 Summary: Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jesse@bywatersolutions.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some libraries would like to see the item barcode, due date, and return date ( if any ) for fines in the accounts tables related to fines ( pay.pl and boraccount.pl ). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@l2c2.co.in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6508 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #1 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 81956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81956&action=edit Bug 19489 - Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kohadevinim@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Comment on attachment 81956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81956 Bug 19489 - Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Review of attachment 81956: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19489&attachment=81956) ----------------------------------------------------------------- Everything works nicely in testing, the columns appear as expected. The method for checkouts itself should be an object method for Koha::Account::Line It would be nice too if there were some refactoring to simply pass the Line objects and use the fields/method on the the template rather than formatting in a hash in the scripts ::: members/accountline-details.pl @@ +24,5 @@
use C4::Output; use C4::Context; use Koha::Patrons; +use Koha::Checkouts; +use Koha::Old::Checkouts;
Rather than importing these here we should implement 'checkout' as an object method for the Koha::Account::Line @@ +67,5 @@
my $patron = Koha::Patrons->find( $accountline->borrowernumber ); + my $issues; + if ( $accountline->issue_id ) { + $issues = Koha::Checkouts->find($accountline->issue_id ); + $issues = Koha::Old::Checkouts->find($accountline->issue_id ) unless $issues;
As mentioned above - this should use an object method from Koha::Account::Line The plural is also confusing as there should on ly ever be one $accountline->checkout; ::: members/boraccount.pl @@ +112,5 @@
+ + if ( $accountline->{issue_id} ) { + my $issues = Koha::Checkouts->find($accountline->{issue_id} ); + $issues = Koha::Old::Checkouts->find($accountline->{issue_id} ) unless $issues; + $accountline->{issue} = $issues;
As before, this should use an object method ::: members/pay.pl @@ +152,5 @@
} + if ( $account_line->{issue_id} ) { + my $issues = Koha::Checkouts->find($account_line->{issue_id} ); + $issues = Koha::Old::Checkouts->find($account_line->{issue_id} ) unless $issues; + $account_line->{issue} = $issues;
Use object method ::: members/printinvoice.pl @@ +64,5 @@
+ +if ( $accountline->{issue_id} ) { + my $issues = Koha::Checkouts->find($accountline->{issue_id} ); + $issues = Koha::Old::Checkouts->find($accountline->{issue_id} ) unless $issues; + $accountline->{issue} = $issues;
Use object method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #3 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 81989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81989&action=edit (Object method) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81956|0 |1 is obsolete| | Attachment #81989|0 |1 is obsolete| | --- Comment #4 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 81991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81991&action=edit Bug 19489 - (Object Method) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81991|0 |1 is obsolete| | --- Comment #5 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 82519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82519&action=edit Bug 19489 - (Object Method) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning Unit test added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82519|0 |1 is obsolete| | --- Comment #6 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 82520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82520&action=edit Bug 19489 - (Object Method) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning Unit test added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82520|0 |1 is obsolete| | --- Comment #7 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 82614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82614&action=edit Bug 19489: Improvements in Unit test and Koha::Account::Line->issue method Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Lines.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #8 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 82615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82615&action=edit Bug 19489: Development for fines and Fees Module Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21879 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21879 [Bug 21879] Code cleaning in printinvoice.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- This seems to be working, but the test doesn't pass: t/db_dependent/Koha/Account/Lines.t .. 1/5 # Failed test 'No tests run for subtest "item() tests"' # at t/db_dependent/Koha/Account/Lines.t line 67. DBIx::Class::Storage::DBI::_dbh_execute(): Field 'account_balance' doesn't have a default value at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 288 # Looks like your test exited with 255 just after 1. t/db_dependent/Koha/Account/Lines.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 5/5 subtests Test Summary Report ------------------- t/db_dependent/Koha/Account/Lines.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 5 tests but ran 1. Files=1, Tests=1, 3 wallclock secs ( 0.01 usr 0.01 sys + 1.21 cusr 0.52 csys = 1.75 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #10 from Devinim <kohadevinim@devinim.com.tr> --- Hi Owen, It is most probably another patch made it this since we've tested before sending patches and unit tests. Our developers is looking once again, will change it soon. Thanks a lot. Devinim Koha Team -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #11 from Devinim <kohadevinim@devinim.com.tr> --- (In reply to Owen Leonard from comment #9)
This seems to be working, but the test doesn't pass:
t/db_dependent/Koha/Account/Lines.t .. 1/5 # Failed test 'No tests run for subtest "item() tests"' # at t/db_dependent/Koha/Account/Lines.t line 67. DBIx::Class::Storage::DBI::_dbh_execute(): Field 'account_balance' doesn't have a default value at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 288 # Looks like your test exited with 255 just after 1. t/db_dependent/Koha/Account/Lines.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 5/5 subtests
Test Summary Report ------------------- t/db_dependent/Koha/Account/Lines.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 5 tests but ran 1. Files=1, Tests=1, 3 wallclock secs ( 0.01 usr 0.01 sys + 1.21 cusr 0.52 csys = 1.75 CPU) Result: FAIL
We applied the test on the latest provisioned kohadevbox environment and we found that there are some changes to pay.tt . When we changed pay.tt manually we passed dependency test as you may see below. prove t/db_dependent/Koha/Account/Lines.t t/db_dependent/Koha/Account/Lines.t .. ok All tests successful. Files=1, Tests=5, 5 wallclock secs ( 0.03 usr 0.01 sys + 3.90 cusr 0.66 csys = 4.60 CPU) Result: PASS How did you get your errors? Thanks, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82615|0 |1 is obsolete| | --- Comment #12 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 82846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82846&action=edit Bug 19489: Development for fines and Fees Module Due to changes in pay.tt occured from other patches we have renewed pay.tt file. Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82614|0 |1 is obsolete| | Attachment #82846|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83109&action=edit Bug 19489: (Improvements in Unit test and Koha::Account::Line->issue method) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83110&action=edit Bug 19489: Development for fines and Fees Module Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- due_date must be displayed with the as_due_date flag, not with_hours: [% your_due_date | $KohaDates as_due_date => 1 %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 2. As well, the html filter is not needed when already KohaDates filtered. 3. in printinvoice.pl +$accountline->{'item'} = $accountline->{itemnumber} ? $accountline_object->item : "" ; +$accountline->{'issue'} = $accountline->{issue_id} ? $accountline_object->issue : "" ; It read wrong, why not: $accountline->{item} = $accountline_object->item || "" ; $accountline->{issue} = $accountline_object->issue || ""; ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #17 from Devinim <kohadevinim@devinim.com.tr> --- (In reply to Jonathan Druart from comment #15)
due_date must be displayed with the as_due_date flag, not with_hours:
[% your_due_date | $KohaDates as_due_date => 1 %]
Hi Jonathan, In order to make code integrity, we've looked at members/readingrec.tt Line 95 of that file also uses due_date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #18 from Devinim <kohadevinim@devinim.com.tr> --- (In reply to Jonathan Druart from comment #16)
2. As well, the html filter is not needed when already KohaDates filtered.
3. in printinvoice.pl
+$accountline->{'item'} = $accountline->{itemnumber} ? $accountline_object->item : "" ; +$accountline->{'issue'} = $accountline->{issue_id} ? $accountline_object->issue : "" ;
It read wrong, why not: $accountline->{item} = $accountline_object->item || "" ; $accountline->{issue} = $accountline_object->issue || ""; ?
2. As similar to answer 1, some other files also use html filter like reserve/request.tt catalogue/issuehistory.tt 3. If you choose Create manual invoice tab and then select a type without using a barcode number (like New Card), since there won't be an itemnumber in accountline table, item object will give an error like ( DBIC result _type isn't of the _type Item at /home/vagrant/kohaclone/members/printinvoice.pl line 60) . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22006 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Devinim from comment #17)
(In reply to Jonathan Druart from comment #15)
due_date must be displayed with the as_due_date flag, not with_hours:
[% your_due_date | $KohaDates as_due_date => 1 %]
Hi Jonathan,
In order to make code integrity, we've looked at members/readingrec.tt Line 95 of that file also uses due_date.
It is wrong :) IIRC due dates must be displayed using the as_due_date flag, to not show the time part if 23:59 (In reply to Devinim from comment #18)
(In reply to Jonathan Druart from comment #16)
2. As well, the html filter is not needed when already KohaDates filtered.
2. As similar to answer 1, some other files also use html filter like reserve/request.tt catalogue/issuehistory.tt
It is because we removed the html filter when the $KohaDates occurrences were used without parameters. It is not a big deal anyway but we could avoid unnecessary processing removing these filters. I am going to deal with that on a separate bug report.
3. in printinvoice.pl
+$accountline->{'item'} = $accountline->{itemnumber} ? $accountline_object->item : "" ; +$accountline->{'issue'} = $accountline->{issue_id} ? $accountline_object->issue : "" ;
It read wrong, why not: $accountline->{item} = $accountline_object->item || "" ; $accountline->{issue} = $accountline_object->issue || ""; ?
3. If you choose Create manual invoice tab and then select a type without using a barcode number (like New Card), since there won't be an itemnumber in accountline table, item object will give an error like ( DBIC result _type isn't of the _type Item at /home/vagrant/kohaclone/members/printinvoice.pl line 60) .
It's a bug, I have opened bug 22006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 [Bug 22006] Koha::Account::Line->item should return undef if no item linked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83242&action=edit Bug 19489: Simplify the code a bit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83110|0 |1 is obsolete| | Attachment #83242|0 |1 is obsolete| | --- Comment #21 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 83276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83276&action=edit Bug 19489: (Improvements in KohaDate) Development for fines and Fees Module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83276|0 |1 is obsolete| | --- Comment #22 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 83277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83277&action=edit Bug 19489: (Improvements in KohaDate) Development for fines and Fees Module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83109|0 |1 is obsolete| | Attachment #83277|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83299&action=edit Bug 19489: Add the Koha::Account::Line->issue method Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83300&action=edit Bug 19489: Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83301&action=edit Bug 19489: Cover non-existent issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jesse@bywatersolutions.com |kohadevinim@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have updated the commit message, re-added the test plan and submitted a follow-up to cover the non-existing issue case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83299|0 |1 is obsolete| | --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83618&action=edit Bug 19489: Add the Koha::Account::Line->issue method Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83300|0 |1 is obsolete| | --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83619&action=edit Bug 19489: Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83301|0 |1 is obsolete| | --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83620&action=edit Bug 19489: Cover non-existent issue Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Cleared minor conflict when applying (test counts) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Bug 19489 depends on bug 22006, which changed state. Bug 22006 Summary: Koha::Account::Line->item should return undef if no item linked https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply Component|Architecture, internals, |Fines and fees |and plumbing | CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com Summary|Development for fines and |Detailed description of |Fees Module - Detailed |charges on Accounting tab |Description of charges in | |Patron Account Tab/Fines | |Tab | --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Devinim, can we please get a rebase? Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83618|0 |1 is obsolete| | Attachment #83619|0 |1 is obsolete| | Attachment #83620|0 |1 is obsolete| | --- Comment #32 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 85236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85236&action=edit Bug 19489: (Rebased) Koha::Account::Line->issue method and Unit test Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Lines.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #33 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 85237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85237&action=edit Bug 19489: (Rebased) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depending on how difficult the rebase was, it's ok to set back to "Signed off" after rebasing. If you feel it should be tested from scratch (hard rebase), setting to "Needs Signoff" is of course better. We usually keep the sign-off lines on the patches - it shows that someone spent time on it already. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #35 from Devinim <kohadevinim@devinim.com.tr> --- Hi Katrin, As you suggested I changed the Signed Off. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #36 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 85236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85236 Bug 19489: (Rebased) Koha::Account::Line->issue method and Unit test Review of attachment 85236: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19489&attachment=85236) ----------------------------------------------------------------- ::: Koha/Account/Line.pm @@ +55,5 @@
}
+=head3 issue + +Return the item linked to this account line if exists
item? @@ +59,5 @@
+Return the item linked to this account line if exists + +=cut + +sub issue {
According to Koha terminology, this should be named "checkout" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #37 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 85237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85237 Bug 19489: (Rebased) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Review of attachment 85237: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19489&attachment=85237) ----------------------------------------------------------------- ::: members/printinvoice.pl @@ +57,5 @@
my $total = $patron->account->balance; +my $accountline_object = Koha::Account::Lines->find($accountlines_id); +my $accountline = $accountline_object->unblessed; +$accountline->{item} = $accountline_object->item || "" ; +$accountline->{issue} = $accountline_object->issue || "";
We are still only adding this non-objective code, but as this file is still not fully refactored to using objects it is not blocker from me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | --- Comment #38 from Josef Moravec <josef.moravec@gmail.com> --- Failed because of issue method name. It really should be changed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #39 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 85275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85275&action=edit Bug 19489: Change method name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #40 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 85315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85315&action=edit Bug 19489: (follow-up) Fix typos in the tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85236|0 |1 is obsolete| | Attachment #85237|0 |1 is obsolete| | Attachment #85275|0 |1 is obsolete| | Attachment #85315|0 |1 is obsolete| | --- Comment #41 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85668&action=edit Bug 19489: Koha::Account::Line->issue method and Unit test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #42 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85669&action=edit Bug 19489: Detailed Description of charges in Patron accounting Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85670&action=edit Bug 19489: Change method name issue --> checkout Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #44 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85671&action=edit Bug 19489: (follow-up) Fix typos in the tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85672&action=edit Bug 19489: (QA follow-up) Cache checkout object in variable Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #46 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85673&action=edit Bug 19489: (QA follow-up) Update test to use objects and module methods for creating needed data Test plan: prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #47 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85674&action=edit Bug 19489: (QA follow-up) Remove passing issue_id in pay form This is not needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #48 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85675&action=edit Bug 19489: (QA follow-up) Revert changes in printinvoice It would be change behaviour, libraries are often using POS printers and wider table could make a problem for them and break theirs workflow. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #49 from Josef Moravec <josef.moravec@gmail.com> --- I added some follow-ups and am leaving this in signed off state. Would like to have another QA team member to look here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85668|0 |1 is obsolete| | Attachment #85669|0 |1 is obsolete| | Attachment #85670|0 |1 is obsolete| | Attachment #85671|0 |1 is obsolete| | Attachment #85672|0 |1 is obsolete| | Attachment #85673|0 |1 is obsolete| | Attachment #85674|0 |1 is obsolete| | Attachment #85675|0 |1 is obsolete| | --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85731&action=edit Bug 19489: Koha::Account::Line->issue method and Unit test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85732&action=edit Bug 19489: Detailed Description of charges in Patron accounting Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85733&action=edit Bug 19489: Change method name issue --> checkout Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85734&action=edit Bug 19489: (follow-up) Fix typos in the tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85735&action=edit Bug 19489: (QA follow-up) Cache checkout object in variable Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85736&action=edit Bug 19489: (QA follow-up) Update test to use objects and module methods for creating needed data Test plan: prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85737&action=edit Bug 19489: (QA follow-up) Remove passing issue_id in pay form This is not needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85738&action=edit Bug 19489: (QA follow-up) Revert changes in printinvoice It would be change behaviour, libraries are often using POS printers and wider table could make a problem for them and break theirs workflow. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 [Bug 15985] Include transacting library in fines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org