https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197065&action=edit Bug 42332: DT visibility - admin/categories Patch from commit 4eacc08 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197067&action=edit Bug 42332: DT visibility - catalogue/issuehistory Patch from commit 2bcdd66 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197069&action=edit Bug 42332: DT visibility - circ/overdue Patch from commit 6842f27 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197071&action=edit Bug 42332: DT visibility - members/readingrec Patch from commit 28fd51e -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197073&action=edit Bug 42332: DT visibility - reports/itemslost Patch from commit 5c431d2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197075&action=edit Bug 42332: DT visibility - tools/upload Patch from commit 57e3a98 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197077&action=edit Bug 42332: DT visibility - catalogue/detail Patch from commit acf456d -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199809&action=edit Bug 42332: DT visibility - admin/itemtypes Patch from commit 2667339 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197065|0 |1 is obsolete| | Attachment #197067|0 |1 is obsolete| | Attachment #197068|0 |1 is obsolete| | Attachment #197069|0 |1 is obsolete| | Attachment #197070|0 |1 is obsolete| | Attachment #197071|0 |1 is obsolete| | Attachment #197072|0 |1 is obsolete| | Attachment #197073|0 |1 is obsolete| | Attachment #197074|0 |1 is obsolete| | Attachment #197075|0 |1 is obsolete| | Attachment #197076|0 |1 is obsolete| | Attachment #197077|0 |1 is obsolete| | Attachment #197078|0 |1 is obsolete| | Attachment #199809|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200529&action=edit Bug 42332: DT visibility - catalogue/issuehistory Patch from commit b7608f6 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200531&action=edit Bug 42332: DT visibility - circ/overdue Patch from commit 30e311c -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200533&action=edit Bug 42332: DT visibility - members/readingrec Patch from commit acc1cc1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200535&action=edit Bug 42332: DT visibility - reports/itemslost Patch from commit b53cf0d -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200537&action=edit Bug 42332: DT visibility - tools/upload Patch from commit 6ab571d -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200539&action=edit Bug 42332: DT visibility - catalogue/detail Patch from commit 3e189ae -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200541&action=edit Bug 42332: DT visibility - admin/itemtypes Patch from commit 6bea0dd -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 [Bug 42910] Restore ability to save state for holdings table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Nind from comment #31)

How to test?

Not easy to be exhaustive, but I will try to write something. We are fixing a lot of bugs here, column's visibility related. * admin/categories Columns "Messaging", "Check previous checkout?" and "Can place ILL in OPAC?" depends on syspref (respectively EnhancedMessagingPreferences, CheckPrevCheckout, ILLModule). They must be added to the DOM, but the td should be empty and the column hidden if they are turned off. This is to make DT preserves the state stored in the localStorage even if one of the syspref changes. * catalogue/issuehistory same for column "Patron" (pref intranetreadinghistory and permissions borrowers_view_checkout_history, circulate_circulate_remaining_permissions) * cataloguing/z3950_search The column "additional_fields" was missing from the table settings yml file, so the visibility behaviour is certainly broken. Then column "Additional fields" depends on syspref AdditionalFieldsInZ3950ResultSearch * circ/overdue Column "Return claims" depends on pref ClaimReturnedLostValue * course_reserves/course-details "status" missing from yaml file Column "Item type" depends on syspref item_level_itypes and "Actions" on permissions coursereserves_add_reserves and coursereserves_delete_reserves * members/readingrec "checked_out_by" missing from yml file Column "Checked out by" depends on syspref RecordStaffUserOnCheckout * reports/guided_reports_start No change expected, but code adjusted to be inline with the current pattern * reports/itemslost First column "selection" was missing from yaml file Its visibility depends on the existence of CSV profiles defined * tools/inventory First column "Seen" depends on the screen you are. Without this patch I expect the column visibility state to not be restored correctly from one screen to another * tools/upload Columns "Public" and "Temporary" are hidden if we upload files from the cataloguing plugin "upload" * holds-table Column "hold-group" was missing from the yaml file Its visibility depends on the syspref DisplayAddHoldGroups * catalogue/detail Table "Comments", column "Actions" depends on the permission tools_moderate_comments * admin/itemtypes Extra column "lost_processing_fee" in yaml file Column "Image" depends on noItemTypeImages and OpacNoItemTypeImages Note that you need to `flush_memcached && koha-plack reload kohadev` so the yaml file will be fetched from the disk (not from the cache). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200528|0 |1 is obsolete| | Attachment #200529|0 |1 is obsolete| | Attachment #200530|0 |1 is obsolete| | Attachment #200531|0 |1 is obsolete| | Attachment #200532|0 |1 is obsolete| | Attachment #200533|0 |1 is obsolete| | Attachment #200534|0 |1 is obsolete| | Attachment #200535|0 |1 is obsolete| | Attachment #200536|0 |1 is obsolete| | Attachment #200537|0 |1 is obsolete| | Attachment #200538|0 |1 is obsolete| | Attachment #200539|0 |1 is obsolete| | Attachment #200540|0 |1 is obsolete| | Attachment #200541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201235&action=edit Bug 42332: DT visibility - catalogue/issuehistory Patch from commit f74a25d -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201237&action=edit Bug 42332: DT visibility - circ/overdue Patch from commit 9e1fce0 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201239&action=edit Bug 42332: DT visibility - members/readingrec Patch from commit ed24596 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201241&action=edit Bug 42332: DT visibility - reports/itemslost Patch from commit 639c27a -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201243&action=edit Bug 42332: DT visibility - tools/upload Patch from commit d9a0bf5 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201245&action=edit Bug 42332: DT visibility - catalogue/detail Patch from commit d3e7789 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #46 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201247&action=edit Bug 42332: DT visibility - admin/itemtypes Patch from commit 9d87179 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #48 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201248&action=edit Bug 42332: DT visibility - admin/categories Patch from commit 309068d -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #50 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201250&action=edit Bug 42332: DT visibility - cataloguing/z3950_search Patch from commit ce4c771 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #52 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201252&action=edit Bug 42332: DT visibility - course_reserves/course-details Patch from commit 23c2c26 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #54 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201254&action=edit Bug 42332: DT visibility - reports/guided_reports_start Patch from commit a21496b -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #56 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201256&action=edit Bug 42332: DT visibility - tools/inventory Patch from commit 3d6a3a2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #58 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201258&action=edit Bug 42332: DT visibility - holds-table Patch from commit 550adf8 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #60 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201260&action=edit Bug 42332: DT visibility - Add a test Patch from commit fd6722f -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #62 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202767&action=edit Bug 42332: DT visibility - admin/categories -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #64 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202769&action=edit Bug 42332: DT visibility - cataloguing/z3950_search -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #66 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202771&action=edit Bug 42332: DT visibility - course_reserves/course-details -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #68 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202773&action=edit Bug 42332: DT visibility - reports/guided_reports_start -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #70 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202775&action=edit Bug 42332: DT visibility - tools/inventory -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #72 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202777&action=edit Bug 42332: DT visibility - holds-table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #74 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202779&action=edit Bug 42332: DT visibility - Add a test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #76 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202781&action=edit Bug 42332: (bug 41954 follow-up) Fix hold_group_id -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202767|0 |1 is obsolete| | Attachment #202768|0 |1 is obsolete| | Attachment #202769|0 |1 is obsolete| | Attachment #202770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #78 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203808&action=edit Bug 42332: DT visibility - catalogue/issuehistory Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #80 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203810&action=edit Bug 42332: DT visibility - circ/overdue Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #81 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203849&action=edit Bug 42332: DT visibility - tools/inventory Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202771|0 |1 is obsolete| | Attachment #202772|0 |1 is obsolete| | Attachment #202773|0 |1 is obsolete| | Attachment #202774|0 |1 is obsolete| | Attachment #202776|0 |1 is obsolete| | Attachment #202777|0 |1 is obsolete| | Attachment #202778|0 |1 is obsolete| | Attachment #202779|0 |1 is obsolete| | Attachment #202780|0 |1 is obsolete| | Attachment #202781|0 |1 is obsolete| | Attachment #203807|0 |1 is obsolete| | Attachment #203808|0 |1 is obsolete| | Attachment #203809|0 |1 is obsolete| | Attachment #203810|0 |1 is obsolete| | Attachment #203849|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #84 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 203976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203976&action=edit Bug 42332: DT visibility - members/readingrec -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #86 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 203978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203978&action=edit Bug 42332: DT visibility - reports/itemslost -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #88 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 203980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203980&action=edit Bug 42332: DT visibility - holds-table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #90 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 203982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203982&action=edit Bug 42332: DT visibility - Add a test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #92 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 203984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203984&action=edit Bug 42332: (bug 41954 follow-up) Fix hold_group_id -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #94 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 203986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203986&action=edit Bug 42332: DT visibility - catalogue/issuehistory Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #96 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 203988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203988&action=edit Bug 42332: DT visibility - circ/overdue Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #98 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #82) Hi Owen, thanks for testing!

...

Bug 42332: DT visibility - tools/upload

I'm not sure how to test this one. The column hiding seems to be related to plugins somehow but I'm not sure.

Did you see comment 32? ``` * tools/upload Columns "Public" and "Temporary" are hidden if we upload files from the cataloguing plugin "upload" ```

...

Bug 42332: DT visibility - holds-table

This works if EnableItemGroupHolds is enabled, but I get an error if EnableItemGroupHolds is disabled. "Uncaught TypeError: can't access property "sClass", a is undefined"

I've noticed another error, squashed this into patch "(bug 41954 follow-up) Fix hold_group_id" admin/columns_settings.yml + - + columnname: hold_group_id - columnname: author koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt @ koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt:130 @ - [% IF Koha.Preference('DisplayAddHoldGroups') %] - <th data-colname="hold_group_id">Hold group ID</th> - [% END %] + <th data-colname="hold_group_id">Hold group ID</th> Can you confirm it fixes the error for you?

...

Bug 42332: DT visibility - catalogue/detail

Looks like the only change was with the table of comments under the comments tab. The "Actions" column is supposed to hidden if the user doesn't have permission to approve or delete? In my test the column is not hidden.

Found 2 bugs there: - <th data-colname="comments">Comment</th> + <th data-colname="comment">Comment</th> var comment_table_settings = [% TablesSettings.GetTableSettings('catalogue', 'detail', 'comments-table', 'json') | $raw %]; - let actions_column = table_settings.columns.find(c => c.columnname == 'actions'); + let actions_column = comment_table_settings.columns.find(c => c.columnname == 'actions'); actions_column.visibility_condition = [% CAN_user_tools_moderate_comments ? 'true' : 'false' | html %]; squashed. Can you please retest? :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #99 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204046&action=edit Bug 42332: DT visibility - course_reserves/course-details Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #101 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204048&action=edit Bug 42332: DT visibility - reports/guided_reports_start Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203979|0 |1 is obsolete| | Attachment #203981|0 |1 is obsolete| | Attachment #203982|0 |1 is obsolete| | Attachment #203983|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #104 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204060&action=edit Bug 42332: DT visibility - catalogue/detail Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #106 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204062&action=edit Bug 42332: DT visibility - admin/itemtypes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #108 from Owen Leonard <oleonard@myacpl.org> ---

Bug 42332: (bug 41954 follow-up) Fix hold_group_id

Same error with this one, 'Uncaught TypeError: can't access property "sClass", a is undefined.' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203980|0 |1 is obsolete| | Attachment #203984|0 |1 is obsolete| | Attachment #203985|0 |1 is obsolete| | Attachment #203986|0 |1 is obsolete| | Attachment #203987|0 |1 is obsolete| | Attachment #203988|0 |1 is obsolete| | Attachment #203989|0 |1 is obsolete| | Attachment #204046|0 |1 is obsolete| | Attachment #204047|0 |1 is obsolete| | Attachment #204048|0 |1 is obsolete| | Attachment #204049|0 |1 is obsolete| | Attachment #204059|0 |1 is obsolete| | Attachment #204060|0 |1 is obsolete| | Attachment #204061|0 |1 is obsolete| | Attachment #204062|0 |1 is obsolete| | Attachment #204082|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #111 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204209&action=edit Bug 42332: (bug 41954 follow-up) Fix hold_group_id Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #113 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204211&action=edit Bug 42332: DT visibility - catalogue/issuehistory Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #115 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204213&action=edit Bug 42332: DT visibility - circ/overdue Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #117 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204215&action=edit Bug 42332: DT visibility - course_reserves/course-details Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #119 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204217&action=edit Bug 42332: DT visibility - reports/guided_reports_start Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #121 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204219&action=edit Bug 42332: DT visibility - tools/upload Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #123 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204221&action=edit Bug 42332: DT visibility - Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #125 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 204223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204223&action=edit Bug 42332: holds-table - Fix JS error when DisplayAddHoldGroups is off We have to return an empty cell when the pref is off, not let a gap in the column list. 'Uncaught TypeError: can't access property "sClass", a is undefined.' Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40626 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40626 [Bug 40626] Edit button in item holdings table on bib details page should offer the same options as on Manage Items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204213|0 |1 is obsolete| | Attachment #204214|0 |1 is obsolete| | Attachment #204215|0 |1 is obsolete| | Attachment #204216|0 |1 is obsolete| | Attachment #204217|0 |1 is obsolete| | Attachment #204218|0 |1 is obsolete| | Attachment #204219|0 |1 is obsolete| | Attachment #204220|0 |1 is obsolete| | Attachment #204221|0 |1 is obsolete| | Attachment #204222|0 |1 is obsolete| | Attachment #204223|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #129 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205114&action=edit Bug 42332: DT visibility - tools/inventory Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #131 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205116&action=edit Bug 42332: DT visibility - members/readingrec Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #133 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205118&action=edit Bug 42332: DT visibility - reports/itemslost Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #135 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205120&action=edit Bug 42332: DT visibility - catalogue/detail Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #137 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205122&action=edit Bug 42332: DT visibility - admin/itemtypes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|emily.lamancusa@montgomeryc |testopia@bugs.koha-communit |ountymd.gov |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204208|0 |1 is obsolete| | Attachment #204209|0 |1 is obsolete| | Attachment #204210|0 |1 is obsolete| | Attachment #204211|0 |1 is obsolete| | Attachment #204212|0 |1 is obsolete| | Attachment #205113|0 |1 is obsolete| | Attachment #205114|0 |1 is obsolete| | Attachment #205115|0 |1 is obsolete| | Attachment #205116|0 |1 is obsolete| | Attachment #205117|0 |1 is obsolete| | Attachment #205118|0 |1 is obsolete| | Attachment #205119|0 |1 is obsolete| | Attachment #205120|0 |1 is obsolete| | Attachment #205121|0 |1 is obsolete| | Attachment #205122|0 |1 is obsolete| | Attachment #205123|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #140 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207128&action=edit Bug 42332: (bug 41954 follow-up) Fix hold_group_id Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #142 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207130&action=edit Bug 42332: DT visibility - catalogue/issuehistory Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #144 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207132&action=edit Bug 42332: DT visibility - circ/overdue Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #146 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207134&action=edit Bug 42332: DT visibility - course_reserves/course-details Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #148 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207136&action=edit Bug 42332: DT visibility - reports/guided_reports_start Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #150 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207138&action=edit Bug 42332: DT visibility - tools/upload Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #152 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207140&action=edit Bug 42332: DT visibility - Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 --- Comment #154 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207142&action=edit Bug 42332: holds-table - Fix JS error when DisplayAddHoldGroups is off We have to return an empty cell when the pref is off, not let a gap in the column list. 'Uncaught TypeError: can't access property "sClass", a is undefined.' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.