[Bug 8544] New: Make RSS icon styleable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Priority: P5 - low Change sponsored?: --- Bug ID: 8544 Assignee: oleonard@myacpl.org Summary: Make RSS icon styleable Severity: enhancement Classification: Unclassified OS: All Reporter: robin@catalyst.net.nz Hardware: All Status: NEW Version: rel_3_8 Component: OPAC Product: Koha The RSS icon on the results page doesn't have a CSS class attached, so it's not able to be messed with easily. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 11234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11234&action=edit Bug 8544 - make the RSS icon CSS-changeable This gives the RSS bits on the search results some CSS classes so it can be modified with CSS or javascript. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- This applies on 3.8 nicely, should anyone want it for there too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11234|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11247&action=edit Bug 8544 - make the RSS icon CSS-changeable This gives the RSS bits on the search results some CSS classes so it can be modified with CSS or javascript. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 11297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11297&action=edit Bug 8544 - make the RSS icon CSS-changeable This gives the RSS bits on the search results some CSS classes so it can be modified with CSS or javascript. Updated: added also to the RSS icon shown when no results are found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11247|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> --- I missed an instance of the RSS icon, so replacing the previous patch with one that does both. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11297|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 11320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11320&action=edit [SIGNED-OFF] Bug 8544 - make the RSS icon CSS-changeable This gives the RSS bits on the search results some CSS classes so it can be modified with CSS or javascript. Updated: added also to the RSS icon shown when no results are found. Signed-off-by: Marc Veron <veron@veron.ch> Patch behaves as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Add 2 class for the RSS icon (the 2 only occurrences). Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed. It's a minor enhancement, probably not for 3.8, but chris_c, it's up to you, Robin put 3.8, I don't change it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz Severity|enhancement |trivial --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Adding a class to 2 html elements, no visible change at all, but allows them to be styled now. Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org