[Bug 20968] New: Plugins: Add hooks to enable plugin integration into catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Bug ID: 20968 Summary: Plugins: Add hooks to enable plugin integration into catalogue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org This bug will add Koha Plugin hooks into catalogue related code allowing integration into areas such as koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 76374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76374&action=edit Add hooks into cat-toolbar.inc to display buttons This commit adds hooks into cat-toolbar.inc to allow the display of arbitrary buttons as supplied by plugins within the intranet_catalog_biblio_enhancements class that provide the method get_toolbar_button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 76375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76375&action=edit Bug 20968: Add hooks into cat-toolbar.inc to display buttons This commit adds hooks into cat-toolbar.inc to allow the display of arbitrary buttons as supplied by plugins within the intranet_catalog_biblio_enhancements class that provide the method get_toolbar_button To test: 1) Download the plugin from https://github.com/PTFS-Europe/cla-permissions-check-plugin 2) Follow the installation instructions from: https://github.com/PTFS-Europe/cla-permissions-check-plugin 3) TEST: Observe that the "CLA Check Permissions" button takes the user to the Check Permissions page and a modal displays containing the results of the query 4) Remove the API key from the plugin "Configuration" page 5) TEST: Ensure that the "CLA Check Permissions" button takes the user to the Check Permissions page and message displays informing the user that "Did not receive required request parameters" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76374|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- I see a few issues the shouldn't be hard to resolve: 1) Unit tests ( they are super simple, but should be there anyway ) 2) Why test for the method intranet_catalog_biblio_enhancements, but then call the method get_toolbar_button? A) You can check for the method get_toolbar_button directly, and B) You are calling get_toolbar_button twice per plugin, which seems like waste of cycles. 3) After resolving 1 and 2, could you also make pull request to the kitchen sink plugin (https://github.com/bywatersolutions/koha-plugin-kitchen-sink) to add an example to it? That plugin is basically out documentation for the plugin system's functionality at this time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- 4) I forgot to make explicit that it seems like the method intranet_catalog_biblio_enhancements is not really necessary and should be removed and replaced with a GetPlugins call for get_toolbar_button instead. 5) Can you make the method names a bit more explicit? I think get_opac_toolbar_button would be better than get_toolbar_button so future developers have a bit better an idea what it does without further research. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- On further inspection, I go with something even more specific, get_opac_catalog_toolbar_button, which completely disambiguates where this button will appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Kyle Many thanks for this feedback, very helpful indeed. 1) Yes indeed, I completely overlooked tests, I'll address this. 2) Good point, well spotted. I'll fix this. 3) Yes, will do 4) I'm not clear whether you're suggesting we should ditch the intranet_catalog_biblio_enhancements method entirely. I don't think we can do this as we need to be able to test in plugins-home.pl/.tt for plugins that are within this class. If you just meant I should drop it from detail.pm as mentioned in 2), yes, I will do this. 5) Yes, good idea, will do Thanks again. I'll update here once this is all done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #7 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Kyle Looking at 1), I'm not sure writing tests for this tiny amount of core integration is even possible. All we're doing is populating a template parameter under a certain condition, I don't think we can meaningfully test that. Any thoughts? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 76530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76530&action=edit Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing for intranet_catalog_biblio_enhancements method in detail.pl - Renames get_toolbar_button to get_intranet_catalog_toolbar_button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76531&action=edit Bug 20968: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76532&action=edit Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> ---
4) I'm not clear whether you're suggesting we should ditch the intranet_catalog_biblio_enhancements method entirely. I don't think we can do this as we need to be able to test in plugins-home.pl/.tt for plugins that are within this class. If you just meant I should drop it from detail.pm as mentioned in 2), yes, I will do this.
I didn't fully understand it's purpose at first. What you've done in the followup is excellent. I've added to more patches for you, one that add's those unit tests, and another that renames get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button I know that's quite wordy, but it keeps the naming convention to be in line with the naming convention for the opac payment methods. If you these followups work for you, I think we'll be good to go! Just sign off on my patches, I'll sign off on yours and we can let someone else QA. Once it's passed qa, I'll add those methods to the Kitchen Sink plugin as well! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Apologies for all the typos in my last reply. It's just one of those days I guess ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76532|0 |1 is obsolete| | --- Comment #13 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 76540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76540&action=edit Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76531|0 |1 is obsolete| | --- Comment #14 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 76541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76541&action=edit Bug 20968: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #15 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Kyle Perfect, thanks very much for that. I've tested and signed off (I think) your patches. Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #16 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 76555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76555&action=edit Bug 20968: (follow-up) Replace tabs with spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76375|0 |1 is obsolete| | Attachment #76530|0 |1 is obsolete| | Attachment #76540|0 |1 is obsolete| | Attachment #76541|0 |1 is obsolete| | Attachment #76555|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76564&action=edit Bug 20968: Add hooks into cat-toolbar.inc to display buttons This commit adds hooks into cat-toolbar.inc to allow the display of arbitrary buttons as supplied by plugins within the intranet_catalog_biblio_enhancements class that provide the method get_toolbar_button To test: 1) Download the plugin from https://github.com/PTFS-Europe/cla-permissions-check-plugin 2) Follow the installation instructions from: https://github.com/PTFS-Europe/cla-permissions-check-plugin 3) TEST: Observe that the "CLA Check Permissions" button takes the user to the Check Permissions page and a modal displays containing the results of the query 4) Remove the API key from the plugin "Configuration" page 5) TEST: Ensure that the "CLA Check Permissions" button takes the user to the Check Permissions page and message displays informing the user that "Did not receive required request parameters" https://bugs.koha-community.org/show_bug.cgi?id=20968 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76565&action=edit Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing for intranet_catalog_biblio_enhancements method in detail.pl - Renames get_toolbar_button to get_intranet_catalog_toolbar_button Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76566&action=edit Bug 20968: Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76567&action=edit Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76568&action=edit Bug 20968: (follow-up) Replace tabs with spaces Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Applying: Bug 20968: (follow-up) Replace tabs with spaces error: sha1 information is lacking or useless (catalogue/detail.pl). error: could not build fake ancestor Patch failed at 0001 Bug 20968: (follow-up) Replace tabs with spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #23 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Any clue as to why this patch isn't applying for you Jonathan? It's literally replacing tabs with spaces, so no idea why it wouldn't apply. Presumably since Kyle signed it off, it applied for him? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Andrew Isherwood from comment #23)
Any clue as to why this patch isn't applying for you Jonathan? It's literally replacing tabs with spaces, so no idea why it wouldn't apply. Presumably since Kyle signed it off, it applied for him?
It longer applies for me either. Here's the conflict that needs resolved in detail.pl: 313 <<<<<<< HEAD 314 315 316 if ( $analyze ) { 317 # count if item is used in analytical bibliorecords 318 # The 'countanalytics' flag is only used in the templates if analyze is set 319 my $countanalytics = C4::Context->preference('EasyAnalyticalRecords') ? GetAnalyticsCount($item->{itemnumber}) : 0; 320 if ($countanalytics > 0){ 321 $analytics_flag=1; 322 $item->{countanalytics} = $countanalytics; 323 } 324 ======= 325 326 #count if item is used in analytical bibliorecords 327 my $countanalytics= GetAnalyticsCount($item->{itemnumber}); 328 if ($countanalytics > 0){ 329 $analytics_flag=1; 330 $item->{countanalytics} = $countanalytics; 331 >>>>>>> Bug 20968: (follow-up) Replace tabs with spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76564|0 |1 is obsolete| | --- Comment #25 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 77782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77782&action=edit Bug 20968: Add hooks into cat-toolbar.inc to display buttons This commit adds hooks into cat-toolbar.inc to allow the display of arbitrary buttons as supplied by plugins within the intranet_catalog_biblio_enhancements class that provide the method get_toolbar_button To test: 1) Download the plugin from https://github.com/PTFS-Europe/cla-permissions-check-plugin 2) Follow the installation instructions from: https://github.com/PTFS-Europe/cla-permissions-check-plugin 3) TEST: Observe that the "CLA Check Permissions" button takes the user to the Check Permissions page and a modal displays containing the results of the query 4) Remove the API key from the plugin "Configuration" page 5) TEST: Ensure that the "CLA Check Permissions" button takes the user to the Check Permissions page and message displays informing the user that "Did not receive required request parameters" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76565|0 |1 is obsolete| | --- Comment #26 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 77783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77783&action=edit Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing for intranet_catalog_biblio_enhancements method in detail.pl - Renames get_toolbar_button to get_intranet_catalog_toolbar_button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76566|0 |1 is obsolete| | --- Comment #27 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 77784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77784&action=edit Bug 20968: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76567|0 |1 is obsolete| | --- Comment #28 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 77785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77785&action=edit Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76568|0 |1 is obsolete| | --- Comment #29 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 77786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77786&action=edit Bug 20968: (follow-up) Replace tabs with spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #30 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Rebased on top of master. To test: 1) Download the plugin from https://github.com/PTFS-Europe/cla-permissions-check-plugin 2) Follow the installation instructions from: https://github.com/PTFS-Europe/cla-permissions-check-plugin 3) TEST: Observe that the "CLA Check Permissions" button takes the user to the Check Permissions page and a modal displays containing the results of the query 4) Remove the API key from the plugin "Configuration" page 5) TEST: Ensure that the "CLA Check Permissions" button takes the user to the Check Permissions page and message displays informing the user that "Did not receive required request parameters" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77782|0 |1 is obsolete| | --- Comment #31 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78457&action=edit Bug 20968: Add hooks into cat-toolbar.inc to display buttons This commit adds hooks into cat-toolbar.inc to allow the display of arbitrary buttons as supplied by plugins within the intranet_catalog_biblio_enhancements class that provide the method get_toolbar_button To test: 1) Download the plugin from https://github.com/PTFS-Europe/cla-permissions-check-plugin 2) Follow the installation instructions from: https://github.com/PTFS-Europe/cla-permissions-check-plugin 3) TEST: Observe that the "CLA Check Permissions" button takes the user to the Check Permissions page and a modal displays containing the results of the query 4) Remove the API key from the plugin "Configuration" page 5) TEST: Ensure that the "CLA Check Permissions" button takes the user to the Check Permissions page and message displays informing the user that "Did not receive required request parameters" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77783|0 |1 is obsolete| | --- Comment #32 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78458&action=edit Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing for intranet_catalog_biblio_enhancements method in detail.pl - Renames get_toolbar_button to get_intranet_catalog_toolbar_button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77784|0 |1 is obsolete| | --- Comment #33 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78459&action=edit Bug 20968: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77785|0 |1 is obsolete| | --- Comment #34 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78460&action=edit Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77786|0 |1 is obsolete| | --- Comment #35 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78461&action=edit Bug 20968: (follow-up) Replace tabs with spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78457|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79804&action=edit Bug 20968: Add hooks into cat-toolbar.inc to display buttons This commit adds hooks into cat-toolbar.inc to allow the display of arbitrary buttons as supplied by plugins within the intranet_catalog_biblio_enhancements class that provide the method get_toolbar_button To test: 1) Download the plugin from https://github.com/PTFS-Europe/cla-permissions-check-plugin 2) Follow the installation instructions from: https://github.com/PTFS-Europe/cla-permissions-check-plugin 3) TEST: Observe that the "CLA Check Permissions" button takes the user to the Check Permissions page and a modal displays containing the results of the query 4) Remove the API key from the plugin "Configuration" page 5) TEST: Ensure that the "CLA Check Permissions" button takes the user to the Check Permissions page and message displays informing the user that "Did not receive required request parameters" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78458|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79805&action=edit Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing for intranet_catalog_biblio_enhancements method in detail.pl - Renames get_toolbar_button to get_intranet_catalog_toolbar_button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78459|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79806&action=edit Bug 20968: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78460|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79807&action=edit Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78461|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79808&action=edit Bug 20968: (follow-up) Replace tabs with spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased upon master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #42 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- More detailed test plan: - Follow the installation and configuration instructions from: https://github.com/PTFS-Europe/cla-permissions-check-plugin - Go to the bib details for a record, selecting the "Normal" tab - You should see a "CLA Permissions Check" button in the button bar above the bib details, click it - This should take you to a new screen and a modal should load containing the results of the permissions check => TEST: Observe that the "CLA Check Permissions" button takes the user to the Check Permissions page and a modal displays containing the results of the query - In order to perform the second test, it is necessary to remove the API key previously entered, so navigate back to the plugin configuration screen and remove the API, then click "Save configuration" - Navigate back to the bib record and click the "CLA permissions check" button => TEST: Ensure that the "CLA Check Permissions" button takes the user to the Check Permissions page and message displays informing the user that "Did not receive required request parameters" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79804|0 |1 is obsolete| | --- Comment #43 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 80394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80394&action=edit Bug 20968: Add hooks into cat-toolbar.inc to display buttons This commit adds hooks into cat-toolbar.inc to allow the display of arbitrary buttons as supplied by plugins within the intranet_catalog_biblio_enhancements class that provide the method get_toolbar_button To test: 1) Download the plugin from https://github.com/PTFS-Europe/cla-permissions-check-plugin 2) Follow the installation instructions from: https://github.com/PTFS-Europe/cla-permissions-check-plugin 3) TEST: Observe that the "CLA Check Permissions" button takes the user to the Check Permissions page and a modal displays containing the results of the query 4) Remove the API key from the plugin "Configuration" page 5) TEST: Ensure that the "CLA Check Permissions" button takes the user to the Check Permissions page and message displays informing the user that "Did not receive required request parameters" https://bugs.koha-community.org/show_bug.cgi?id=20968 Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79805|0 |1 is obsolete| | --- Comment #44 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 80395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80395&action=edit Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing for intranet_catalog_biblio_enhancements method in detail.pl - Renames get_toolbar_button to get_intranet_catalog_toolbar_button Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79806|0 |1 is obsolete| | --- Comment #45 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 80396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80396&action=edit Bug 20968: Add unit tests Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79807|0 |1 is obsolete| | --- Comment #46 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 80397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80397&action=edit Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79808|0 |1 is obsolete| | --- Comment #47 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 80398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80398&action=edit Bug 20968: (follow-up) Replace tabs with spaces Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80394|0 |1 is obsolete| | Attachment #80395|0 |1 is obsolete| | Attachment #80396|0 |1 is obsolete| | Attachment #80397|0 |1 is obsolete| | Attachment #80398|0 |1 is obsolete| | --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80615&action=edit Bug 20968: Add hooks into cat-toolbar.inc to display buttons This commit adds hooks into cat-toolbar.inc to allow the display of arbitrary buttons as supplied by plugins within the intranet_catalog_biblio_enhancements class that provide the method get_toolbar_button To test: 1) Download the plugin from https://github.com/PTFS-Europe/cla-permissions-check-plugin 2) Follow the installation instructions from: https://github.com/PTFS-Europe/cla-permissions-check-plugin 3) TEST: Observe that the "CLA Check Permissions" button takes the user to the Check Permissions page and a modal displays containing the results of the query 4) Remove the API key from the plugin "Configuration" page 5) TEST: Ensure that the "CLA Check Permissions" button takes the user to the Check Permissions page and message displays informing the user that "Did not receive required request parameters" https://bugs.koha-community.org/show_bug.cgi?id=20968 Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80616&action=edit Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing for intranet_catalog_biblio_enhancements method in detail.pl - Renames get_toolbar_button to get_intranet_catalog_toolbar_button Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80617&action=edit Bug 20968: Add unit tests Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80618&action=edit Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80619&action=edit Bug 20968: (follow-up) Replace tabs with spaces Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 as per my policy of backporting easily backportable non-consumer facing plugin support changes (to allow for the greatest span of plugin support). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored by PTFS Europe release notes| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21900 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21900 [Bug 21900] intranet_catalog_biblio_enhancements_toolbar_button plugin hook broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #55 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Before pushing to 17.11.x, I'd like to see it in kitchen sink plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905 [Bug 21905] Plugin hook intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #56 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Fridolin - It seems that Kyle has added support for it in the Kitchen Sink plugin. The test plan for Bug 21905 tests this area and requires use of the Kitchen Sink -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #57 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Andrew Isherwood from comment #56)
Hi Fridolin - It seems that Kyle has added support for it in the Kitchen Sink plugin. The test plan for Bug 21905 tests this area and requires use of the Kitchen Sink
Ok i see it today in plugin sources -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #58 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.13 "\\//_ Live long and prosper" -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org