[Bug 32141] New: Identity provider textboxes too small on edit pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 Bug ID: 32141 Summary: Identity provider textboxes too small on edit pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org When adding an Identity Provider, the textboxes are 75 columns by 10 rows. But when editing an Identity Provider, the boxes don't have explicit sizing, and they're too small and always need to be manually resized. Not a big drama but it's annoying. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31378 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Identity provider textboxes |New and Edit Identity |too small on edit pages |Provider UIs inconsistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 143455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143455&action=edit Bug 32141: Fix textbox formatting on edit IdP screen This patch makes the textbox have the same number of rows and columns on the "Edit" page as it does on the "New" page for Identity Providers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 143456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143456&action=edit Bug 32141: Add missing fieldset legends and titlecase "matchpoint" This patch adds missing fieldset legends and titlecases "matchpoint", so that the "Edit" UI is consistent with the "New" UI for adding and modifying Identity Providers. Test plan: 1) Apply patches 2) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form 3) Fill out the fields to add an identity provider 4) Click "Edit" next to the Identity Provider in the list 5) In a new tab, go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form 6) Compare the two screens and note that all the labels, inputs, and help text are the same on both screens. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #0)
When adding an Identity Provider, the textboxes are 75 columns by 10 rows.
But when editing an Identity Provider, the boxes don't have explicit sizing, and they're too small and always need to be manually resized.
Not a big drama but it's annoying.
Yeah, I added that on my last follow-up on the bug, and forgot to tweak the edit page. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New and Edit Identity |New and edit identity |Provider UIs inconsistent |provider UIs inconsistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143456|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143455|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143525&action=edit Bug 32141: Fix textbox formatting on edit IdP screen This patch makes the textbox have the same number of rows and columns on the "Edit" page as it does on the "New" page for Identity Providers. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143526&action=edit Bug 32141: Add missing fieldset legends and titlecase "matchpoint" This patch adds missing fieldset legends and titlecases "matchpoint", so that the "Edit" UI is consistent with the "New" UI for adding and modifying Identity Providers. Test plan: 1) Apply patches 2) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form 3) Fill out the fields to add an identity provider 4) Click "Edit" next to the Identity Provider in the list 5) In a new tab, go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form 6) Compare the two screens and note that all the labels, inputs, and help text are the same on both screens. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 Bug 32141 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org