http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711 Alex <alex.sassmannshausen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |alex.sassmannshausen@gmail. | |com --- Comment #2 from Alex <alex.sassmannshausen@gmail.com> --- Hello Owen, During my review of the patch I came across what looks like a regression: - After applying the patch - 'Holds Awaiting Pickup' report loads with glitches - Sort by date will not work - Sort by title fixes the glitches and sorts OK. - Firebug in my version of Firefox reports 3 JS errors every time date sort is attempted Before the patch the page renders fine and the sorts work. As this is my first review, please let me know if I need to provide additional information. Best wishes, Alex -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25149|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 26105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26105&action=edit Bug 11711 - Use new DataTables include in circ templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all circ-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Circulation - The UseTablesortForCirc system preference must be enabled. - Check out to a patron with existing checkouts. Choose a patron who is a guarantor to another patron with checkouts in order to test the relatives' checkouts table. - The checkouts and relatives' checkouts tables have been modified to exclude articles when sorting of titles. - Hold ratios - The title column has been configured to exclude articles from sorting - Transfer to receive - Holds queue - The title column has been configured to exclude articles when sorting - The date column has been modified to use the title-string filter for sorting. An unformatted date is now passed from C4::HoldsQueue.pm to the template, where the KohaDates filter is used for formatting. Sorting is based on the unformatted date. - Holds awaiting pickup - The "available since" column has been configured for sorting on an unformatted date. waitingreserves.pl now passes the unformatted date to the template, and formatting is done using the KohaDates filter. - The title column has been configured to exclude articles when sorting. Edit: Rebased on current master following commit of Bug 11605 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711 Alex <alex.sassmannshausen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Alex <alex.sassmannshausen@gmail.com> --- Hi Owen, Unfortunately the rebase does not seem to have fixed the issue: I'm still getting full success for all pages, except for http://testsystem/cgi-bin/koha/circ/waitingreserves.pl?allbranches=1 As before: - After applying the patch - 'Holds Awaiting Pickup' report loads with glitches - Sort by date will not work - Sort by title fixes the glitches and sorts OK. - Sort by date will still not work. - Firebug in my version of Firefox reports 3 JS errors every time date sort is attempted Before the patch the page renders fine and the sorts work. In addition to what I said before, some of the JS errors are not a regression, they occur in the pre-patch version too. The error that is a regression is: Firebug: On page load: TypeError: a.match(...) is null Every click on the 'Available since' <td> causes the error to re-appear. HTH, Alex -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711 Alex Sassmannshausen <alex.sassmannshausen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26116|0 |1 is obsolete| | --- Comment #7 from Alex Sassmannshausen <alex.sassmannshausen@gmail.com> --- Created attachment 26128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26128&action=edit Bug 11711 - Use new DataTables include in circ templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all circ-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Circulation - The UseTablesortForCirc system preference must be enabled. - Check out to a patron with existing checkouts. Choose a patron who is a guarantor to another patron with checkouts in order to test the relatives' checkouts table. - The checkouts and relatives' checkouts tables have been modified to exclude articles when sorting of titles. - Hold ratios - The title column has been configured to exclude articles from sorting - Transfer to receive - Holds queue - The title column has been configured to exclude articles when sorting - The date column has been modified to use the title-string filter for sorting. An unformatted date is now passed from C4::HoldsQueue.pm to the template, where the KohaDates filter is used for formatting. Sorting is based on the unformatted date. - Holds awaiting pickup - The "available since" column has been configured for sorting on an unformatted date. waitingreserves.pl now passes the unformatted date to the template, and formatting is done using the KohaDates filter. - The title column has been configured to exclude articles when sorting. Edit: Rebased on current master following commit of Bug 11605 Signed-off-by: A. Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.