[Bug 21754] New: If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Bug ID: 21754 Summary: If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When an item is marked as lost automatically cancel any outstanding transfers on it (this is an alternative to bug 21732 - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732- which checks if a syspref is enabled before cancelling outstanding transfers on the lost item). Also set the items holding branch to the transfers source ('from') branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81854&action=edit Bug 21754: Automatically clean up outstanding transfers on lost items This is an alternative to bug 21732 as transfers are automatically cancelled on marking an item lost, and the items holding rbanch is set to the transfers source ('from') branch. When an item is marked as lost, the routine should also clean up any outstanding transfers. Also added tests to t/db_dependent/Circulation.t which check: * If transfer is automatically deleted when item is marked as lost * If the items holdingbranch automatically changes when item with transfers on it is marked as lost. Test plan: 1. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 2. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 3. Notice that the transfer is now cancelled for the item and the items holdingbranch is the transfers source ('from') branch 4. Run t/db_dependent/Circulation.t Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21732 Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We sought additional feedback on the mailing lists and currently, the feedback (https://lists.katipo.co.nz/public/koha/2018-November/051788.html) is that this version of the bug is preferable to the original bug 21732, as such I'm going to mark that one as a duplicate and close it so we can move forward with this preferred approach. I'll try to find someone to signoff today so I can proceed with QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 [Bug 20844] Reset a hold when it is missing after allocation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 21732 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81854|0 |1 is obsolete| | --- Comment #4 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- Created attachment 82016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82016&action=edit Bug 21754: Automatically clean up outstanding transfers on lost items This is an alternative to bug 21732 as transfers are automatically cancelled on marking an item lost, and the items holding rbanch is set to the transfers source ('from') branch. When an item is marked as lost, the routine should also clean up any outstanding transfers. Also added tests to t/db_dependent/Circulation.t which check: * If transfer is automatically deleted when item is marked as lost * If the items holdingbranch automatically changes when item with transfers on it is marked as lost. Test plan: 1. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 2. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 3. Notice that the transfer is now cancelled for the item and the items holdingbranch is the transfers source ('from') branch 4. Run t/db_dependent/Circulation.t Sponsored-By: Brimbank Library, Australia Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82016|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82017&action=edit Bug 21754: Automatically clean up outstanding transfers on lost items This is an alternative to bug 21732 as transfers are automatically cancelled on marking an item lost, and the items holding rbanch is set to the transfers source ('from') branch. When an item is marked as lost, the routine should also clean up any outstanding transfers. Also added tests to t/db_dependent/Circulation.t which check: * If transfer is automatically deleted when item is marked as lost * If the items holdingbranch automatically changes when item with transfers on it is marked as lost. Test plan: 1. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 2. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 3. Notice that the transfer is now cancelled for the item and the items holdingbranch is the transfers source ('from') branch 4. Run t/db_dependent/Circulation.t Sponsored-by: Brimbank Library, Australia Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> (fixed the introduction of a whitespace line and removed a double declare warning from the new tests as part of QA) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work Alex, thank you for all the perseverance. No regressions found, Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |If an item is marked as release notes| |lost, then any pending | |transfers the item had will | |now be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21780 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- As this is still waiting to be pushed and now conflicts upon being applied I am attaching a rebased patch with the only change being I have changed the number of tests in t/db_dependent/Circulation.pl from 120 to 123. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 83061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83061&action=edit Bug 21754: Automatically clean up outstanding transfers on lost items This is an alternative to bug 21732 as transfers are automatically cancelled on marking an item lost, and the items holding rbanch is set to the transfers source ('from') branch. When an item is marked as lost, the routine should also clean up any outstanding transfers. Also added tests to t/db_dependent/Circulation.t which check: * If transfer is automatically deleted when item is marked as lost * If the items holdingbranch automatically changes when item with transfers on it is marked as lost. Test plan: 1. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 2. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 3. Notice that the transfer is now cancelled for the item and the items holdingbranch is the transfers source ('from') branch 4. Run t/db_dependent/Circulation.t Sponsored-by: Brimbank Library, Australia Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> (fixed the introduction of a whitespace line and removed a double declare warning from the new tests as part of QA) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I am not sure if you need to re-test, if you do then confirming the patch applies cleanly and the t/db_dependent/Circulation.t passes after applying the patch would be the only necessary things to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12362 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org