[Bug 34018] New: Patron image upload fails without cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 Bug ID: 34018 Summary: Patron image upload fails without cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org If a borrower doesn't have a cardnumber, you can't upload a patron image via the Patrons module. I realize this is because it leverages the /cgi-bin/koha/tools/picture-upload.pl tool which requires a file including cardnumbers or prompts for a cardnumber, but you should be able to use borrowernumber instead - at least via the Patron module. -- The way to do this would be to refactor tools/picture-upload.pl to use a Perl module, and then create a REST API endpoint for uploading the patron image. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I suppose there are some minor changes that could be made that could get it over the line... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34109 [Bug 34109] When adding items on receive, mandatory fields are not checked -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|34109 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34109 [Bug 34109] When adding items on receive, mandatory fields are not checked -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #1)
I suppose there are some minor changes that could be made that could get it over the line...
Actually, I don't think so. I don't know what I was thinking back in June when I wrote this comment. While http://localhost:8081/cgi-bin/koha/members/moremember.pl does pass a borrowernumber, the handle_dir and handle_file functions are hard-coded to only accept cardnumber. Any change to just use borrowernumber would need to be tested, but then ./tools/picture-upload.pl isn't currently unit tested. But to unit test it you'd need to rewrite ./tools/picture-upload.pl, so it's just going to be too much work for too little gain. The workaround here is to just use a temporary dummy cardnumber for a patron when uploading a patron image. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35344 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron image upload fails |Patron image upload |without cardnumber |silently fails without | |cardnumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I've raised bug 35344 which warns if the patron is missing the cardnumber and prevents an attempt at uploading the patron image. I think that's the most I'm going to do on this one without sponsorship. Going to change this from a bug to an enhancement... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39535 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39536 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40457 [Bug 40457] Wherever possible we should lookup using borrowernumber instead of userid/cardnumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org