[Bug 24361] New: Fix warnings (or failing tests) from bug 24217
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Bug ID: 24361 Summary: Fix warnings (or failing tests) from bug 24217 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org We added use Modern::Perl to some of our modules, we should expect warnings in logs or test failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 [Bug 24217] use strict for all modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96873&action=edit Bug 24361: Fix warning in C4::Record line 435 Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Record.pm line 435 Caught by a failing test: # Failed test 'Export csv with wrong marcxml should raise a warning' # at t/db_dependent/Exporter/Record.t line 113. # found warning: problem with :721 : :1: parser error : Start tag expected, '<' not found # found warning: Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Record.pm line 435. # expected to find warning: (?^u:.*Start tag expected.*) Test plan: Make sure the tests pass now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96892&action=edit Bug 24361: (bug 24217 follow-up) Fix several warnings in C4 modules With bug 24217 pushed, lot of warnings appears during the tests are run. Most of them are "Use of uninitialized value in " Test plan: Take a look at the output of run 1049 https://jenkins.koha-community.org/job/Koha_Master_D9/1049/consoleFull Most of the warnings from this run will be removed by this patch At least 2 are not fixed: Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 791. t/db_dependent/Items_DelItemCheck.t => see 23463 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Code is sensible and tests are improved.. passing qa for a quick push whilst we work on the final two failures. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- First two patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96969&action=edit Bug 24361: (follow-up) Fix CalcFine.t I mixed up 2 possible solutions, the "not defined" is handled by the "! defined $item->{replacementprice}" part t/db_dependent/Circulation/CalcFine.t .. 1/3 # Failed test 'Amount is calculated correctly' # at t/db_dependent/Circulation/CalcFine.t line 167. # got: '29' # expected: '6' # Looks like you failed 1 test of 2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97315&action=edit Bug 24361: Remove warning from GetAgeRestriction Use of uninitialized value $record_restrictions in uc at /kohadevbox/koha/C4/Circulation.pm line 3981 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug 24361: Remove warning from GetAgeRestriction - Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #5)
Created attachment 96969 [details] [review] Bug 24361: (follow-up) Fix CalcFine.t
I mixed up 2 possible solutions, the "not defined" is handled by the "! defined $item->{replacementprice}" part
t/db_dependent/Circulation/CalcFine.t .. 1/3 # Failed test 'Amount is calculated correctly' # at t/db_dependent/Circulation/CalcFine.t line 167. # got: '29' # expected: '6' # Looks like you failed 1 test of 2.
This has been pushed too, different title however "Bug 24361: (RM follow-up) Restore 0 handling in CalcFine" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Bug 24361 depends on bug 24217, which changed state. Bug 24217 Summary: use strict for all modules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com Resolution|--- |FIXED --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97991&action=edit Bug 24361: Silent t/db_dependent/Items.t its output is displaying tons of Use of uninitialized value $field in regexp compilation at /kohadevbox/koha/C4/Items.pm line 2106. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug 24361: Silent t/db_dependent/Items.t pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98796&action=edit Bug 24361: Silent Items/GetItemsForInventory.t It was displaying undreds of: Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Items.pm line 862. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug 24361: Silent Items/GetItemsForInventory.t Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 26046 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org