[Bug 23538] New: Email Library when New Patrons Self Register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Bug ID: 23538 Summary: Email Library when New Patrons Self Register Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Self Registration is a great feature in the OPAC. However, some libraries find it hard to manage these new registrations and would like to be alerted via email when a new patron self-registers. In the newest version of Koha, 19.05, this feature has been added for Purchase Suggestions, email library when new purchase suggestion is created. It would be great to have this same thing for Self Registration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25090 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | CC| |alexbuckley@catalyst.net.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- This is something that we've implemented locally for clients. I have other priorities at the moment, but I could look at upstreaming that code when I have a chance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi all, I've implemented functionality very similar to what is requested on this bug report in Bug 25090 Our client wanted to be able to moderate which patron self registrations got OPAC logins (i.e. a record in the borrowers table) due to wanting to restrict paid for access to online resources (for which users need a Koha OPAC login) to only those self registrations from within their organisation. With PatronSelfRegistrationVerifybyEmail syspref patrons do not get a patron record (OPAC login) until they've clicked the verification link in the email. However it gave the library no control over which self registrations got OPAC logins. The functionality in bug 25090 allows librarians to control who receives the verification email, (much the same way as: EmailPurchaseSuggestions and EmailAddressForSuggestions) if set to anything other than 'email address of registering patron' then a notice is sent to librarians listing some patron details. If the library decides that registration is valid (because the user is in the same organisation for example) they can click the verification link and a password reset link is sent to the registering patron to reset their credentials and login to the OPAC. I'd really appreciate any thoughts/feedback on bug 25090 :) Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 133050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133050&action=edit Bug 23538: Database changes Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 133051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133051&action=edit Bug 23538: Email library when new patron self-registers Test plan: 1. Apply patchset 2. Update database: - cd installer/data/mysql - sudo koha-shell <instance> - ./updatedatabase.pl 3. Restart services 4. Set email addresses in: - KohaAdminEmailAddress syspref - EmailAddressForPatronRegistrations syspref - Email address in the library branch 5. Enable PatronSelfRegistration syspref 6. Test the following use cases: 6.a. EmailPatronRegistrations syspref = 'none'. Submit OPAC registration. = OUTCOME: Confirm no OPAC_REG notice in message_queue table 6.b. EmailPatronRegistrations syspref = 'email address of branch'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address of branch address 6.c. EmailPatronRegistrations syspref = 'EmailAddressForPatronRegistrations'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling EmailAddressForPatronRegistrations syspref 6.d. EmailPatronRegistrations syspref = 'KohaAdminEmailAddress'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling KohaAdminEmaiLAddress syspref 7. Enable PatronSelfRegistrationVerifyByEmail syspref 8. Repeat steps 6.a, 6.b, 6.c, 6.d but this time confirm the expected outcomes only happen AFTER you have clicked the verification link in the OPAC_REG_VERIFY notice Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 133052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133052&action=edit Bug 23538: Unit tests Test plan: 1. Run unit tests: sudo koha-shell <instance> cd t/db_dependent/Koha prove -v Patron.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 133053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133053&action=edit Bug 23538: (follow-up) Fix up notices - Add toolkit template syntax to notices - Add translated notice Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133053|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 133097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133097&action=edit Bug 23538: (follow-up) Fix up notices - Add toolkit template (TT) syntax to notices - Add TT conditionals to notices - Add translated notice Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133097|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133052|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133051|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 133098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133098&action=edit Bug 23538: Email library when new patron self-registers Test plan: 1. Apply patchset 2. Update database: - cd installer/data/mysql - sudo koha-shell <instance> - ./updatedatabase.pl 3. Restart services 4. Set email addresses in: - KohaAdminEmailAddress syspref - EmailAddressForPatronRegistrations syspref - Email address in the library branch 5. Enable PatronSelfRegistration syspref 6. Test the following use cases: 6.a. EmailPatronRegistrations syspref = 'none'. Submit OPAC registration. = OUTCOME: Confirm no OPAC_REG notice in message_queue table 6.b. EmailPatronRegistrations syspref = 'email address of branch'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address of branch address 6.c. EmailPatronRegistrations syspref = 'EmailAddressForPatronRegistrations'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling EmailAddressForPatronRegistrations syspref 6.d. EmailPatronRegistrations syspref = 'KohaAdminEmailAddress'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling KohaAdminEmaiLAddress syspref 7. Enable PatronSelfRegistrationVerifyByEmail syspref 8. Repeat steps 6.a, 6.b, 6.c, 6.d but this time confirm the expected outcomes only happen AFTER you have clicked the verification link in the OPAC_REG_VERIFY notice Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 133099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133099&action=edit Bug 23538: Unit tests Test plan: 1. Run unit tests: sudo koha-shell <instance> cd t/db_dependent/Koha prove -v Patron.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 133100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133100&action=edit Bug 23538: (follow-up) Fix up notices - Add toolkit template (TT) syntax to notices - Add TT conditionals to notices - Add translated notice Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133100|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133099|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133098|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 133101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133101&action=edit Bug 23538: Email library when new patron self-registers Test plan: 1. Apply patchset 2. Update database: - cd installer/data/mysql - sudo koha-shell <instance> - ./updatedatabase.pl 3. Restart services 4. Set email addresses in: - KohaAdminEmailAddress syspref - EmailAddressForPatronRegistrations syspref - Email address in the library branch 5. Enable PatronSelfRegistration syspref 6. Test the following use cases: 6.a. EmailPatronRegistrations syspref = 'none'. Submit OPAC registration. = OUTCOME: Confirm no OPAC_REG notice in message_queue table 6.b. EmailPatronRegistrations syspref = 'email address of branch'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address of branch address 6.c. EmailPatronRegistrations syspref = 'EmailAddressForPatronRegistrations'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling EmailAddressForPatronRegistrations syspref 6.d. EmailPatronRegistrations syspref = 'KohaAdminEmailAddress'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling KohaAdminEmaiLAddress syspref 7. Enable PatronSelfRegistrationVerifyByEmail syspref 8. Repeat steps 6.a, 6.b, 6.c, 6.d but this time confirm the expected outcomes only happen AFTER you have clicked the verification link in the OPAC_REG_VERIFY notice Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 133102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133102&action=edit Bug 23538: Unit tests Test plan: 1. Run unit tests: sudo koha-shell <instance> cd t/db_dependent/Koha prove -v Patron.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 133103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133103&action=edit Bug 23538: (follow-up) Fix up notices - Add toolkit template (TT) syntax to notices - Add TT conditionals to notices - Add translated notice Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Change sponsored?|--- |Sponsored --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I linked bug 25090 in comment #2 but I think that will need me to do some re-work to get it working better. So what I've done now is write this patchset, so librarians can at least choose if they are notified when a new patron self-registers. This is similar functionality to emails sent to the library when an OPAC purchase suggestion is made. Ready to test! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Hi Alex, it looks like there is a small conflict in sample_notices.yml in current master. Can this be rebased? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133050|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #16 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 137997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137997&action=edit Bug 23538: Database changes Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #17 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 137998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137998&action=edit Bug 23538: Email library when new patron self-registers Test plan: 1. Apply all patches 2. Update database 3. Restart services 4. Set email addresses in: - KohaAdminEmailAddress syspref - EmailAddressForPatronRegistrations syspref - Email address in the library branch 5. Enable PatronSelfRegistration syspref 6. Test the following use cases: - EmailPatronRegistrations syspref = 'none'. Submit OPAC registration. = OUTCOME: Confirm no OPAC_REG notice in message_queue table --- - EmailPatronRegistrations syspref = 'email address of branch'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling the branch address --- - EmailPatronRegistrations syspref = 'EmailAddressForPatronRegistrations'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling EmailAddressForPatronRegistrations syspref --- - EmailPatronRegistrations syspref = 'KohaAdminEmailAddress'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling KohaAdminEmailAddress syspref 7. Enable PatronSelfRegistrationVerifyByEmail syspref 8. Repeat testing all use cases. Confirm this time the expected outcomes only happen AFTER you have clicked the verification link in the OPAC_REG_VERIFY notice Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133102|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133103|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #18 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 137999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137999&action=edit Bug 23538: Email library when new patron self-registers Test plan: 1. Apply all patches 2. Update database 3. Restart services 4. Set email addresses in: - KohaAdminEmailAddress syspref - EmailAddressForPatronRegistrations syspref - Email address in the library branch 5. Enable PatronSelfRegistration syspref 6. Test the following use cases: - EmailPatronRegistrations syspref = 'none'. Submit OPAC registration. = OUTCOME: Confirm no OPAC_REG notice in message_queue table --- - EmailPatronRegistrations syspref = 'email address of branch'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling the branch address --- - EmailPatronRegistrations syspref = 'EmailAddressForPatronRegistrations'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling EmailAddressForPatronRegistrations syspref --- - EmailPatronRegistrations syspref = 'KohaAdminEmailAddress'. Submit OPAC registration. = OUTCOME: Confirm OPAC_REG notice in message_queue with to_address equalling KohaAdminEmailAddress syspref 7. Enable PatronSelfRegistrationVerifyByEmail syspref 8. Repeat testing all use cases. Confirm this time the expected outcomes only happen AFTER you have clicked the verification link in the OPAC_REG_VERIFY notice Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #19 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 138000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138000&action=edit Bug 23538: Unit tests Test plan: 1. Run unit tests: sudo koha-shell <instance> cd t/db_dependent/Koha prove -v Patron.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #20 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 138001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138001&action=edit Bug 23538: (follow-up) Fix up notices - Add toolkit template (TT) syntax to notices - Add TT conditionals to notices - Add translated notice Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #21 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Lucas, Apologies for the delay rebasing. This is now rebased and is ready for testing again. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137997|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 138237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138237&action=edit Bug 23538: Database changes Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137999|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 138238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138238&action=edit Bug 23538: Email library when new patron self-registers Test plan: 1. Apply all patches 2. Update database 3. Restart services 4. Set email addresses in: - KohaAdminEmailAddress syspref - EmailAddressForPatronRegistrations syspref - Email address in the library branch 5. Enable PatronSelfRegistration syspref 6. Test the following use cases: - EmailPatronRegistrations syspref = 'none'. Submit OPAC registration. = OUTCOME: Confirm no OPAC_REG notice in message_queue table Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138000|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 138239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138239&action=edit Bug 23538: Unit tests Test plan: 1. Run unit tests: sudo koha-shell <instance> cd t/db_dependent/Koha prove -v Patron.t Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138001|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 138240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138240&action=edit Bug 23538: (follow-up) Fix up notices - Add toolkit template (TT) syntax to notices - Add TT conditionals to notices - Add translated notice Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows release notes| |libraries to receive | |notifications when patrons | |self-register. | | | |This is | |enabled using the new | |system preference | |EmailPatronRegistrations | |(options are: none, email | |address of branch, | |EmailAddressForPatronRegist | |rations, and | |KohaAdminEmailAddress) and | |a new notice (OPAC_REG). | | | |To use a specific email | |address for notifications, | |use the new system | |preference | |EmailAddressForPatronRegist | |rations. | | | |If verification | |is required for | |self-registrations (when | |PatronSelfRegistrationVerif | |yByEmail is enabled), then | |notifications are only sent | |to the library once the | |registration is confirmed. CC| |david@davidnind.com --- Comment #26 from David Nind <david@davidnind.com> --- Not sure what happened to the test plan for the 'Email library when new patron self-registers' patch after I signed it off - step 6 and onwards are cut off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #27 from David Nind <david@davidnind.com> --- Minor suggested changes to the new EmailPatronRegistrations system preference wording: - Revised wording for the first sentence: Choose the email address that new patron self-registration notifications are sent to: [options]. - Option - 'email address of branch': I think the terminology guidelines are to use library instead of branch. - Remove the : at the end of the last sentence and replace with a full stop. I've also suggested some revised wording. ==> Choose the email address that new patron self-registration notifications are sent to: [options]. A valid email address is required for EmailAddressForPatronRegistrations if that option is selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Email Library when New |Email library when new |Patrons Self Register |patrons self register QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138237|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138383&action=edit Bug 23538: Database changes Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138238|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138384&action=edit Bug 23538: Email library when new patron self-registers Test plan: 1. Apply all patches 2. Update database 3. Restart services 4. Set email addresses in: - KohaAdminEmailAddress syspref - EmailAddressForPatronRegistrations syspref - Email address in the library branch 5. Enable PatronSelfRegistration syspref 6. Test the following use cases: - EmailPatronRegistrations syspref = 'none'. Submit OPAC registration. = OUTCOME: Confirm no OPAC_REG notice in message_queue table Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138239|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138385&action=edit Bug 23538: Unit tests Test plan: 1. Run unit tests: sudo koha-shell <instance> cd t/db_dependent/Koha prove -v Patron.t Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138240|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138386&action=edit Bug 23538: (follow-up) Fix up notices - Add toolkit template (TT) syntax to notices - Add TT conditionals to notices Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138387&action=edit Bug 23538: (QA follow-up) Group system preferences into one entry This makes the new perferences EmailPatronRegistrations and EmailAddressForPatronRegistrations follow a little more closely the pattern set by the very similar EmailPurchaseSuggestions and EmailAddressforSuggestions. * Group both preferences into one entry * Add line break between preferences * Switch branch for library in pull down Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Very happy to see inbound_email_address and ReplyToDefault used here! installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql is no longer necessary. I have amended David's patch removing the file and adjusting the commit message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows |This enhancement allows release notes|libraries to receive |libraries to receive |notifications when patrons |notifications when patrons |self-register. |self-register. | | |This is |This is |enabled using the new |enabled using the new |system preference |system preference |EmailPatronRegistrations |EmailPatronRegistrations |(options are: none, email |(options are: none, email |address of branch, |address of library, |EmailAddressForPatronRegist |EmailAddressForPatronRegist |rations, and |rations, and |KohaAdminEmailAddress) and |KohaAdminEmailAddress) and |a new notice (OPAC_REG). |a new notice (OPAC_REG). | | |To use a specific email |To use a specific email |address for notifications, |address for notifications, |use the new system |use the new system |preference |preference |EmailAddressForPatronRegist |EmailAddressForPatronRegist |rations. |rations. | | |If verification |If verification |is required for |is required for |self-registrations (when |self-registrations (when |PatronSelfRegistrationVerif |PatronSelfRegistrationVerif |yByEmail is enabled), then |yByEmail is enabled), then |notifications are only sent |notifications are only sent |to the library once the |to the library once the |registration is confirmed. |registration is confirmed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #34 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thanks very much for testing and feedback David and Katrin! Great to see this Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + t::lib::Mocks::mock_preference( 'KohaAdminEmailAddress', 'root@localhost' ); + t::lib::Mocks::mock_preference( 'EmailAddressForPatronRegistrations', 'library@localhost' ); + + # Test when EmailPatronRegistrations equals BranchEmailAddress + t::lib::Mocks::mock_preference( 'EmailPatronRegistrations', 'BranchEmailAddress' ); + is( $patron->notify_library_of_registration(C4::Context->preference('EmailPatronRegistrations')), 1, 'OPAC_REG email is queued if EmailPatronRegistration syspref equals BranchEmailAddress'); + my $sth = $dbh->prepare("SELECT to_address FROM message_queue where borrowernumber = ?"); + $sth->execute( $patron->borrowernumber ); + my $to_address = $sth->fetchrow_array; + is( $to_address, 'to@mybranch.com', 'OPAC_REG email queued to go to branchreplyto address when EmailPatronRegistration equals BranchEmailAddress' ); + $dbh->do(q|DELETE FROM message_queue|); + + # Test when EmailPatronRegistrations equals EmailAddressForPatronRegistrations + t::lib::Mocks::mock_preference( 'EmailPatronRegistrations', 'EmailAddressForPatronRegistrations' ); + is( $patron->notify_library_of_registration(C4::Context->preference('EmailPatronRegistrations')), 1, 'OPAC_REG email is queued if EmailPatronRegistration syspref equals EmailAddressForPatronRegistrations'); + $sth->execute( $patron->borrowernumber ); + $to_address = $sth->fetchrow_array; + is( $to_address, 'library@localhost', 'OPAC_REG email queued to go to EmailAddressForPatronRegistrations syspref when EmailPatronRegistration equals EmailAddressForPatronRegistrations' ); + $dbh->do(q|DELETE FROM message_queue|); + + # Test when EmailPatronRegistrations equals KohaAdminEmailAddress + t::lib::Mocks::mock_preference( 'EmailPatronRegistrations', 'KohaAdminEmailAddress' ); + is( $patron->notify_library_of_registration(C4::Context->preference('EmailPatronRegistrations')), 1, 'OPAC_REG email is queued if EmailPatronRegistration syspref equals KohaAdminEmailAddress'); + $sth->execute( $patron->borrowernumber ); + $to_address = $sth->fetchrow_array; + is( $to_address, 'root@localhost', 'OPAC_REG email queued to go to KohaAdminEmailAddress syspref when EmailPatronRegistration equals KohaAdminEmailAddress' ); + $dbh->do(q|DELETE FROM message_queue|); This part of the test fails with me: not ok 6 - OPAC_REG email queued to go to KohaAdminEmailAddress syspref when EmailPatronRegistration equals KohaAdminEmailAddress # Failed test 'OPAC_REG email queued to go to KohaAdminEmailAddress syspref when EmailPatronRegistration equals KohaAdminEmailAddress' # at t/db_dependent/Koha/Patron.t line 1347. # got: 'bibliotheek@master.rijkskoha.nl' # expected: 'root@localhost' # Looks like you failed 1 test of 6. Also note that you'd better not use localhost as an email address in your tests. And that you include several SQL statements that should be Koha objects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Koha::Patron elsif ( $email_patron_registrations eq "KohaAdminEmailAddress" ) { $to_address = C4::Context->preference('ReplytoDefault') || C4::Context->preference('KohaAdminEmailAddress'); } This is the cause of the failing test. Why do you use ReplytoDefault here. The value of the pref says KohaAdmin. This is quite confusing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141223&action=edit Bug 23538: (follow-up) Workaround to fix Patron.t See comment36 and comment37. This needs more attention but serves as a quick fix only. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Tomas: Last patch only please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)|22.11.00 |22.11.00,22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,22.11.00 |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #39)
Tomas: Last patch only please.
Thank you, Marcel. Good job! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #42 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Aude Charillon contact| | CC| |aude.charillon@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/635 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #43 from Aude Charillon <aude.charillon@ptfs-europe.com> --- Added to manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org