https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90766&action=edit Bug 23152: Implement koha_object[s]_class when needed A simple use case is the ->get_from_storage (useful when writing tests) Test plan: Apply only the first patch and notice the test failures Apply the second patch and confirm the the tests are returning green -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90765|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 90803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90803&action=edit Bug 23152: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a bit of a no-brainer and something I've been meaning to get around to doing myself for a while. Going straight for PQA as the patch is trivial to read and the qa scripts don't complain. The test currently fails, but the reason is clear and it just warrants an RM followup on push to bring it up to date with the available classes at the time of push. Passing QA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #5)

This is a bit of a no-brainer

I wrote a script ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I missed that the tests here don't actually test the koha_objects_class at all here.. would be good to get a test for that method too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed the last follow-up.. oops.. i missed this one for ages :S -- You are receiving this mail because: You are watching all bug changes.