http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10289, 8367 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19110&action=edit Bug 10487: UT: GetMaxPickupDate needs unit tests GetMaxPickupDate is introduced by bug 8367. It needs unit tests. $ prove t/db_dependent/Reserves.t should produce: t/db_dependent/Reserves.t .. 1/14 # # Creating biblio instance for testing. # Creating item instance for testing. ERROR: GetMaxPickupDate is called without reserve and without itemnumber ERROR: GetMaxPickupDate is called without reserve and without itemnumber t/db_dependent/Reserves.t .. 11/14 # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=14, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.06 csys = 0.51 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19110|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19183&action=edit Bug 10487: UT: GetMaxPickupDate needs unit tests GetMaxPickupDate is introduced by bug 8367. It needs unit tests. $ prove t/db_dependent/Reserves.t should produce: t/db_dependent/Reserves.t .. 1/14 # # Creating biblio instance for testing. # Creating item instance for testing. ERROR: GetMaxPickupDate is called without reserve and without itemnumber ERROR: GetMaxPickupDate is called without reserve and without itemnumber t/db_dependent/Reserves.t .. 11/14 # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=14, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.06 csys = 0.51 CPU) Result: PASS Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Signed Off |Patch doesn't apply --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Conflicts now -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19183|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20339&action=edit Bug 10487: UT: GetMaxPickupDate needs unit tests GetMaxPickupDate is introduced by bug 8367. It needs unit tests. $ prove t/db_dependent/Reserves.t should produce: t/db_dependent/Reserves.t .. 1/14 # # Creating biblio instance for testing. # Creating item instance for testing. ERROR: GetMaxPickupDate is called without reserve and without itemnumber ERROR: GetMaxPickupDate is called without reserve and without itemnumber t/db_dependent/Reserves.t .. 11/14 # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=14, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.06 csys = 0.51 CPU) Result: PASS Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.