[Bug 23944] New: Phase out use of jquery.cookie.js in favor of js.cookie.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Bug ID: 23944 Summary: Phase out use of jquery.cookie.js in favor of js.cookie.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The jQuery plugin we use for setting cookies is obsolete: https://github.com/carhartl/jquery-cookie -- "No longer maintained, superseded by JS Cookie: https://github.com/js-cookie/js-cookie" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94951&action=edit Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js This patch adds a new JavaScript file to the staff client's global JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will replace jquery.cookie.js which is no longer maintained. The "About" page in the staff client is updated to include this new resource as well as adding previously-missing information about the old plugin which will remain until all instances of its usage have been removed. To test, apply the patch and check the About page to confirm the correct information is included. No functionality change is introduced by this bug. The only other observable change is the existence of the new files and the inclusion of the minified version of the file in any staff client page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94953&action=edit Bug 23944: (follow-up) Update circulation to use new library This patch updates the circulation page to use the new JavaScript Cookie library for cookie management. To test, apply the patch and open a patron record for checkout in the staff client. - Click "Search to hold" in the toolbar and perform a catalog search which will return results. - On the search results page, the toolbar at the top of the results should include a split "Place hold" button. The button's menu should include "Place hold for <patron>" and "Forget <patron>" options. Test that these work correctly. - In the table of search results each title should include a "Place hold for <patron>" link. - Go to the checkouts page for a patron with one or more checked-out items. - Check the "Always show checkouts immediately" checkbox. - The patron's checkouts should load. - Open another patron for checkout who has checked-out items. - The table of checkouts should load automatically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947 [Bug 23947] Phase out jquery.cookie.js: Authority merge -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94951|0 |1 is obsolete| | Attachment #94953|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96826&action=edit Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js This patch adds a new JavaScript file to the staff client's global JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will replace jquery.cookie.js which is no longer maintained. The "About" page in the staff client is updated to include this new resource as well as adding previously-missing information about the old plugin which will remain until all instances of its usage have been removed. To test, apply the patch and check the About page to confirm the correct information is included. No functionality change is introduced by this bug. The only other observable change is the existence of the new files and the inclusion of the minified version of the file in any staff client page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96827&action=edit Bug 23944: (follow-up) Update circulation to use new library This patch updates the circulation page to use the new JavaScript Cookie library for cookie management. To test, apply the patch and open a patron record for checkout in the staff client. - Click "Search to hold" in the toolbar and perform a catalog search which will return results. - On the search results page, the toolbar at the top of the results should include a split "Place hold" button. The button's menu should include "Place hold for <patron>" and "Forget <patron>" options. Test that these work correctly. - In the table of search results each title should include a "Place hold for <patron>" link. - Go to the checkouts page for a patron with one or more checked-out items. - Check the "Always show checkouts immediately" checkbox. - The patron's checkouts should load. - Open another patron for checkout who has checked-out items. - The table of checkouts should load automatically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24347 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 [Bug 24347] Add a 'search to order' option similar to 'search to hold' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96826|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 97937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97937&action=edit Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js This patch adds a new JavaScript file to the staff client's global JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will replace jquery.cookie.js which is no longer maintained. The "About" page in the staff client is updated to include this new resource as well as adding previously-missing information about the old plugin which will remain until all instances of its usage have been removed. To test, apply the patch and check the About page to confirm the correct information is included. No functionality change is introduced by this bug. The only other observable change is the existence of the new files and the inclusion of the minified version of the file in any staff client page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96827|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 97938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97938&action=edit Bug 23944: (follow-up) Update circulation to use new library This patch updates the circulation page to use the new JavaScript Cookie library for cookie management. To test, apply the patch and open a patron record for checkout in the staff client. - Click "Search to hold" in the toolbar and perform a catalog search which will return results. - On the search results page, the toolbar at the top of the results should include a split "Place hold" button. The button's menu should include "Place hold for <patron>" and "Forget <patron>" options. Test that these work correctly. - In the table of search results each title should include a "Place hold for <patron>" link. - Go to the checkouts page for a patron with one or more checked-out items. - Check the "Always show checkouts immediately" checkbox. - The patron's checkouts should load. - Open another patron for checkout who has checked-out items. - The table of checkouts should load automatically. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I had to delete my old issues-table-load-immediately-circulation cookies first to get this to work, but now it does :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97937|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98050&action=edit Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js This patch adds a new JavaScript file to the staff client's global JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will replace jquery.cookie.js which is no longer maintained. The "About" page in the staff client is updated to include this new resource as well as adding previously-missing information about the old plugin which will remain until all instances of its usage have been removed. To test, apply the patch and check the About page to confirm the correct information is included. No functionality change is introduced by this bug. The only other observable change is the existence of the new files and the inclusion of the minified version of the file in any staff client page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97938|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98051&action=edit Bug 23944: (follow-up) Update circulation to use new library This patch updates the circulation page to use the new JavaScript Cookie library for cookie management. To test, apply the patch and open a patron record for checkout in the staff client. - Click "Search to hold" in the toolbar and perform a catalog search which will return results. - On the search results page, the toolbar at the top of the results should include a split "Place hold" button. The button's menu should include "Place hold for <patron>" and "Forget <patron>" options. Test that these work correctly. - In the table of search results each title should include a "Place hold for <patron>" link. - Go to the checkouts page for a patron with one or more checked-out items. - Check the "Always show checkouts immediately" checkbox. - The patron's checkouts should load. - Open another patron for checkout who has checked-out items. - The table of checkouts should load automatically. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24619 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 [Bug 24621] Phase out jquery.cookie.js: Basic MARC editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24623 [Bug 24623] Phase out jquery.cookie.js: Advanced MARC editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 [Bug 24624] Phase out jquery.cookie.js: Receipt summary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24625 [Bug 24625] Phase out jquery.cookie.js: showLastPatron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy@bywatersolutions.com --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- choosing to backport this enhancement into 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #13 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Enhancement will not be backported to 18.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24625 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24625 [Bug 24625] Phase out jquery.cookie.js: showLastPatron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27749 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 [Bug 27749] Phase out jquery.cookie.js: Search to hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750 [Bug 27750] Remove jquery.cookie.js plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27751 [Bug 27751] Phase out jquery.cookie.js: Batch item modifications -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29933 [Bug 29933] Fix stray usage of jquery.cookie.js plugin -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org