[Bug 37873] New: Unable to delete user from routing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Bug ID: 37873 Summary: Unable to delete user from routing list Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: Chip.Halvorsen@WestlakeLibrary.org QA Contact: testopia@bugs.koha-community.org We are unable to remove users from serials routing lists after the 24.05 upgrade. Clicking the delete button does nothing. Possibly related to CSRF changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org, | |cj.lynce@westlakelibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main Status|NEW |ASSIGNED Summary|Unable to delete user from |Unable to delete user from |routing list |routing list or | |preview/print routing list | |slip Assignee|koha-bugs@lists.koha-commun |cj.lynce@westlakelibrary.or |ity.org |g --- Comment #1 from CJ Lynce <cj.lynce@westlakelibrary.org> --- I verified this is present on main as well. While troubleshooting, I also found that the "Save and preview slip" button was not previewing the slip. Also, using the "Print list" button from the Serial collection information screen was display the standard staff interface headers when trying to print the slip. I will have a patch up for this later today. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 --- Comment #2 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 171278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171278&action=edit Bug 37873: Unable to delete user from routing list or preview/print routing list slip This patch restores the ability to delete a recipient from a serials routing list. It also fixes the slip preview when using the "Save and preview slip", and removes the koha staff intranet head from the slip when using 'Print list' from the Serial collection information screen. To test: 1) Login to the staff client. 2) Open the Serials module. 3) + New subscription to add a new serial. 4) Create a new subscription. a) Search for a record (I searched for 'dog') and chose that record. b) Under 'When receiving this serial', select 'Create an item record' c) Under the 'Item type' dropdown, select anything. d) Click Next -> (and confirm the popup). e) Select any 'First issue date'. f) Select any 'Frequency'. g) Enter a number larger than 5 in the 'Subscription length'. h) Select any 'Subscription start date'. i) Select your favorite numbering pattern. j) Verify your prediction pattern using "Test prediction pattern". k) Click "Save subscription". 5) On the 'Subscription details' screen, click "Receive". 6) Under the first volume, click "Add item" then "Save". 7) Repeat step 6 to receive one more issue. 8) On the 'Serial collection information' page click "+ Create routing list" 9) Click "+ Add recipients". 10) Search for and add several recipients. 11) Click "Close" to exit the 'Add recipients' page. 12) Click "Delete" next to any recipient. *Note that the recipient is not deleted. 13) Click "Save" on the 'Modify routing list for ...' page. 14) Click "Save and preview routing slip" button. *Note you are redirected to the Subscription details page, but no routing slip preview appears. 15) Click "Serial collection" from the left-side menu. 16) Click "Print list" on either of the issues you previously received. *Note the routing slip includes the staff intranet header, menu, etc. 17) Apply patch. 18) Return to the 'Serial collection information' screen for your subscription. 19) Click "Edit routing list". 20) Repeat steps 12-16 and verify the issues are fixed. -"Delete" button works to remove a recipient from a list. -"Save and preview routing list" button pops-up a preview before redirecting. -"Print list" pops-up a vanilla routing list to print. Sponsored-by: Westlake Porter Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Fixes a regression that release notes| |prevented recipients from | |being deleted from a | |routing list, as well as | |resolving issues with | |previewing routing lists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171278|0 |1 is obsolete| | --- Comment #3 from Olivier V <ovezina@inlibro.com> --- Created attachment 171292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171292&action=edit Bug 37873: Unable to delete user from routing list or preview/print routing list slip This patch restores the ability to delete a recipient from a serials routing list. It also fixes the slip preview when using the "Save and preview slip", and removes the koha staff intranet head from the slip when using 'Print list' from the Serial collection information screen. To test: 1) Login to the staff client. 2) Open the Serials module. 3) + New subscription to add a new serial. 4) Create a new subscription. a) Search for a record (I searched for 'dog') and chose that record. b) Under 'When receiving this serial', select 'Create an item record' c) Under the 'Item type' dropdown, select anything. d) Click Next -> (and confirm the popup). e) Select any 'First issue date'. f) Select any 'Frequency'. g) Enter a number larger than 5 in the 'Subscription length'. h) Select any 'Subscription start date'. i) Select your favorite numbering pattern. j) Verify your prediction pattern using "Test prediction pattern". k) Click "Save subscription". 5) On the 'Subscription details' screen, click "Receive". 6) Under the first volume, click "Add item" then "Save". 7) Repeat step 6 to receive one more issue. 8) On the 'Serial collection information' page click "+ Create routing list" 9) Click "+ Add recipients". 10) Search for and add several recipients. 11) Click "Close" to exit the 'Add recipients' page. 12) Click "Delete" next to any recipient. *Note that the recipient is not deleted. 13) Click "Save" on the 'Modify routing list for ...' page. 14) Click "Save and preview routing slip" button. *Note you are redirected to the Subscription details page, but no routing slip preview appears. 15) Click "Serial collection" from the left-side menu. 16) Click "Print list" on either of the issues you previously received. *Note the routing slip includes the staff intranet header, menu, etc. 17) Apply patch. 18) Return to the 'Serial collection information' screen for your subscription. 19) Click "Edit routing list". 20) Repeat steps 12-16 and verify the issues are fixed. -"Delete" button works to remove a recipient from a list. -"Save and preview routing list" button pops-up a preview before redirecting. -"Print list" pops-up a vanilla routing list to print. Sponsored-by: Westlake Porter Public Library Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |ovezina@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171292|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171446&action=edit Bug 37873: Unable to delete user from routing list or preview/print routing list slip This patch restores the ability to delete a recipient from a serials routing list. It also fixes the slip preview when using the "Save and preview slip", and removes the koha staff intranet head from the slip when using 'Print list' from the Serial collection information screen. To test: 1) Login to the staff client. 2) Open the Serials module. 3) + New subscription to add a new serial. 4) Create a new subscription. a) Search for a record (I searched for 'dog') and chose that record. b) Under 'When receiving this serial', select 'Create an item record' c) Under the 'Item type' dropdown, select anything. d) Click Next -> (and confirm the popup). e) Select any 'First issue date'. f) Select any 'Frequency'. g) Enter a number larger than 5 in the 'Subscription length'. h) Select any 'Subscription start date'. i) Select your favorite numbering pattern. j) Verify your prediction pattern using "Test prediction pattern". k) Click "Save subscription". 5) On the 'Subscription details' screen, click "Receive". 6) Under the first volume, click "Add item" then "Save". 7) Repeat step 6 to receive one more issue. 8) On the 'Serial collection information' page click "+ Create routing list" 9) Click "+ Add recipients". 10) Search for and add several recipients. 11) Click "Close" to exit the 'Add recipients' page. 12) Click "Delete" next to any recipient. *Note that the recipient is not deleted. 13) Click "Save" on the 'Modify routing list for ...' page. 14) Click "Save and preview routing slip" button. *Note you are redirected to the Subscription details page, but no routing slip preview appears. 15) Click "Serial collection" from the left-side menu. 16) Click "Print list" on either of the issues you previously received. *Note the routing slip includes the staff intranet header, menu, etc. 17) Apply patch. 18) Return to the 'Serial collection information' screen for your subscription. 19) Click "Edit routing list". 20) Repeat steps 12-16 and verify the issues are fixed. -"Delete" button works to remove a recipient from a list. -"Save and preview routing list" button pops-up a preview before redirecting. -"Print list" pops-up a vanilla routing list to print. Sponsored-by: Westlake Porter Public Library Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the fix here.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 24.05.x, please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 --- Comment #8 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 171944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171944&action=edit Bug 37873: [24.05.x] Unable to delete user from routing list or preview/print routing list slip This patch restores the ability to delete a recipient from a serials routing list. It also fixes the slip preview when using the "Save and preview slip", and removes the koha staff intranet head from the slip when using 'Print list' from the Serial collection information screen. To test: 1) Login to the staff client. 2) Open the Serials module. 3) + New subscription to add a new serial. 4) Create a new subscription. a) Search for a record (I searched for 'dog') and chose that record. b) Under 'When receiving this serial', select 'Create an item record' c) Under the 'Item type' dropdown, select anything. d) Click Next -> (and confirm the popup). e) Select any 'First issue date'. f) Select any 'Frequency'. g) Enter a number larger than 5 in the 'Subscription length'. h) Select any 'Subscription start date'. i) Select your favorite numbering pattern. j) Verify your prediction pattern using "Test prediction pattern". k) Click "Save subscription". 5) On the 'Subscription details' screen, click "Receive". 6) Under the first volume, click "Add item" then "Save". 7) Repeat step 6 to receive one more issue. 8) On the 'Serial collection information' page click "+ Create routing list" 9) Click "+ Add recipients". 10) Search for and add several recipients. 11) Click "Close" to exit the 'Add recipients' page. 12) Click "Delete" next to any recipient. *Note that the recipient is not deleted. 13) Click "Save" on the 'Modify routing list for ...' page. 14) Click "Save and preview routing slip" button. *Note you are redirected to the Subscription details page, but no routing slip preview appears. 15) Click "Serial collection" from the left-side menu. 16) Click "Print list" on either of the issues you previously received. *Note the routing slip includes the staff intranet header, menu, etc. 17) Apply patch. 18) Return to the 'Serial collection information' screen for your subscription. 19) Click "Edit routing list". 20) Repeat steps 12-16 and verify the issues are fixed. -"Delete" button works to remove a recipient from a list. -"Save and preview routing list" button pops-up a preview before redirecting. -"Print list" pops-up a vanilla routing list to print. Sponsored-by: Westlake Porter Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 --- Comment #9 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Rebased for 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | Version(s)|24.11.00 |24.11.00,24.05.04 released in| | Status|Pushed to main |Pushed to stable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks CJ! Backported to 24.05. for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- CUD not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #12 from David Nind <david@davidnind.com> --- Bug fix, no change to UI, no changes required to the documentation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37873 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org