[Bug 16073] New: Circulation is completely broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Bug ID: 16073 Summary: Circulation is completely broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: blocker Priority: P5 - low Component: Circulation Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 15656 To reproduce, just go to circ/circulation.pl: Can't call method "guarantor" on an undefined value at /home/koha/src/circ/circulation.pl line 588. at /home/koha/src/circ/circulation.pl line 673 Introduced by bug 15656 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 [Bug 15656] Move the guarantor/guarantees code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49147&action=edit Bug 16073: Fix software error in circulation.pl Can't call method "guarantor" on an undefined value at /home/koha/src/circ/circulation.pl line 588. at /home/koha/src/circ/circulation.pl line 673 Introduced by bug 15656 Test plan: Just trigger circ/circulation.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49147|0 |1 is obsolete| | --- Comment #2 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 49163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49163&action=edit Bug 16073: Fix software error in circulation.pl Can't call method "guarantor" on an undefined value at /home/koha/src/circ/circulation.pl line 588. at /home/koha/src/circ/circulation.pl line 673 Introduced by bug 15656 Test plan: Just trigger circ/circulation.pl Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Triggered circ/circulation.pl - nothing exploded, and error is gone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49203&action=edit Bug 16073: (follow-up) Fix software error in circulation.pl Do not crash if the patron does not exist. Test plan: Access circ/circulation.pl?borrowernumber=42424242 you should get an error without this patch With this patch, you will get an empty patron detail page (should be fixed in another patch, but this behavior exists for a while) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 [Bug 16082] Empty patron detail page is displayed if the patron does not exist - circulation.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49163|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49273&action=edit Bug 16073: Fix software error in circulation.pl Can't call method "guarantor" on an undefined value at /home/koha/src/circ/circulation.pl line 588. at /home/koha/src/circ/circulation.pl line 673 Introduced by bug 15656 Test plan: Just trigger circ/circulation.pl Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Triggered circ/circulation.pl - nothing exploded, and error is gone Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49203|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49274&action=edit Bug 16073: (follow-up) Fix software error in circulation.pl Do not crash if the patron does not exist. Test plan: Access circ/circulation.pl?borrowernumber=42424242 you should get an error without this patch With this patch, you will get an empty patron detail page (should be fixed in another patch, but this behavior exists for a while) Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |tomascohen@gmail.com Status|Signed Off |Passed QA --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Simple patches that fix the issue. They pass the QA scripts and have really bad commit messages :-P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Does not concern stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org