[Bug 8659] New: Inactive funds in neworderempty not disabled in IE/Opera
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Priority: P5 - low Change sponsored?: --- Bug ID: 8659 Assignee: koha-bugs@lists.koha-community.org Summary: Inactive funds in neworderempty not disabled in IE/Opera Severity: enhancement Classification: Unclassified OS: All Reporter: pelletiermaxime@gmail.com Hardware: All Status: ASSIGNED Version: master Component: Acquisitions Product: Koha It seems that you can't use display:none for <options> in IE. Patch to follow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 --- Comment #1 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Created attachment 11714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11714&action=edit proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 --- Comment #2 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Just a note that this was based on 3.8.2. Let me know if it doesn't appy in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|koha-bugs@lists.koha-commun |pelletiermaxime@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Severity|enhancement |normal --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- The patch appears to have applied fine, but the "show all" checkbox isn't doing anything in Firefox or Internet Explorer 9. After checking it I see the same options as before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 --- Comment #4 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Are you sure you have an inactive budget with funds ? Do you have any javascript errors or anything ? I tested successfully in ie8, firefox, chrome, chromium and opera. The way we use funds is we create a copy every year for new budgets. The problem is that we now have 50 funds that are in triple because we have the 10-11, 11-12 and 12-13 version of the fund with the same name. That why this problem is really critical for us. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I just tested again with the same results. I know I have an inactive budget with funds because before applying the patch I can see the effect of the "show all" checkbox: some funds are hidden and shown when changing the checkbox. I don't see any JS errors in Firebug. Results are the same in Firefox 14, Chrome 21, Opera 12, and IE 9, all on Windows 7: Only active funds are shown, and checking the box to show all has no effect. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11714|0 |1 is obsolete| | --- Comment #6 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Created attachment 11730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11730&action=edit new better patch I still have no idea why it doesn't work for you. Maybe master has different code... I tested this in 3.8.3 after all. Here is a new patch that has better code because it keeps the inactive in their original position by keeping a copy of all the options before removing the inactives. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- This patch works for me if I change line 138: if ($(this).attr('checked') === true) { to: if ($(this).attr('checked')) { ...which makes sense because, at least according to Firebug, the checked attribute = "checked" when the checkbox is checked. Works in FF, Chrome, Opera, and IE9 on Windows. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- By the way, this could very well be a difference between jQuery 1.3.2 (in 3.8.x) and jQuery 1.7.2 in master. I don't remember off the top of my head. If the above revision works in 3.8.x then we should be fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11730|0 |1 is obsolete| | --- Comment #9 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Created attachment 11752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11752&action=edit fixed patch new patch that tests if checkbox is checked in a way that should works in all jquery versions and is cleaner -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11752|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11753&action=edit [SIGNED-OFF] Bug 8659 Remove and readd the inactive funds in javascript to make it work in all browsers Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ago@bywatersolutions.com --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- *** Bug 8669 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: No regression found with FF, so I marked it as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org