[Bug 36577] New: (bug 34478 follow-up) marc21_linking_section.pl not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Bug ID: 36577 Summary: (bug 34478 follow-up) marc21_linking_section.pl not working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P1 - high Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, jonathan.druart@gmail.com After applying "Bug 34478: op =~ ^cud- everywhere" the plugin marc21_linking_section.pl stopped working properly. Changes in marc21_linking_section.tt need to be reflected in marc21_linking_section.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 164683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164683&action=edit Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working After applying "Bug 34478: op =~ ^cud- everywhere" the plugin marc21_linking_section.pl stopped working properly. Changes in marc21_linking_section.tt need to be reflected in marc21_linking_section.pl Test plan ========= 1. Configure a MARC bibliographic framework to use the plugin marc21_linking_section.pl (e.g. in 773 $t). 2. Start creating a new record and go to 773 $t. Activate the plugin to find the host record (perform a search for any common word). 3. You will get no results. 4. Apply the patch, restart plack etc. 5. Repeat p. 2 - you should now see some results. BTW, QA people - maybe it would pay to remove the commented code present there since the very beginning (2012). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Depends on| |34478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164683|0 |1 is obsolete| | --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 164864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164864&action=edit Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working After applying "Bug 34478: op =~ ^cud- everywhere" the plugin marc21_linking_section.pl stopped working properly. Since the plugin does not perform a CUD operation, the GET request can be used, and so the use of CSRF token is not needed. The patch fixes also problems with result page numbers display. Test plan ========= 1. Configure a MARC bibliographic framework to use the plugin marc21_linking_section.pl (e.g. in 773 $t). 2. Start creating a new record and go to 773 $t. Activate the plugin to find the any record to become the host record (perform a search for any common word, like 'and'). 3. You will get no results. 4. Apply the patch, restart plack etc. 5. Repeat p. 2 - you should now see some results, possibly more than one page. You should be able to change page with Next/Previous arrows and also with the page numbers. BTW, QA people - maybe it would pay to remove the commented code present there since the very beginning (2012). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164864|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 164867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164867&action=edit Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working After applying "Bug 34478: op =~ ^cud- everywhere" the plugin marc21_linking_section.pl stopped working properly. Since the plugin does not perform a CUD operation, the GET request can be used, and so the use of CSRF token is not needed. The patch fixes also problems with result page numbers display. Test plan ========= 1. Configure a MARC bibliographic framework to use the plugin marc21_linking_section.pl (e.g. in 773 $t). 2. Start creating a new record and go to 773 $t. Activate the plugin to find the any record to become the host record (perform a search for any common word, like 'and'). 3. You will get no results. 4. Apply the patch, restart plack etc. 5. Repeat p. 2 - you should now see some results, possibly more than one page. You should be able to change page with Next/Previous arrows and also with the page numbers. BTW, QA people - maybe it would pay to remove the commented code present there since the very beginning (2012). Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164867|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165026&action=edit Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working After applying "Bug 34478: op =~ ^cud- everywhere" the plugin marc21_linking_section.pl stopped working properly. Since the plugin does not perform a CUD operation, the GET request can be used, and so the use of CSRF token is not needed. The patch fixes also problems with result page numbers display. Test plan ========= 1. Configure a MARC bibliographic framework to use the plugin marc21_linking_section.pl (e.g. in 773 $t). 2. Start creating a new record and go to 773 $t. Activate the plugin to find the any record to become the host record (perform a search for any common word, like 'and'). 3. You will get no results. 4. Apply the patch, restart plack etc. 5. Repeat p. 2 - you should now see some results, possibly more than one page. You should be able to change page with Next/Previous arrows and also with the page numbers. BTW, QA people - maybe it would pay to remove the commented code present there since the very beginning (2012). Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 34478 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Bug 36577 depends on bug 34478, which changed state. Bug 34478 Summary: Full CSRF protection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36577 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40306 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org