[Bug 29648] New: Replace NumSavedReports with table configuration setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Bug ID: 29648 Summary: Replace NumSavedReports with table configuration setting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Bug 29530 discussed, that the NumSavedReports would be better placed as an option in the table configuration settings. Using this as a pattern could also then help add this option to more tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29530 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart+koha@gmail. | |com CC| |jonathan.druart+koha@gmail. | |com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128592&action=edit Bug 29648: Improve existing code We already have 2 tables that are configurable, on acqui/basket and reports/orders_by_budget. This patch is modifying a bit the existing code to transfer the responsability/logic to the KohaTable constructor instead of the template that is creating the object. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128593&action=edit Bug 29648: Move NumSavedReports to the table settings The syspref NumSavedReports can be moved to the table settings config Test plan: 1. Set the syspref to a given value 2. updatedatabase # execute the atomic update 3. Go to the table settings page and confirm that the syspref's value has been retrieved 4. Select a specific colonne for the default sort 5. Go to the report list view and confirm that the "Show X entries" has the correct selected value and that the table is sorted as you expect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128594&action=edit Bug 29648: Add item - broken FIXME Why don't we have the columns visibility button? It looks like there is something broken here, why don't we have the show/hide columns buttons? The code expects it to be displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128595&action=edit Bug 29648: Duplicate orders view - no change No change expected here, only removing commented-out code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128596&action=edit Bug 29648: Order search view - normal "normal" means that we are expecting the table to have the 2 options implemented and working. You can select "Default display length" and "Default sort order" in the "table settings" administration view, then go the the view and confirm that the table has the configured values pre-selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128597&action=edit Bug 29648: Late orders view - normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128598&action=edit Bug 29648: Authorised values view No change is expected on this view as the table is not part of the table settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128599&action=edit Bug 29648: Libraries administration view - normale -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128600&action=edit Bug 29648: Patron categories administration view - normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128601&action=edit Bug 29648: Cities administration view - REST API Here we need to deal with the other DT config (in datatables.js, not columns_settings.inc). Test plan: Same as "normal" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128602&action=edit Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128603&action=edit Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128604&action=edit Bug 29648: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128605&action=edit Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128606&action=edit Bug 29648: Checkout history - normal no sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128607&action=edit Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128608&action=edit Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128609&action=edit Bug 29648: Holds to pull - normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128610&action=edit Bug 29648: Holds ratios - normal but no sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128611&action=edit Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128612&action=edit Bug 29648: Holds queue - only sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128613&action=edit Bug 29648: Course reserve detail - normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128614&action=edit Bug 29648: Course reserve list - normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128615&action=edit Bug 29648: ILL - no change No change expected here for ILL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128616&action=edit Bug 29648: Patron accounting page - no sort because of desc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128617&action=edit Bug 29648: Holds history - no sort because of desc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128618&action=edit Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128619&action=edit Bug 29648: Payments - normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128620&action=edit Bug 29648: Checkout history - no sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128621&action=edit Bug 29648: patron list table - normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128622&action=edit Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128623&action=edit Bug 29648: Subscription detail - no change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128624&action=edit Bug 29648: Notice template - only sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128625&action=edit Bug 29648: Upload tool - no sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128626&action=edit Bug 29648: Log viewer - no sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace NumSavedReports |Make KohaTable tables |with table configuration |'default length' and |setting |'default sort' configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29530 | Depends on| |29530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 [Bug 29530] When NumSavedReports is set, show value in pull down of entries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 [Bug 29723] Add a "Configure table" button for KohaTable tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Warning from the QA tool: FAIL C4/Utils/DataTables/TablesSettings.pm FAIL pod *** WARNING: =head3 without preceding higher level in file C4/Utils/DataTables/TablesSettings.pm *** WARNING: =head3 without preceding higher level in file C4/Utils/DataTables/TablesSettings.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- This change results in a JS error on the page, 'Uncaught TypeError: can't access property "columns", table_settings is undefined' --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt @@ -328,10 +328,9 @@ Acquisitions › Koha var MSG_NO_FUND_SELECTED = _("No fund selected."); $(document).ready(function() { $('span.hint').hide(); - var columns_settings;// = [% TablesSettings.GetColumns( 'acqui', 'histsearch', 'histsearcht', 'json' ) | $raw %]; KohaTable("table_orders", { "bPaginate": false - }, columns_settings ); + }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #37)
This change results in a JS error on the page, 'Uncaught TypeError: can't access property "columns", table_settings is undefined'
Fixed in a later patch, or a false alarm? I'm going through them in smaller chunks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #39 from Owen Leonard <oleonard@myacpl.org> --- More notes: - On the bibliographic detail page, the default sort column doesn't work correctly. Why are there so many columns to configure when they don't exist in the table? - On the overdues page the default sort order and default display length aren't applied. - Holds to pull: Column configuration doesn't seem to work. - Holds history: 'Uncaught TypeError: can't access property "filter", table_settings.columns is undefined' - Notice template: Column configuration doesn't work. Columns selected to be hidden are not hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128617|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129084&action=edit Bug 29648: Holds history - no sort because of desc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128624|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129085&action=edit Bug 29648: Notice template - only sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #39)
More notes:
- On the bibliographic detail page, the default sort column doesn't work correctly. Why are there so many columns to configure when they don't exist in the table?
It seems to work for me, I selected "holdings_holdinbranch" and the table is sorted by "Home library". The table settings is listing all the columns that can be displayed, but only the non-empty columns are displayed. For instance if none of your items have $u, then the "URL" column won't be displayed.
- On the overdues page the default sort order and default display length aren't applied.
This table has the stateSave flag on. You need to remove the local storage item before trying it.
- Holds to pull: Column configuration doesn't seem to work.
I have selected 50 and "patron" and it's working for me. Can you detail?
- Holds history: 'Uncaught TypeError: can't access property "filter", table_settings.columns is undefined'
Oops, fixed!
- Notice template: Column configuration doesn't work. Columns selected to be hidden are not hidden.
Fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129089&action=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129352&action=edit Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- I ran into a few other issues: * Reservoir search (addbooks.pl) is missing the columns control button * waitingreserves.pl has a JS error: "holdst_columns_settings is not defined" * marc_modification_templates columns not hiding according the the configuration, and the columns control button is missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128625|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129685&action=edit Bug 29648: Upload tool - no sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129089|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129686&action=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #45)
I ran into a few other issues:
* Reservoir search (addbooks.pl) is missing the columns control button * waitingreserves.pl has a JS error: "holdst_columns_settings is not defined" * marc_modification_templates columns not hiding according the the configuration, and the columns control button is missing
Thanks, Owen. This is now fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128592|0 |1 is obsolete| | Attachment #128593|0 |1 is obsolete| | Attachment #128594|0 |1 is obsolete| | Attachment #128595|0 |1 is obsolete| | Attachment #128596|0 |1 is obsolete| | Attachment #128597|0 |1 is obsolete| | Attachment #128598|0 |1 is obsolete| | Attachment #128599|0 |1 is obsolete| | Attachment #128600|0 |1 is obsolete| | Attachment #128601|0 |1 is obsolete| | Attachment #128602|0 |1 is obsolete| | Attachment #128603|0 |1 is obsolete| | Attachment #128604|0 |1 is obsolete| | Attachment #128605|0 |1 is obsolete| | Attachment #128606|0 |1 is obsolete| | Attachment #128607|0 |1 is obsolete| | Attachment #128608|0 |1 is obsolete| | Attachment #128609|0 |1 is obsolete| | Attachment #128610|0 |1 is obsolete| | Attachment #128611|0 |1 is obsolete| | Attachment #128612|0 |1 is obsolete| | Attachment #128613|0 |1 is obsolete| | Attachment #128614|0 |1 is obsolete| | Attachment #128615|0 |1 is obsolete| | Attachment #128616|0 |1 is obsolete| | Attachment #128618|0 |1 is obsolete| | Attachment #128619|0 |1 is obsolete| | Attachment #128620|0 |1 is obsolete| | Attachment #128621|0 |1 is obsolete| | Attachment #128622|0 |1 is obsolete| | Attachment #128623|0 |1 is obsolete| | Attachment #128626|0 |1 is obsolete| | Attachment #129084|0 |1 is obsolete| | Attachment #129085|0 |1 is obsolete| | Attachment #129352|0 |1 is obsolete| | Attachment #129685|0 |1 is obsolete| | Attachment #129686|0 |1 is obsolete| | --- Comment #49 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129770&action=edit Bug 29648: Improve existing code We already have 2 tables that are configurable, on acqui/basket and reports/orders_by_budget. This patch is modifying a bit the existing code to transfer the responsability/logic to the KohaTable constructor instead of the template that is creating the object. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #50 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129771&action=edit Bug 29648: Move NumSavedReports to the table settings The syspref NumSavedReports can be moved to the table settings config Test plan: 1. Set the syspref to a given value 2. updatedatabase # execute the atomic update 3. Go to the table settings page and confirm that the syspref's value has been retrieved 4. Select a specific colonne for the default sort 5. Go to the report list view and confirm that the "Show X entries" has the correct selected value and that the table is sorted as you expect. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #51 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129772&action=edit Bug 29648: Add item - broken FIXME Why don't we have the columns visibility button? It looks like there is something broken here, why don't we have the show/hide columns buttons? The code expects it to be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129773&action=edit Bug 29648: Duplicate orders view - no change No change expected here, only removing commented-out code. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129774&action=edit Bug 29648: Order search view - normal "normal" means that we are expecting the table to have the 2 options implemented and working. You can select "Default display length" and "Default sort order" in the "table settings" administration view, then go the the view and confirm that the table has the configured values pre-selected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129775&action=edit Bug 29648: Late orders view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #55 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129776&action=edit Bug 29648: Authorised values view No change is expected on this view as the table is not part of the table settings. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #56 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129777&action=edit Bug 29648: Libraries administration view - normale Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #57 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129778&action=edit Bug 29648: Patron categories administration view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #58 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129779&action=edit Bug 29648: Cities administration view - REST API Here we need to deal with the other DT config (in datatables.js, not columns_settings.inc). Test plan: Same as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #59 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129780&action=edit Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #60 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129781&action=edit Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #61 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129782&action=edit Bug 29648: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #62 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129783&action=edit Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #63 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129784&action=edit Bug 29648: Checkout history - normal no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #64 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129785&action=edit Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #65 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129786&action=edit Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #66 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129787&action=edit Bug 29648: Holds to pull - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #67 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129788&action=edit Bug 29648: Holds ratios - normal but no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #68 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129789&action=edit Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #69 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129790&action=edit Bug 29648: Holds queue - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #70 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129791&action=edit Bug 29648: Course reserve detail - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #71 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129792&action=edit Bug 29648: Course reserve list - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #72 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129793&action=edit Bug 29648: ILL - no change No change expected here for ILL Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #73 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129794&action=edit Bug 29648: Patron accounting page - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #74 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129795&action=edit Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #75 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129796&action=edit Bug 29648: Payments - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #76 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129797&action=edit Bug 29648: Checkout history - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #77 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129798&action=edit Bug 29648: patron list table - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #78 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129799&action=edit Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #79 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129800&action=edit Bug 29648: Subscription detail - no change Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #80 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129801&action=edit Bug 29648: Log viewer - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #81 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129802&action=edit Bug 29648: Holds history - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #82 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129803&action=edit Bug 29648: Notice template - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #83 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129804&action=edit Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #84 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129805&action=edit Bug 29648: Upload tool - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #85 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129806&action=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Bug 29648 depends on bug 29530, which changed state. Bug 29530 Summary: When NumSavedReports is set, show value in pull down of entries https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Patch doesn't apply QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | --- Comment #86 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm sorry, can you please rebase the last patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129806|0 |1 is obsolete| | --- Comment #87 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131703&action=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129789|0 |1 is obsolete| | --- Comment #88 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131875&action=edit Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131703|0 |1 is obsolete| | --- Comment #89 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131876&action=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129780|0 |1 is obsolete| | Attachment #129781|0 |1 is obsolete| | Attachment #129782|0 |1 is obsolete| | Attachment #129783|0 |1 is obsolete| | Attachment #129784|0 |1 is obsolete| | Attachment #129785|0 |1 is obsolete| | Attachment #129786|0 |1 is obsolete| | Attachment #129787|0 |1 is obsolete| | Attachment #129788|0 |1 is obsolete| | Attachment #129790|0 |1 is obsolete| | Attachment #129791|0 |1 is obsolete| | Attachment #129792|0 |1 is obsolete| | Attachment #129793|0 |1 is obsolete| | Attachment #129794|0 |1 is obsolete| | Attachment #129795|0 |1 is obsolete| | Attachment #129796|0 |1 is obsolete| | Attachment #129797|0 |1 is obsolete| | Attachment #129798|0 |1 is obsolete| | Attachment #129799|0 |1 is obsolete| | Attachment #129800|0 |1 is obsolete| | Attachment #129801|0 |1 is obsolete| | Attachment #129802|0 |1 is obsolete| | Attachment #129803|0 |1 is obsolete| | Attachment #129804|0 |1 is obsolete| | Attachment #129805|0 |1 is obsolete| | Attachment #131875|0 |1 is obsolete| | Attachment #131876|0 |1 is obsolete| | --- Comment #90 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133001&action=edit Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #91 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133002&action=edit Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #92 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133003&action=edit Bug 29648: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #93 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133004&action=edit Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #94 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133005&action=edit Bug 29648: Checkout history - normal no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #95 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133006&action=edit Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #96 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133007&action=edit Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #97 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133008&action=edit Bug 29648: Holds to pull - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #98 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133009&action=edit Bug 29648: Holds ratios - normal but no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #99 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133010&action=edit Bug 29648: Holds queue - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #100 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133011&action=edit Bug 29648: Course reserve detail - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #101 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133012&action=edit Bug 29648: Course reserve list - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #102 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133013&action=edit Bug 29648: ILL - no change No change expected here for ILL Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #103 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133014&action=edit Bug 29648: Patron accounting page - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #104 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133015&action=edit Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #105 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133016&action=edit Bug 29648: Payments - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #106 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133017&action=edit Bug 29648: Checkout history - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #107 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133018&action=edit Bug 29648: patron list table - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #108 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133019&action=edit Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #109 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133020&action=edit Bug 29648: Subscription detail - no change Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #110 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133021&action=edit Bug 29648: Log viewer - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #111 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133022&action=edit Bug 29648: Holds history - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #112 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133023&action=edit Bug 29648: Notice template - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #113 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133024&action=edit Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #114 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133025&action=edit Bug 29648: Upload tool - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #115 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133026&action=edit Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #116 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133027&action=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #117 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- QA please? This is a nightmare to rebase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #118 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #117)
QA please? This is a nightmare to rebase!
Sorry to be late :( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29648: Improve existing code Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29648: Improve existing code Could you please rebase? I'll try to get back to this ASAP after. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129770|0 |1 is obsolete| | Attachment #129771|0 |1 is obsolete| | Attachment #129772|0 |1 is obsolete| | Attachment #129773|0 |1 is obsolete| | Attachment #129774|0 |1 is obsolete| | Attachment #129775|0 |1 is obsolete| | Attachment #129776|0 |1 is obsolete| | Attachment #129777|0 |1 is obsolete| | Attachment #129778|0 |1 is obsolete| | Attachment #129779|0 |1 is obsolete| | Attachment #133001|0 |1 is obsolete| | Attachment #133002|0 |1 is obsolete| | Attachment #133003|0 |1 is obsolete| | Attachment #133004|0 |1 is obsolete| | Attachment #133005|0 |1 is obsolete| | Attachment #133006|0 |1 is obsolete| | Attachment #133007|0 |1 is obsolete| | Attachment #133008|0 |1 is obsolete| | Attachment #133009|0 |1 is obsolete| | Attachment #133010|0 |1 is obsolete| | Attachment #133011|0 |1 is obsolete| | Attachment #133012|0 |1 is obsolete| | Attachment #133013|0 |1 is obsolete| | Attachment #133014|0 |1 is obsolete| | Attachment #133015|0 |1 is obsolete| | Attachment #133016|0 |1 is obsolete| | Attachment #133017|0 |1 is obsolete| | Attachment #133018|0 |1 is obsolete| | Attachment #133019|0 |1 is obsolete| | Attachment #133020|0 |1 is obsolete| | Attachment #133021|0 |1 is obsolete| | Attachment #133022|0 |1 is obsolete| | Attachment #133023|0 |1 is obsolete| | Attachment #133024|0 |1 is obsolete| | Attachment #133025|0 |1 is obsolete| | Attachment #133026|0 |1 is obsolete| | Attachment #133027|0 |1 is obsolete| | --- Comment #119 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134018&action=edit Bug 29648: Improve existing code We already have 2 tables that are configurable, on acqui/basket and reports/orders_by_budget. This patch is modifying a bit the existing code to transfer the responsability/logic to the KohaTable constructor instead of the template that is creating the object. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #120 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134019&action=edit Bug 29648: Move NumSavedReports to the table settings The syspref NumSavedReports can be moved to the table settings config Test plan: 1. Set the syspref to a given value 2. updatedatabase # execute the atomic update 3. Go to the table settings page and confirm that the syspref's value has been retrieved 4. Select a specific colonne for the default sort 5. Go to the report list view and confirm that the "Show X entries" has the correct selected value and that the table is sorted as you expect. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #121 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134020&action=edit Bug 29648: Add item - broken FIXME Why don't we have the columns visibility button? It looks like there is something broken here, why don't we have the show/hide columns buttons? The code expects it to be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #122 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134021&action=edit Bug 29648: Duplicate orders view - no change No change expected here, only removing commented-out code. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #123 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134022&action=edit Bug 29648: Order search view - normal "normal" means that we are expecting the table to have the 2 options implemented and working. You can select "Default display length" and "Default sort order" in the "table settings" administration view, then go the the view and confirm that the table has the configured values pre-selected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #124 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134023&action=edit Bug 29648: Late orders view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #125 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134024&action=edit Bug 29648: Authorised values view No change is expected on this view as the table is not part of the table settings. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #126 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134025&action=edit Bug 29648: Libraries administration view - normale Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #127 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134026&action=edit Bug 29648: Patron categories administration view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #128 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134027&action=edit Bug 29648: Cities administration view - REST API Here we need to deal with the other DT config (in datatables.js, not columns_settings.inc). Test plan: Same as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #129 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134028&action=edit Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #130 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134029&action=edit Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #131 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134030&action=edit Bug 29648: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #132 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134031&action=edit Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #133 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134032&action=edit Bug 29648: Checkout history - normal no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #134 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134033&action=edit Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #135 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134034&action=edit Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #136 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134035&action=edit Bug 29648: Holds to pull - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #137 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134036&action=edit Bug 29648: Holds ratios - normal but no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #138 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134037&action=edit Bug 29648: Holds queue - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #139 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134038&action=edit Bug 29648: Course reserve detail - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #140 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134039&action=edit Bug 29648: Course reserve list - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #141 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134040&action=edit Bug 29648: ILL - no change No change expected here for ILL Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #142 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134041&action=edit Bug 29648: Patron accounting page - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #143 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134042&action=edit Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #144 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134043&action=edit Bug 29648: Payments - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #145 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134044&action=edit Bug 29648: Checkout history - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #146 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134045&action=edit Bug 29648: patron list table - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #147 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134046&action=edit Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #148 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134047&action=edit Bug 29648: Subscription detail - no change Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #149 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134048&action=edit Bug 29648: Log viewer - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #150 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134049&action=edit Bug 29648: Holds history - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #151 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134050&action=edit Bug 29648: Notice template - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #152 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134051&action=edit Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #153 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134052&action=edit Bug 29648: Upload tool - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #154 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134053&action=edit Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #155 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134054&action=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134018|0 |1 is obsolete| | --- Comment #156 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134086&action=edit Bug 29648: Improve existing code We already have 2 tables that are configurable, on acqui/basket and reports/orders_by_budget. This patch is modifying a bit the existing code to transfer the responsability/logic to the KohaTable constructor instead of the template that is creating the object. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134019|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134087&action=edit Bug 29648: Move NumSavedReports to the table settings The syspref NumSavedReports can be moved to the table settings config Test plan: 1. Set the syspref to a given value 2. updatedatabase # execute the atomic update 3. Go to the table settings page and confirm that the syspref's value has been retrieved 4. Select a specific colonne for the default sort 5. Go to the report list view and confirm that the "Show X entries" has the correct selected value and that the table is sorted as you expect. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134020|0 |1 is obsolete| | --- Comment #158 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134088&action=edit Bug 29648: Add item - broken FIXME Why don't we have the columns visibility button? It looks like there is something broken here, why don't we have the show/hide columns buttons? The code expects it to be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134021|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134089&action=edit Bug 29648: Duplicate orders view - no change No change expected here, only removing commented-out code. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134022|0 |1 is obsolete| | --- Comment #160 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134090&action=edit Bug 29648: Order search view - normal "normal" means that we are expecting the table to have the 2 options implemented and working. You can select "Default display length" and "Default sort order" in the "table settings" administration view, then go the the view and confirm that the table has the configured values pre-selected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134023|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134091&action=edit Bug 29648: Late orders view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134024|0 |1 is obsolete| | --- Comment #162 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134092&action=edit Bug 29648: Authorised values view No change is expected on this view as the table is not part of the table settings. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134025|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134093&action=edit Bug 29648: Libraries administration view - normale Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134026|0 |1 is obsolete| | --- Comment #164 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134094&action=edit Bug 29648: Patron categories administration view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134027|0 |1 is obsolete| | --- Comment #165 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134095&action=edit Bug 29648: Cities administration view - REST API Here we need to deal with the other DT config (in datatables.js, not columns_settings.inc). Test plan: Same as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134028|0 |1 is obsolete| | --- Comment #166 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134096&action=edit Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134029|0 |1 is obsolete| | --- Comment #167 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134097&action=edit Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134030|0 |1 is obsolete| | --- Comment #168 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134098&action=edit Bug 29648: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134031|0 |1 is obsolete| | --- Comment #169 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134099&action=edit Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134032|0 |1 is obsolete| | --- Comment #170 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134100&action=edit Bug 29648: Checkout history - normal no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134033|0 |1 is obsolete| | --- Comment #171 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134101&action=edit Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134034|0 |1 is obsolete| | --- Comment #172 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134102&action=edit Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134035|0 |1 is obsolete| | --- Comment #173 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134103&action=edit Bug 29648: Holds to pull - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134036|0 |1 is obsolete| | --- Comment #174 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134104&action=edit Bug 29648: Holds ratios - normal but no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134037|0 |1 is obsolete| | --- Comment #175 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134105&action=edit Bug 29648: Holds queue - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134038|0 |1 is obsolete| | --- Comment #176 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134106&action=edit Bug 29648: Course reserve detail - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134039|0 |1 is obsolete| | --- Comment #177 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134107&action=edit Bug 29648: Course reserve list - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134040|0 |1 is obsolete| | --- Comment #178 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134108&action=edit Bug 29648: ILL - no change No change expected here for ILL Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134041|0 |1 is obsolete| | --- Comment #179 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134109&action=edit Bug 29648: Patron accounting page - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134042|0 |1 is obsolete| | --- Comment #180 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134110&action=edit Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134043|0 |1 is obsolete| | --- Comment #181 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134111&action=edit Bug 29648: Payments - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134044|0 |1 is obsolete| | --- Comment #182 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134112&action=edit Bug 29648: Checkout history - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134045|0 |1 is obsolete| | --- Comment #183 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134113&action=edit Bug 29648: patron list table - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134046|0 |1 is obsolete| | --- Comment #184 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134114&action=edit Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134047|0 |1 is obsolete| | --- Comment #185 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134115&action=edit Bug 29648: Subscription detail - no change Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134048|0 |1 is obsolete| | --- Comment #186 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134116&action=edit Bug 29648: Log viewer - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134049|0 |1 is obsolete| | --- Comment #187 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134117&action=edit Bug 29648: Holds history - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134050|0 |1 is obsolete| | --- Comment #188 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134118&action=edit Bug 29648: Notice template - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134051|0 |1 is obsolete| | --- Comment #189 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134119&action=edit Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134052|0 |1 is obsolete| | --- Comment #190 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134120&action=edit Bug 29648: Upload tool - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134053|0 |1 is obsolete| | --- Comment #191 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134121&action=edit Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134054|0 |1 is obsolete| | --- Comment #192 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134122&action=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #193 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134123&action=edit Bug 29648: (QA follow-up) Minor POD fix This just adds a top level set of POD headings to make the QA script happy Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #194 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks great to me. Added a small follow-up to keep the QA script happy. Katrin and I overlapped again so I've uploaded my SO and will leave her to set the final PQA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #195 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd say it was teamwork on this one, providing another follow-up. I like to see this getting more flexible and hope we can implement the options for a lot more tables. At some point I'd love to see a primary and secondary sort. For example we get a lot of requests for the OPAC item table to sort by different criteria. One could imagine something like: homebranch, itemtype. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134086|0 |1 is obsolete| | --- Comment #196 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134133&action=edit Bug 29648: Improve existing code We already have 2 tables that are configurable, on acqui/basket and reports/orders_by_budget. This patch is modifying a bit the existing code to transfer the responsability/logic to the KohaTable constructor instead of the template that is creating the object. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134087|0 |1 is obsolete| | --- Comment #197 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134134&action=edit Bug 29648: Move NumSavedReports to the table settings The syspref NumSavedReports can be moved to the table settings config Test plan: 1. Set the syspref to a given value 2. updatedatabase # execute the atomic update 3. Go to the table settings page and confirm that the syspref's value has been retrieved 4. Select a specific colonne for the default sort 5. Go to the report list view and confirm that the "Show X entries" has the correct selected value and that the table is sorted as you expect. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134088|0 |1 is obsolete| | --- Comment #198 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134135&action=edit Bug 29648: Add item - broken FIXME Why don't we have the columns visibility button? It looks like there is something broken here, why don't we have the show/hide columns buttons? The code expects it to be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134089|0 |1 is obsolete| | --- Comment #199 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134136&action=edit Bug 29648: Duplicate orders view - no change No change expected here, only removing commented-out code. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134090|0 |1 is obsolete| | --- Comment #200 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134137&action=edit Bug 29648: Order search view - normal "normal" means that we are expecting the table to have the 2 options implemented and working. You can select "Default display length" and "Default sort order" in the "table settings" administration view, then go the the view and confirm that the table has the configured values pre-selected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134091|0 |1 is obsolete| | --- Comment #201 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134138&action=edit Bug 29648: Late orders view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134092|0 |1 is obsolete| | --- Comment #202 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134139&action=edit Bug 29648: Authorised values view No change is expected on this view as the table is not part of the table settings. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134093|0 |1 is obsolete| | --- Comment #203 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134140&action=edit Bug 29648: Libraries administration view - normale Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134094|0 |1 is obsolete| | --- Comment #204 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134141&action=edit Bug 29648: Patron categories administration view - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134095|0 |1 is obsolete| | --- Comment #205 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134142&action=edit Bug 29648: Cities administration view - REST API Here we need to deal with the other DT config (in datatables.js, not columns_settings.inc). Test plan: Same as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134096|0 |1 is obsolete| | --- Comment #206 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134143&action=edit Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134097|0 |1 is obsolete| | --- Comment #207 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134144&action=edit Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134098|0 |1 is obsolete| | --- Comment #208 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134145&action=edit Bug 29648: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134099|0 |1 is obsolete| | --- Comment #209 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134146&action=edit Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134100|0 |1 is obsolete| | --- Comment #210 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134147&action=edit Bug 29648: Checkout history - normal no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134101|0 |1 is obsolete| | --- Comment #211 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134148&action=edit Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134102|0 |1 is obsolete| | --- Comment #212 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134149&action=edit Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134103|0 |1 is obsolete| | --- Comment #213 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134150&action=edit Bug 29648: Holds to pull - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134104|0 |1 is obsolete| | --- Comment #214 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134151&action=edit Bug 29648: Holds ratios - normal but no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134105|0 |1 is obsolete| | --- Comment #215 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134152&action=edit Bug 29648: Holds queue - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134106|0 |1 is obsolete| | --- Comment #216 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134153&action=edit Bug 29648: Course reserve detail - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134107|0 |1 is obsolete| | --- Comment #217 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134154&action=edit Bug 29648: Course reserve list - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134108|0 |1 is obsolete| | --- Comment #218 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134155&action=edit Bug 29648: ILL - no change No change expected here for ILL Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134109|0 |1 is obsolete| | --- Comment #219 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134156&action=edit Bug 29648: Patron accounting page - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134110|0 |1 is obsolete| | --- Comment #220 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134157&action=edit Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134111|0 |1 is obsolete| | --- Comment #221 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134158&action=edit Bug 29648: Payments - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134112|0 |1 is obsolete| | --- Comment #222 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134159&action=edit Bug 29648: Checkout history - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134113|0 |1 is obsolete| | --- Comment #223 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134160&action=edit Bug 29648: patron list table - normal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134114|0 |1 is obsolete| | --- Comment #224 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134161&action=edit Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134115|0 |1 is obsolete| | --- Comment #225 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134162&action=edit Bug 29648: Subscription detail - no change Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134116|0 |1 is obsolete| | --- Comment #226 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134163&action=edit Bug 29648: Log viewer - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134117|0 |1 is obsolete| | --- Comment #227 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134164&action=edit Bug 29648: Holds history - no sort because of desc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134118|0 |1 is obsolete| | --- Comment #228 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134165&action=edit Bug 29648: Notice template - only sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134119|0 |1 is obsolete| | --- Comment #229 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134166&action=edit Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134120|0 |1 is obsolete| | --- Comment #230 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134167&action=edit Bug 29648: Upload tool - no sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134121|0 |1 is obsolete| | --- Comment #231 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134168&action=edit Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134122|0 |1 is obsolete| | --- Comment #232 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134169&action=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134123|0 |1 is obsolete| | --- Comment #233 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134170&action=edit Bug 29648: (QA follow-up) Minor POD fix This just adds a top level set of POD headings to make the QA script happy Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #234 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134171&action=edit Bug 29648: (QA follow-up) Remove NumSavedReports from .pref file Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 [Bug 30633] Move OPACHoldingsDefaultSortField to table settings configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #235 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 134194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134194&action=edit Bug 29648: (follow-up) Add missing raw filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #236 from Fridolin Somers <fridolin.somers@biblibre.com> --- Great enhancement. I push it asap to avoid more rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #237 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah we should remove "actions" from default sort order. My 2c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #238 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #237)
Ah we should remove "actions" from default sort order. My 2c
And also "selection". Using them does not break the table, ouf ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #239 from Fridolin Somers <fridolin.somers@biblibre.com> --- I've added to DBRev a print when preference was enabled : "NumSavedReports value '20' moved to table settings" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #240 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747 [Bug 30747] Column settings on otherholdings table in detail.tt doesnt work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938 [Bug 30938] Add column configuration to the acquisitions home page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30336 [Bug 30336] Default sort order of late orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31696 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33156 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 [Bug 33156] Batch patron modification tool is missing search bar and other attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40730 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40730 [Bug 40730] Add ability to select default sort and display length for table 'accounts' on acquisitions page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org