[Bug 15415] New: Warn when creating new printer profile for patron card creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Bug ID: 15415 Summary: Warn when creating new printer profile for patron card creator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org edit-profile.pl: profile_id is currently undefined. at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 187 To reproduce, go to Tools -> Patron Card Creator -> New profile -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 46760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46760&action=edit Bug 15415: Warn when creating a new print profile This warn is hard-coded in Profile.pm sub get_attr { my $self = shift; if (_check_params(@_) eq 1) { return -1; } my ($attr) = @_; if (exists($self->{$attr})) { return $self->{$attr}; } else { warn sprintf('%s is currently undefined.', $attr); <-- THIS LINE return -1; } } So I have removed this line because I don't think it's really necessary. To test: 1) Go to Tools -> Patron Card Creator -> New printer profile 2) Notice warn 3) Apply patch 4) Refresh page 5) Confirm warn is gone and page still works as expected -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org