[Bug 41251] New: Ability to edit linked serials when editing items needs to be optional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Bug ID: 41251 Summary: Ability to edit linked serials when editing items needs to be optional Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Bug 37116 added the ability to edit linked serials when editing items. There is no way to turn this off and it has created some extra clicks and frustration for librarians who do not want the option. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37116 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37116 [Bug 37116] Add the option to edit linked serials when editing items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Kris <kbecker@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker@jcls.org --- Comment #1 from Kris <kbecker@jcls.org> --- Yes please! That would be great if we could have the choice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Nancy M. <nmumford@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nmumford@clamsnet.org --- Comment #2 from Nancy M. <nmumford@clamsnet.org> --- We just noticed this today. Very annoying and causing a lot of questions from our member libraries. Please fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Chris Pickford <cpickford@sdlawlibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cpickford@sdlawlibrary.org --- Comment #3 from Chris Pickford <cpickford@sdlawlibrary.org> --- I actually think this is a good enhancement, however, I agree that it would be good to allow libraries to disable it and also to make it a staff permission option. At the library I work at we only permit select staff to edit serials records. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org --- Comment #4 from mteal@greenvillelibrary.org --- We would also like to be able to turn this question off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ephetteplace@cca.edu |ity.org | CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 --- Comment #5 from Eric Phetteplace <ephetteplace@cca.edu> --- I have a patch for this but it's my first time adding a system preference. The testing steps are lengthy because they essentially have to wrap the steps in Bug 37116. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 --- Comment #6 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 195603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195603&action=edit Bug 41251: Ability to edit linked serials when editing items needs to be optional This patch adds a new system preference EditLinkedSerialIssues which prompts the user to edit linked serial issues after editing an item that is linked to a serial issue via a subscription. The pref's default is true to preserve the current behavior, while false skips the prompt. We need to test editing a single item and a batch of items, with the sys pref first enabled and then disabled. Test plan: 1. Apply patch and updatedatabase on ktd 2. Serials > New Subscription > Link to a bib record & select When receiving this serial = Create an item record 3. Receive an item then go to the linked bib 4. Edit the item and click save 5. You should be prompted to edit linked serial issue (you can cancel) 6. Receive another item and go to the linked bib again 7. Under the bib's Edit menu select Edit items in a batch 8. Edit both items and click save 9. You should be prompted to edit the issues again 10. Admin > System Preferences > EditLinkedSerialIssues = Don't prompt 11. Repeat steps 3-9 except you should not be prompted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #7 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 --- Comment #8 from Eric Phetteplace <ephetteplace@cca.edu> --- Bug 41834 totally restructured sysprefs.sql. This is an easy fix but I am having git bz problems at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195603|0 |1 is obsolete| | --- Comment #9 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 195855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195855&action=edit Bug 41251: Ability to edit linked serials when editing items needs to be optional -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jvinke@austinseminary.edu Status|Needs Signoff |Failed QA --- Comment #10 from John Vinke <jvinke@austinseminary.edu> --- I set it to failed QA because while I can apply the patch now, the default actually appears to be "don't prompt." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 --- Comment #11 from Eric Phetteplace <ephetteplace@cca.edu> --- I'm not sure how to proceed, because that's not the default I see. sysprefs.sql line 246 = ('EditLinkedSerialIssues','1'), installer/data/mysql/atomicupdate/bug_41251-EditLinkedSerialIssues_syspref.pl lines 13-14: INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES ('EditLinkedSerialIssues','1',NULL,'If enabled, prompt staff to edit serial issues when editing item(s) on a record with a linked subscription','YesNo') The "1" means True i.e. "Prompt" in this context. Steps: - Apply patch - ktd --shell - updatedatabase - Login to staff side - Administration > Sys Prefs > EditLinkedSerialIssues - Shows "Prompt" Any advice on what might be causing us to receive different results? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195855|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 --- Comment #12 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 195858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195858&action=edit Bug 41251: Ability to edit linked serials when editing items needs to be optional This patch adds a new system preference EditLinkedSerialIssues which prompts the user to edit linked serial issues after editing an item that is linked to a serial issue via a subscription. The pref's default is true to preserve the current behavior, while false skips the prompt. We need to test editing a single item and a batch of items, with the sys pref first enabled and then disabled. Test plan: 1. Apply patch and updatedatabase on ktd 2. Serials > New Subscription > Link to a bib record & select When receiving this serial = Create an item record 3. Receive an item then go to the linked bib 4. Edit the item and click save 5. You should be prompted to edit linked serial issue (you can cancel) 6. Receive another item and go to the linked bib again 7. Under the bib's Edit menu select Edit items in a batch 8. Edit both items and click save 9. You should be prompted to edit the issues again 10. Admin > System Preferences > EditLinkedSerialIssues = Don't prompt 11. Repeat steps 3-9 except you should not be prompted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 --- Comment #13 from John Vinke <jvinke@austinseminary.edu> --- I think there was something left over from when the patch wasn't applying. I started over and it seemed to work. Sorry about that, I'm new to this. John -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 --- Comment #14 from Eric Phetteplace <ephetteplace@cca.edu> --- No worries and thanks for the sign-off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Adding a new preference on a bugfix is rather unusual ;) But the description seems to explain it.. We should not push frustrating features, haha. In the meantime the dbrev changed a bit too for adding sysprefs: INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES You should remove options, explanation and type here please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 --- Comment #16 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 199596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199596&action=edit Bug 41251: fix sys pref creation SQL (qa) options, explanation, value no longer specified in atomicupdate file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41251 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org