[Bug 38071] New: "Clear filter" on catalogue details page always disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Bug ID: 38071 Summary: "Clear filter" on catalogue details page always disabled Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: 1 - Browse to details record for a biblio with items 2 - Click 'Show filters' 3 - Select/type in some filters 4 - Note 'Clear filters' is grayed out 5 - Try to click it, no response -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |pedro.amorim@ptfs-europe.co | |m Depends on| |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the staff biblio detail view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34466, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36804 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172390&action=edit Bug 38071: Preparation Move kohaTable's toggleable clear filter button to its own function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172391&action=edit Bug 38071: Apply kohaTableToggleClearFilter logic to staff holdings table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172392&action=edit Bug 38071: Apply kohaTableToggleClearFilter logic to patrons table Same reason as the holdings table, this table is initialized at a later time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172393&action=edit Bug 38071: Add behavior to work with filters Consider column filters values when deciding if the 'clear filter' should be enabled or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172394&action=edit Bug 38071: Make it so that 'clear filter' also clears the filter values 1 - Browse to details record for a biblio with items 2 - Click 'Show filters' 3 - Select/type in some filters 4 - Note 'Clear filters' is grayed out 5 - Try to click it, no response 6 - Apply patches. Repeat (make sure to use the search text input as well as the column filters. 7 - Repeat the same test plan but for the patrons table 8 - Verify all is working as intended -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- I had a go at testing: 1. Everything seems to be working correctly for the patrons area. 2. For the holdings table, I don't think it is working as expected - maybe these should be other bugs to fix them up: 2.1 The standard DataTable header is not shown for the holdings table until "Show filters" is selected (that is: Showing 1 to 4 of 4 entries ------------------------------------- Show 20 entries First Previous1 Next Last Search: _______ Clear filter ....) 2.2 While the "Clear filter" action is no longer greyed out (when used) and now works, actually entering something to filter on no longer seems to work as expected (I'm not sure it worked before the patch either). For example record 162, Intermediate Perl, search for "Midway" results in "No matching records found". 2.3 Dates in the filters (either the DataTables search or in the table column filter) no longer seem to work. For example: start typing 09/04 for either option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to David Nind from comment #6)
I had a go at testing:
1. Everything seems to be working correctly for the patrons area.
2. For the holdings table, I don't think it is working as expected - maybe these should be other bugs to fix them up: 2.1 The standard DataTable header is not shown for the holdings table until "Show filters" is selected (that is: Showing 1 to 4 of 4 entries ------------------------------------- Show 20 entries First Previous1 Next Last Search: _______ Clear filter ....) 2.2 While the "Clear filter" action is no longer greyed out (when used) and now works, actually entering something to filter on no longer seems to work as expected (I'm not sure it worked before the patch either). For example record 162, Intermediate Perl, search for "Midway" results in "No matching records found". 2.3 Dates in the filters (either the DataTables search or in the table column filter) no longer seem to work. For example: start typing 09/04 for either option
Thank you David, I'm convinced these are all different bugs. 2.1) This is the case before the patches. I don't remember why but I think it was decided to group all of that on the "Show/Hide filters". Not caused by these patches. 2.2) I believe this is because "midway" does not exist on the holdings data. Midway's code is "MPL". Search for "MPL", you'll get Midway. Definitely a separate issue. 2.3) This is a date display problem I think. Not related here. The date displayed is "09/04/2024" but the data contains "2014-09-04". If you search for the latter, you get the results for the former. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172444&action=edit [ALTERNATIVE PATCH] Bug 38071: Ensure search.dt is triggered I don't really understand why the previous code is not working, but the search.dt event handler is not correctly set when initComplete is passed to the constructor (for instance from the patrons search) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172390|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172391|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172392|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172393|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172394|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172446&action=edit Bug 38071: Ensure search.dt is triggered I don't really understand why the previous code is not working, but the search.dt event handler is not correctly set when initComplete is passed to the constructor (for instance from the patrons search) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172444|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Joubu's patch is much better than mine. Fixes the issue the correct way and does not go beyond the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|pedro.amorim@ptfs-europe.co |jonathan.druart@gmail.com |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Nick Clemens (kidclamp) from comment #0)
To recreate: 1 - Browse to details record for a biblio with items 2 - Click 'Show filters' 3 - Select/type in some filters 4 - Note 'Clear filters' is grayed out 5 - Try to click it, no response
I think this is a different "bug" that was the title describes. I am not sure what you are describing is a bug, it has always worked like that. The "Clear filter" button is not plural, and its purpose is to clean the "global search". If we want it to reset the whole table, it should be on its own bug. But that's not an easy one: we have tables where filters are outside of the table (like ERM's agreements). We could have another "reset all" button, eventually. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172446|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172494&action=edit Bug 38071: Ensure search.dt is triggered I don't really understand why the previous code is not working, but the search.dt event handler is not correctly set when initComplete is passed to the constructor (for instance from the patrons search) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38108 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 [Bug 38108] Staff interface holdings table - table navigation only shows when "Show filters" is selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38110 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38110 [Bug 38110] Staff interface tables with filters - date format needs to be YYYY-MM-DD, need to use authorized value codes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #13 from David Nind <david@davidnind.com> --- I've created two "related" bugs - see comment #6 and #7: - Bug 38108 - Staff interface holdings table - table navigation only shows when "Show filters" is selected - Bug 38110 - Staff interface tables with filters - date format needs to be YYYY-MM-DD, need to use authorized value codes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00, 24.05.06 released in| | Keywords|rel_24_05_candidate | Status|Pushed to main |Pushed to stable --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33568 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The fixes the global "Clear release notes| |filter" for tables in the | |staff interface so that you | |can now clear the filter. | |It was previously greyed | |out, and you needed to | |refresh the page to clear | |the filter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #17 from David Nind <david@davidnind.com> --- This is a bug, and not specially covered in the manual. No update to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 Bug 38071 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org