[Bug 7905] New: Multi-line notes are displayed on one line in Staff Serials page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 Priority: P5 - low Change sponsored?: --- Bug ID: 7905 Assignee: adrien.saurat@biblibre.com Summary: Multi-line notes are displayed on one line in Staff Serials page QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha In Serials, on the summary of a subscription, four different notes (nonpublic note, public note, and 2 notes for history) are displayed in one line for each. But when we edit the subscription, it's possible (and tempting) to type the content on several lines. We could try to display these notes on several lines in an elegant way (not so easy because the layout seems to be optimized for one-line informations). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8924&action=edit proposed patch #1 A first and very simple version of what we can do. But the first line is not aligned with the others... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Did you want a signoff now, or would you like to wait for a follow up is done to fix the layout issues? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 --- Comment #3 from Adrien SAURAT <adrien.saurat@biblibre.com> --- I'd like to read a few opinions about this. If this version is considered ok, then we can sign it off, but if someone has a better idea, I could implement it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8924|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10317&action=edit [SIGNED-OFF] Bug 7905: display serial notes on several lines Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works and makes use of TT filters! I agree the display could be improved to work a bit nicer for long lines or multi-line comments, but this is still a nice improvement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10319&action=edit Bug 7905: Follow up - Multi-line subscription notes This patch adds the TT filter to other places where we are displaying the subscription notes: - OPAC detail page, subscription tab - OPAC subscription brief history page - Staff detail page, subscription tab -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Ian Walls <koha.sekjal@gmail.com> --- Both patches are template only, and add the HTML line break filter to fields that are known to have line breaks. Marking Passed QA on both. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org