[Bug 41336] New: Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Bug ID: 41336 Summary: Vue Router warn on Vue datatable pages Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Vue pages with a dataTable are giving warns like the following: [Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41328 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190077&action=edit Bug 41336: Remove 'No match found for location with path' warnings Cypress tests for Vue app are currently failing because of the following warnings in the console: "[Vue Router warn] No match found for location with path" It happens for routes that are disabled. We should not build a router-link but a "disabled" link instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | CC| |jonathan.druart@gmail.com, | |matt.blenkinsop@openfifth.c | |o.uk Keywords| |rel_25_11_candidate Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190079&action=edit Bug 41336: Fix current (?) On top of "Bug 41354: Fix record sources Vue app" there is still one failing test for t/cypress/integration/Admin/RecordSources_spec.ts 1) Breadcrumbs tests Breadcrumbs: AssertionError: Timed out retrying after 10000ms: Expected to find element: `.current`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Admin/RecordSources_spec.ts:18:11) This patch is trying to fix it but it does not -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41354 CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- The tests still don't pass for me, even with bug 41354 and 41355 applied first - yarn cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts: 1) Breadcrumbs tests Breadcrumbs: AssertionError: Timed out retrying after 10000ms: Expected to find element: `.current`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Admin/RecordSources_spec.ts:18:11) Testing notes (using KTD): 1. Enable ERM (ERMModule system preference) 2. Turn on the developer tools for your browser 3. Go to the ERM landing page 4. Note these warnings in the console: - [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings" - [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings/local" - [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eusage" 5. Bonus: Test other areas of ERM and modules that use Vue and DataTables, such as preservation. 7. Run the test: yarn cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts 8. Apply the patches. 9. yarn build 10. restart_all 11. Repeat steps 3-7: no warnings, test passes Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41354 [Bug 41354] Error when loading "Record sources" Vue app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #4 from David Nind <david@davidnind.com> --- It does fix 'No match found for location with path' warnings 8-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190077|0 |1 is obsolete| | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190107&action=edit Bug 41336: Remove 'No match found for location with path' warnings Cypress tests for Vue app are currently failing because of the following warnings in the console: "[Vue Router warn] No match found for location with path" It happens for routes that are disabled. We should not build a router-link but a "disabled" link instead. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190079|0 |1 is obsolete| | --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190108&action=edit Bug 41336: Fix current (?) On top of "Bug 41354: Fix record sources Vue app" there is still one failing test for t/cypress/integration/Admin/RecordSources_spec.ts 1) Breadcrumbs tests Breadcrumbs: AssertionError: Timed out retrying after 10000ms: Expected to find element: `.current`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Admin/RecordSources_spec.ts:18:11) This patch is trying to fix it but it does not Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- These worked for me, the tests all pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190112&action=edit Bug 41336: Remove 'No match found for location with path' warnings Cypress tests for Vue app are currently failing because of the following warnings in the console: "[Vue Router warn] No match found for location with path" It happens for routes that are disabled. We should not build a router-link but a "disabled" link instead. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #9 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190113&action=edit Bug 41336: Fix current (?) On top of "Bug 41354: Fix record sources Vue app" there is still one failing test for t/cypress/integration/Admin/RecordSources_spec.ts 1) Breadcrumbs tests Breadcrumbs: AssertionError: Timed out retrying after 10000ms: Expected to find element: `.current`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Admin/RecordSources_spec.ts:18:11) This patch is trying to fix it but it does not Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #10 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190114&action=edit Bug 41336: (follow-up) Fix breadcrumb selector in Cypress test The test was looking for .current class but the Vue component uses aria-current="page" attribute instead. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190108|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41364 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Bug 41336 depends on bug 41354, which changed state. Bug 41354 Summary: Error when loading "Record sources" Vue app https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41354 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to main |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Dependency not in 25.05 - not backporting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #13 from David Nind <david@davidnind.com> --- Bug fixes, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org