[Bug 27240] New: Export basket: remove spaces and don't export links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Bug ID: 27240 Summary: Export basket: remove spaces and don't export links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: didier.gautheron@biblibre.com Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org Hi, HTML output is fine but there's a lot of spaces in exported file, remove some. Moreover 12502 add a noExport attribute, use it in basket.tt Test plan: 1 - Create a basket. 2 - Export it in excel. 3 - There's a lot of spaces in Order column and irrelevant 'Add internal note' 4 - Apply patch 5 - Export file. 6 - It's tidier, fewer spaces and no Add/edit note. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 --- Comment #1 from Didier Gautheron <didier.gautheron@biblibre.com> --- Created attachment 114408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114408&action=edit Bug 2740: Basket export cleanup. Remove spaces and irrelevant links. Test plan: 1 - Create a basket 2 - Export it in excel 3 - There's a lot of spaces in Order column and irrelevant 'Add internal note' 4 - Apply patch 5 - Export file 6 - It's tidier, fewer spaces and no useless Add/edit note links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12502 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 [Bug 12502] Add columns for note, order number and ISBN to late orders page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114408|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 119105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119105&action=edit Bug 2740: Basket export cleanup. Remove spaces and irrelevant links. Test plan: 1 - Create a basket 2 - Export it in excel 3 - There's a lot of spaces in Order column and irrelevant 'Add internal note' 4 - Apply patch 5 - Export file 6 - It's tidier, fewer spaces and no useless Add/edit note links https://bugs.koha-community.org/show_bug.cgi?id=27240 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- No more useless notes informations, and less spaces so works fine for me. I just noticed a typo in the patch number (2740 instead of 27240), but I don't know how to correct that. Thank you Didier ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119825&action=edit Bug 27240: Basket export cleanup. Remove spaces and irrelevant links. Test plan: 1 - Create a basket 2 - Export it in excel 3 - There's a lot of spaces in Order column and irrelevant 'Add internal note' 4 - Apply patch 5 - Export file 6 - It's tidier, fewer spaces and no useless Add/edit note links https://bugs.koha-community.org/show_bug.cgi?id=27240 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Séverine Queune from comment #3)
I just noticed a typo in the patch number (2740 instead of 27240), but I don't know how to correct that.
Thanks for noting it - I fixed the bug number in QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There are much more to tidy, but let's call it a first step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- noExport must be on the th, like: <th class="noExport">Actions</th> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No, it's correct - we only want to add the link here, not the column! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #8)
No, it's correct - we only want to add the link here, not the column!
add should read 'hide'! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Text to go in the| |A simple template cleanup release notes| |to improve code legibility | |and remove superfluous | |whitespace from the | |display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|A simple template cleanup |A simple template cleanup release notes|to improve code legibility |to improve code legibility |and remove superfluous |and remove superfluous |whitespace from the |whitespace when exporting |display. |data using the table | |features. Also removes | |links from the exported | |data. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org