[Bug 10130] New: Input fields for branch configuration are too short
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Bug ID: 10130 Summary: Input fields for branch configuration are too short Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de The input fields for branches are rather short and that makes it harder to use the form and to spot typos. To test: Go to Administration > Branches > New/Edit branch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20486&action=edit Bug 10130 - Input fields for branch configuration are too short Most input fields in the library entry form (admin/branches.pl) have no explicit with, so they display with a browser-default width. This patch gives explicit widths to those fields, giving more room for entry. Other fields have been given an explicit width and/or maxwidth according to the database table structure. To test, add or edit a library in Administration -> Libraries and Groups. Form fields should be more comfortable for entry, and add/edit actions should complete correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Campbell Reid-Tait <campbellreidtait@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20486|0 |1 is obsolete| | CC| |campbellreidtait@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Campbell Reid-Tait <campbellreidtait@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Assignee|oleonard@myacpl.org |campbellreidtait@gmail.com --- Comment #2 from Campbell Reid-Tait <campbellreidtait@gmail.com> --- Created attachment 20681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20681&action=edit Signed off patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20681|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20688&action=edit [PASSED QA] Bug 10130 - Input fields for branch configuration are too short Most input fields in the library entry form (admin/branches.pl) have no explicit with, so they display with a browser-default width. This patch gives explicit widths to those fields, giving more room for entry. Other fields have been given an explicit width and/or maxwidth according to the database table structure. To test, add or edit a library in Administration -> Libraries and Groups. Form fields should be more comfortable for entry, and add/edit actions should complete correctly. Signed-off-by: Campbell Reid-Tait <campbellreidtait@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template changes only, works nicely. Tested editing and adding libraries in administration. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we could move the opac info editor field a bit to the right, to match where the other fields begin. But this works nicely and long library names and addresses shouldn't be a problem now :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi@cineca.it --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- I also tested the patch on Windows 7 professional, browsers: Mozilla FF 23, Google Chrome 29 and Explorer 9. For me it's OK. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10130 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org