[Bug 15815] New: improve wording in popup warning when deleting patron from patron-batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Bug ID: 15815 Summary: improve wording in popup warning when deleting patron from patron-batch Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: Heinrich.Hartl@email.de QA Contact: testopia@bugs.koha-community.org Deleting a Patron from a batch the following popup may hold the following text: "Are you sure you want to remove card number(s):1 from this batch?" In the example above however a Patron was chosen for deletion with borrowernumber 2, cardnumber "BB1" which aktuall occupied position 1 in the batch list! Index position (here 1) should not be termed card number. To avoid the incorrect naming the message could be changed.. However I'd prefer to skip this message altogether – do it the unix way: No comment on regular operation! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 62342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62342&action=edit Bug 15815: Reword confirm message when removing patrons from card batch This patch rewords the confirm message when removing patrons from a card batch. From: "Are you sure you want to remove card number(s):1 from this batch?" To: "Are you sure you want to remove the selected patron(s) from this batch?" To test: 1) Go to Tools -> Patron Card Creator -> Manage batches 2) Edit a batch 3) Select one or more patrons and click 'Remove selected patrons' (not individual Delete buttons) 4) Confirm the message is worded better and easier to understand 5) Click OK and confirm the patrons are deleted as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|cnighswonger@foundations.ed |aleisha@catalyst.net.nz |u | CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62342|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62469&action=edit [SIGNED-OFF] Bug 15815: Reword confirm message when removing patrons from card batch This patch rewords the confirm message when removing patrons from a card batch. From: "Are you sure you want to remove card number(s):1 from this batch?" To: "Are you sure you want to remove the selected patron(s) from this batch?" To test: 1) Go to Tools -> Patron Card Creator -> Manage batches 2) Edit a batch 3) Select one or more patrons and click 'Remove selected patrons' (not individual Delete buttons) 4) Confirm the message is worded better and easier to understand 5) Click OK and confirm the patrons are deleted as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |unspecified CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, labels and patron cards scripts are very tied, I think we should apply the same change to labels/label-edit-batch.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62469|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62602&action=edit Bug 15815: Reword confirm message when removing patrons from card batch This patch rewords the confirm message when removing patrons from a card batch. From: "Are you sure you want to remove card number(s):1 from this batch?" To: "Are you sure you want to remove the selected patron(s) from this batch?" To test: 1) Go to Tools -> Patron Card Creator -> Manage batches 2) Edit a batch 3) Select one or more patrons and click 'Remove selected patrons' (not individual Delete buttons) 4) Confirm the message is worded better and easier to understand 5) Click OK and confirm the patrons are deleted as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|improve wording in popup |Improve wording in popup |warning when deleting |warning when deleting |patron from patron-batch |patron from patron-batch Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. Wording change - tiny enough for backporting :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #6)
This patch has been pushed to 16.11.x and will be in 16.11.08.
Wording change - tiny enough for backporting :)
ditto ^ :0) Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org