[Bug 28453] New: Update pagination subroutine to generate Bootstrap markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Bug ID: 28453 Summary: Update pagination subroutine to generate Bootstrap markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Many places in Koha use a subroutine in Output.pm, "pagination_bar" to generate pagination menus. These end up looking very different from some other pagination menus in Koha, particularly the one on the catalog search results page. Bug 18008 proposed to move more of the markup-generation into the template, which I think is the right solution. That bug has been stalled for a while now, so I'd like to make an interim change until that can get some attention again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125849&action=edit Bug 28453: Update pagination subroutine to generate Bootstrap markup This patch modifies Output.pm to change the HTML it generates when creating pagination bars. The changes allow the pagination menu to be styled like Bootstrap pagination, making them consistent with the pagination on catalog search results. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages where the pagination_bar subroutine is called: - Administration -> Record matching rules. - Authorities -> Authority search results. - Cataloging -> Cataloging search results. - Cataloging -> MARC Editor -> Edit tag which is configured to use the unimarc_field_210c value builder. - Reports -> Saved SQL reports -> Results. - Tools -> Comments. - Lists -> List contents. The pagination bar markup was removed from the templates for these pages because it wasn't being used: - Administration -> Patron attribute types. - Tools -> Tags. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind <david@davidnind.com> --- Things noted from testing: - Administration -> Record matching rules: with 30 entries the pagination bar didn't appear (both before and after the patch was applied) - I'm assuming it should have kicked in at 20? - Cataloging -> MARC Editor -> Tag using unimarc_field_210c value builder: this worked after patch applied (before the patch was applied I couldn't get any results). However, when you click on the controls for anything after page 1, it says no results (even when there are more than 20 results). - Tools > Comments: The pagination only appears at the bottom - should this be added at the top as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125849|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126836&action=edit Bug 28453: Update pagination subroutine to generate Bootstrap markup This patch modifies Output.pm to change the HTML it generates when creating pagination bars. The changes allow the pagination menu to be styled like Bootstrap pagination, making them consistent with the pagination on catalog search results. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages where the pagination_bar subroutine is called: - Authorities -> Authority search results. - Cataloging -> Cataloging search results. - Cataloging -> MARC Editor -> Edit tag which is configured to use the unimarc_field_210c value builder. - Reports -> Saved SQL reports -> Results. - Tools -> Comments. - Lists -> List contents. The pagination bar markup was removed from the templates for these pages because it wasn't being used: - Administration -> Patron attribute types. - Administration -> Record matching rules. - Tools -> Tags. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126837&action=edit Bug 28453: DO NOT PUSH - FOR MARC21 TESTING ONLY This patch changes the authority type searched by the UNIMARC 210$c plugin from EDITORS to PERSO_NAME in order to try to make it more easily testable by MARC21 users. FOR TESTING ONLY!! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #2)
- Administration -> Record matching rules
This was an error in my test plan. It is one of the pages which had unused pagination markup in the template.
- Cataloging -> MARC Editor -> Tag using unimarc_field_210c value builder: this worked after patch applied
I'm glad you caught this because I made a "temporary" change which ended up in the patch. In order to test using my MARC21 data I altered the search to use PERSO_NAME instead of EDITORS. This is now in the DO NOT PUSH patch which will enable testing of the pagination bar if you have PERSO_NAME authorities.
- Tools > Comments: The pagination only appears at the bottom - should this be added at the top as well?
I thought the same, but I didn't want to make any additions in this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126836|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 126845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126845&action=edit Bug 28453: Update pagination subroutine to generate Bootstrap markup This patch modifies Output.pm to change the HTML it generates when creating pagination bars. The changes allow the pagination menu to be styled like Bootstrap pagination, making them consistent with the pagination on catalog search results. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages where the pagination_bar subroutine is called: - Authorities -> Authority search results. - Cataloging -> Cataloging search results. - Cataloging -> MARC Editor -> Edit tag which is configured to use the unimarc_field_210c value builder. - Reports -> Saved SQL reports -> Results. - Tools -> Comments. - Lists -> List contents. The pagination bar markup was removed from the templates for these pages because it wasn't being used: - Administration -> Patron attribute types. - Administration -> Record matching rules. - Tools -> Tags. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126837|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 126846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126846&action=edit Bug 28453: DO NOT PUSH - FOR MARC21 TESTING ONLY This patch changes the authority type searched by the UNIMARC 210$c plugin from EDITORS to PERSO_NAME in order to try to make it more easily testable by MARC21 users. FOR TESTING ONLY!! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #8 from David Nind <david@davidnind.com> --- Thanks Owen for fixing and clarifying - signed off now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but I believe there are some translation issues hiding here. In Output.pm: + . '<i class="fa fa-fw fa-angle-double-left"></i> First' . '</a></li>'; + . '" rel="prev">' . '<i class="fa fa-fw fa-angle-left"></i> Previous' . '</a></li>'; . '" rel="next">' . 'Next <i class="fa fa-fw fa-angle-right"></i>' . '</a></li>'; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127210&action=edit Bug 28453: (follow-up) Make pagination labels translatable This patch moves the English strings out of Output.pm and adds classes to the pagination markup which can be used as hooks for JavaScript. The global JS include is modified to look for these hooks and add text labels to the links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Owen, it seems that you needs to adjust the two occurrences at the OPAC as well: opac/opac-authorities-home.pl: pagination_bar => pagination_bar( opac/opac-shelves.pl: pagination_bar => pagination_bar( opac/opac-shelves.pl: pagination_bar => pagination_bar( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126845|0 |1 is obsolete| | Attachment #126846|0 |1 is obsolete| | Attachment #127210|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171076&action=edit Bug 28453: Update pagination subroutine to generate Bootstrap markup This patch modifies Output.pm to change the HTML it generates when creating pagination bars. The changes allow the pagination menu to be styled like Bootstrap pagination, making them consistent with the pagination on catalog search results. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages where the pagination_bar subroutine is called: - Authorities -> Authority search results. - Cataloging -> Cataloging search results. - Cataloging -> MARC Editor -> Edit tag which is configured to use the unimarc_field_210c value builder. - Reports -> Saved SQL reports -> Results. - Tools -> Comments. - Lists -> List contents. The pagination bar markup was removed from the templates for these pages because it wasn't being used: - Administration -> Patron attribute types. - Administration -> Record matching rules. - Tools -> Tags. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171077&action=edit Bug 28453: DO NOT PUSH - FOR MARC21 TESTING ONLY This patch changes the authority type searched by the UNIMARC 210$c plugin from EDITORS to PERSO_NAME in order to try to make it more easily testable by MARC21 users. FOR TESTING ONLY!! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171078&action=edit Bug 28453: (follow-up) Make pagination labels translatable This patch moves the English strings out of Output.pm and adds classes to the pagination markup which can be used as hooks for JavaScript. The global JS include is modified to look for these hooks and add text labels to the links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #15 from David Nind <david@davidnind.com> --- I have tested again. The only issue I'm having is with the unimarc_field_210c value builder. I can't get it to generate any results, both before and after the patch. I ended up testing on a UNIMARC instance without the DO NOT PUSH patch: 1. Edit KTD .env file and change KOHA_MARC_FLAVOUR=unimarc 2. Start up KTD as normal: ktd up 3. Change the default framework so that 210$c uses the unimarc_field_210c.pl value builder (in the default KTD setup it is using unimarc_field_210c-bis.pl - this is mapped to biblioitems.publishercode) 4. Edit any record 5. Select the tag editor for 210$c 6. Try several combinations to get some search results (I used search terms that worked with normal authority searching) - I had no luck. Examples . a . c . france . Catel Maybe this is already broken or not working as it should?
From previous testing (comment #2) it looks like it did work.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 171150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171150&action=edit Pagination bar screenshots - after the patches (PDF) When testing, I noticed some inconsistencies in how the pagination is displayed - compared to the standard catalog search results. I've attached a document with screenshots after the patches are applied, for easier comparison. For a future bug. - Standard catalog search results: . The pagination bar is displayed after the action buttons, and above the table of search results - in the section with the white background. - Authority record search results: . The pagination bar is displayed in the section with the white background, above the table of search results. . The number of search results is displayed after the pagination bar - "Results 1 to 20 of 246". - Cataloguing search results: . The pagination bar is displayed in the section with the white background, above the table of search results. . The number of results is displayed before the pagination bar - "74 result(s) found in catalog, 0 result(s) found in reservoir". - Cataloguing - unimarc_field_210c value builder: . Not getting any results before and after the patch. - Saved SQL reports - results from running a report: . This is for the pagination bar for the results of a report (the list of saved reports uses DataTables). . The pagination bar is displayed in the section with the white background, above the table of search results. . The number of results is displayed before the pagination bar - "Total number of results: 863 (20 shown) ". - Comments: . As noted in comment #2, the pagination bar only appears at the bottom of the list. . Tab headings are in plain text (Approved comments, Comments awaiting moderation) - created bug 37859 - Lists: . The pagination bar is displayed above the action buttons, outside the section with the white background. . The number of results is displayed before the pagination bar - "This list contains 25 titles". - Markup removed, as not being used: . Patron attribute search types: before and after the patch using DataTables(?) . Record matching results: not using any pagination, tested with 21 rules . Tags: before and after the patch using DataTables(?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Bug 28453 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171076|0 |1 is obsolete| | Attachment #171077|0 |1 is obsolete| | Attachment #171078|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175272&action=edit Bug 28453: Update pagination subroutine to generate Bootstrap markup This patch modifies Output.pm to change the HTML it generates when creating pagination bars. The changes allow the pagination menu to be styled like Bootstrap pagination, making them consistent with the pagination on catalog search results. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages where the pagination_bar subroutine is called: - Authorities -> Authority search results. - Cataloging -> Cataloging search results. - Cataloging -> MARC Editor -> Edit tag which is configured to use the unimarc_field_210c value builder. - Reports -> Saved SQL reports -> Results. - Tools -> Comments. - Lists -> List contents. The pagination bar markup was removed from the templates for these pages because it wasn't being used: - Administration -> Patron attribute types. - Administration -> Record matching rules. - Tools -> Tags. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175273&action=edit Bug 28453: DO NOT PUSH - FOR MARC21 TESTING ONLY This patch changes the authority type searched by the UNIMARC 210$c plugin from EDITORS to PERSO_NAME in order to try to make it more easily testable by MARC21 users. FOR TESTING ONLY!! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175274&action=edit Bug 28453: (follow-up) Make pagination labels translatable This patch moves the English strings out of Output.pm and adds classes to the pagination markup which can be used as hooks for JavaScript. The global JS include is modified to look for these hooks and add text labels to the links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175272|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 175279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175279&action=edit Bug 28453: Update pagination subroutine to generate Bootstrap markup This patch modifies Output.pm to change the HTML it generates when creating pagination bars. The changes allow the pagination menu to be styled like Bootstrap pagination, making them consistent with the pagination on catalog search results. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages where the pagination_bar subroutine is called: - Authorities -> Authority search results. - Cataloging -> Cataloging search results. - Cataloging -> MARC Editor -> Edit tag which is configured to use the unimarc_field_210c value builder. - Reports -> Saved SQL reports -> Results. - Tools -> Comments. - Lists -> List contents. The pagination bar markup was removed from the templates for these pages because it wasn't being used: - Administration -> Patron attribute types. - Administration -> Record matching rules. - Tools -> Tags. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175273|0 |1 is obsolete| | --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 175280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175280&action=edit Bug 28453: DO NOT PUSH - FOR MARC21 TESTING ONLY This patch changes the authority type searched by the UNIMARC 210$c plugin from EDITORS to PERSO_NAME in order to try to make it more easily testable by MARC21 users. FOR TESTING ONLY!! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175274|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 175281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175281&action=edit Bug 28453: (follow-up) Make pagination labels translatable This patch moves the English strings out of Output.pm and adds classes to the pagination markup which can be used as hooks for JavaScript. The global JS include is modified to look for these hooks and add text labels to the links. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement updates release notes| |how pagination bars are | |generated and displayed in | |the staff interface for | |these areas, so that they | |are consistent with the | |pagination for catalog | |search results: | |- | |Authorities > Authority | |search results | |- Cataloging | |> Cataloging search results | |- Cataloging > MARC Editor | |> Tags that uses the | |unimarc_field_210c value | |builder | |- Reports > Saved | |SQL reports > Report | |results | |- Tools > Comments | |- Lists > List contents | | | |The pagination bar markup | |was removed from the | |templates for these pages | |because it wasn't being | |used: | |- Administration > | |Patron attribute types | |- | |Administration > Record | |matching rules | |- Tools > | |Tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Is this change in the first patch expected? - <input type="hidden" name="authtypecode" value="PERSO_NAME" /> + <input type="hidden" name="authtypecode" value="EDITORS" /> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- What about the difference between DT's pagination and those pagination menus? Shouldn't we style them identically? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175279|0 |1 is obsolete| | Attachment #175280|0 |1 is obsolete| | Attachment #175281|0 |1 is obsolete| | --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176663&action=edit Bug 28453: Update pagination subroutine to generate Bootstrap markup This patch modifies Output.pm to change the HTML it generates when creating pagination bars. The changes allow the pagination menu to be styled like Bootstrap pagination, making them consistent with the pagination on catalog search results. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages where the pagination_bar subroutine is called: - Authorities -> Authority search results. - Cataloging -> Cataloging search results. - Cataloging -> MARC Editor -> Edit tag which is configured to use the unimarc_field_210c value builder. - Reports -> Saved SQL reports -> Results. - Tools -> Comments. - Lists -> List contents. The pagination bar markup was removed from the templates for these pages because it wasn't being used: - Administration -> Patron attribute types. - Administration -> Record matching rules. - Tools -> Tags. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176664&action=edit Bug 28453: DO NOT PUSH - FOR MARC21 TESTING ONLY This patch changes the authority type searched by the UNIMARC 210$c plugin from EDITORS to PERSO_NAME in order to try to make it more easily testable by MARC21 users. FOR TESTING ONLY!! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176665&action=edit Bug 28453: (follow-up) Make pagination labels translatable This patch moves the English strings out of Output.pm and adds classes to the pagination markup which can be used as hooks for JavaScript. The global JS include is modified to look for these hooks and add text labels to the links. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #23)
Is this change in the first patch expected?
No that was included by mistake. I have re-uploaded the patches without that change. (In reply to Jonathan Druart from comment #24)
What about the difference between DT's pagination and those pagination menus?
I think that is a question that requires more feedback from users. My rationale for having them be different is that the controls trigger very different actions: The Bootstrap-styled links will cause a new page to load. The DT controls only affect the table. In my opinion it is correct that users have a clue about this difference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176663|0 |1 is obsolete| | Attachment #176665|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176666&action=edit Bug 28453: Update pagination subroutine to generate Bootstrap markup This patch modifies Output.pm to change the HTML it generates when creating pagination bars. The changes allow the pagination menu to be styled like Bootstrap pagination, making them consistent with the pagination on catalog search results. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages where the pagination_bar subroutine is called: - Authorities -> Authority search results. - Cataloging -> Cataloging search results. - Cataloging -> MARC Editor -> Edit tag which is configured to use the unimarc_field_210c value builder. - Reports -> Saved SQL reports -> Results. - Tools -> Comments. - Lists -> List contents. The pagination bar markup was removed from the templates for these pages because it wasn't being used: - Administration -> Patron attribute types. - Administration -> Record matching rules. - Tools -> Tags. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176667&action=edit Bug 28453: (follow-up) Make pagination labels translatable This patch moves the English strings out of Output.pm and adds classes to the pagination markup which can be used as hooks for JavaScript. The global JS include is modified to look for these hooks and add text labels to the links. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176664|0 |1 is obsolete| | Attachment #176666|0 |1 is obsolete| | Attachment #176667|0 |1 is obsolete| | --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177846&action=edit Bug 28453: DO NOT PUSH - FOR MARC21 TESTING ONLY This patch changes the authority type searched by the UNIMARC 210$c plugin from EDITORS to PERSO_NAME in order to try to make it more easily testable by MARC21 users. FOR TESTING ONLY!! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177847&action=edit Bug 28453: Update pagination subroutine to generate Bootstrap markup This patch modifies Output.pm to change the HTML it generates when creating pagination bars. The changes allow the pagination menu to be styled like Bootstrap pagination, making them consistent with the pagination on catalog search results. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages where the pagination_bar subroutine is called: - Authorities -> Authority search results. - Cataloging -> Cataloging search results. - Cataloging -> MARC Editor -> Edit tag which is configured to use the unimarc_field_210c value builder. - Reports -> Saved SQL reports -> Results. - Tools -> Comments. - Lists -> List contents. The pagination bar markup was removed from the templates for these pages because it wasn't being used: - Administration -> Patron attribute types. - Administration -> Record matching rules. - Tools -> Tags. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177848&action=edit Bug 28453: (follow-up) Make pagination labels translatable This patch moves the English strings out of Output.pm and adds classes to the pagination markup which can be used as hooks for JavaScript. The global JS include is modified to look for these hooks and add text labels to the links. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- git bisect blames this commit on breaking the t/db_dependent/selenium/regressions.t test: hadev-koha@kohadevbox:koha((d734a119c2e...)|BISECTING)$ git bisect good 2685ac2c6ca86621790ee2b00f36959a65df3bc0 is the first bad commit commit 2685ac2c6ca86621790ee2b00f36959a65df3bc0 Author: Owen Leonard <oleonard@myacpl.org> Date: Fri Jun 14 18:06:15 2024 +0000 Bug 28453: Update pagination subroutine to generate Bootstrap markup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179092&action=edit Bug 28453: Adjust OPAC pagination -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- This patch fixes the Selenium failure (regressions.t) # Failed test 'XSS vulnerabilities in pagination' # at t/db_dependent/selenium/regressions.t line 304. Error while executing command: no such element: Unable to locate element: //div[@class="pages"]/span[@class="currentPage"]/following-sibling::a at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. As well as adjusting the OPAC templates using pagination_bar. I don't understand why the original patch added spaces within the div.pages, but I decided to apply the same changes for this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed the follow-up to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #39 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org