[Bug 12069] New: If you access members/mod_debarment.pl when logged out you are redirected to OPAC login
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 Bug ID: 12069 Summary: If you access members/mod_debarment.pl when logged out you are redirected to OPAC login Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /members/mod_debarment.pl?borrowernumber=XX&borrower_d ebarment_id=XX&action=del OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com I had a patron account open, viewing some existing restrictions on the patrons account. My session had timed out, and when I clicked the link to remove a restriction I was redirected to an OPAC login page instead of the staff client one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- I confirmed this in master. This was introduced in bug 2720. I don't think it existed in 3.12, since the file doesn't exist in origin/3.12.x. Any patch should also work in 3.14.x, since mod_debarment.pl has not been modified since then. Looks like members/mod_debarment.pl does not pass 'intranet' as the 4th parameter to the checkauth call. Are you doing a patch for this, Owen? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. Tompsett from comment #1)
Are you doing a patch for this, Owen?
The fact that the bug is assigned to me and the status is "ASSIGNED" signals my intention to do a patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27022&action=edit Bug 12069 - If you access members/mod_debarment.pl when logged out you are redirected to OPAC login members/mod_debarment.pl's call to checkauth should pass 'intranet' so that if the user happens to be logged out they will be redirected to the staff client login form. To test, apply the patch and log in to the staff client: - Add a restriction to a patron's account. - View the restrictions tab on the patron's account. You should see the restriction and a "Remove" link for that restriction. - In another tab, log out of the staff client. - In the first tab, click the "Remove" link. You should be redirected to the staff client login page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27022|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 27028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27028&action=edit [SIGNED OFF] Bug 12069 - If you access members/mod_debarment.pl when logged out you are redirected to OPAC login members/mod_debarment.pl's call to checkauth should pass 'intranet' so that if the user happens to be logged out they will be redirected to the staff client login form. To test, apply the patch and log in to the staff client: - Add a restriction to a patron's account. - View the restrictions tab on the patron's account. You should see the restriction and a "Remove" link for that restriction. - In another tab, log out of the staff client. - In the first tab, click the "Remove" link. You should be redirected to the staff client login page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- This also applies cleanly to 3.14.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27028|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27052&action=edit [PASSED QA] Bug 12069 - If you access members/mod_debarment.pl when logged out you are redirected to OPAC login members/mod_debarment.pl's call to checkauth should pass 'intranet' so that if the user happens to be logged out they will be redirected to the staff client login form. To test, apply the patch and log in to the staff client: - Add a restriction to a patron's account. - View the restrictions tab on the patron's account. You should see the restriction and a "Remove" link for that restriction. - In another tab, log out of the staff client. - In the first tab, click the "Remove" link. You should be redirected to the staff client login page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good catch! Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org