https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16074 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49156&action=edit Bug 16074: Making frequencies actions buttons To test: 1) Go to Serials -> Manage frequencies 2) Confirm that buttons 'Modify' and 'Delete' show as buttons and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16074 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16074 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49158|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49169&action=edit [SIGNED-OFF] Bug 16074: Making frequencies actions buttons To test: 1) Go to Serials -> Manage frequencies 2) Confirm that buttons 'Modify' and 'Delete' show as buttons and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap 4) Confirm that column heading is now 'Actions' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16074 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49169|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49199&action=edit Bug 16074: Making frequencies actions buttons To test: 1) Go to Serials -> Manage frequencies 2) Confirm that buttons 'Modify' and 'Delete' show as buttons and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap 4) Confirm that column heading is now 'Actions' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons look correct and work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16074 --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Jonathan Druart from comment #5)

Should not we replace "Modify" with "Edit"?

I've always thought that 'Modify' should be 'Edit' when making patches like this but I was never sure if 'Modify' was there for a reason or not. I can easily change them all though. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16074 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49199|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49285&action=edit Bug 16074: Making frequencies actions buttons EDIT: Changing 'Modify' to 'Edit' To test: 1) Go to Serials -> Manage frequencies 2) Confirm that links 'Modify' and 'Delete' show as buttons ('Edit' instead of 'Modify') and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap 4) Confirm that column heading is now 'Actions' 5) Confirm that when you click on Edit for any frequency, the title of the page is now 'Edit frequency' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons look correct and work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16074 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49285|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49297&action=edit Bug 16074: Making frequencies actions buttons To test: 1) Go to Serials -> Manage frequencies 2) Confirm that buttons 'Modify' and 'Delete' show as buttons and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap 4) Confirm that column heading is now 'Actions' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons look correct and work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16074 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49298&action=edit Bug 16074: Replace Modify with Edit Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16074 --- Comment #11 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Jonathan Druart from comment #10)

Aleisha, when a bug report has passed qa, please do not modify patches which have been signed off/QAed. The best is to provide a follow-up: the changes are easier to read and you won't need to request another signoff.

I was wondering about that! Thanks for letting me know :) -- You are receiving this mail because: You are watching all bug changes.