[Bug 23151] New: Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Bug ID: 23151 Summary: Patron self modification sends null dateofbirth Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- To Test: - confirm OPACPatronDetails is set to Allow - log into opac - submit change request without changing date of birth - look at change request on staff, see that request includes removal of date of birth I've confirm this bug occurs regardless of whether or not dateofbirth is included in either PatronSelfRegistrationBorrowerMandatoryField or BorrowerUnwantedField. Bug exists in 18.11.06 but not in 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker CC| |nick@bywatersolutions.com Depends on| |11853 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Caused by commit 6692800794cbf403e8be8c8062608b60148c0d56 Raising severity as can result in data loss Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11853 [Bug 11853] Cannot clear date of birth via OPAC patron update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90764&action=edit Bug 23151: Properly clear/not clear date of birth. The problem is caused by how change is stored: {changed value} || NULL. NULL means no change, but in the case of clearing a date of birth one wants to set it to NULL, which is indistinguishable from the no change value. By adding a DUMMY_DATE '9999-12-31', and using it as an intermediate check, we can set the value to NULL. This required storing the DUMMY_DATE as the change value, then in the case of date of birth displaying blank when listing the changes, and saving undef when the changes are stored. TEST PLAN --------- 0) running this test plan without the patch results in bad data. 1) Ensure the Global System Preference OPACPatronDetails is set to Allow. 2) reset_all in the kohadevbox. 3) log into admin/admin. 4) open up localhost:8080 in one tab, and localhost:8081 in another. 5) In the opac tab, click on the user name, and then the 'your personal details' tab. 5a) Set the first name, so it won't complain. 6) Set the salutation to Mr. and the birth date to any date. 7) scroll down and submit 8) In the staff tab, click home 9) click on the 'patrons requesting modifications' at the bottom of the screen. -- you should see the changes you just made. 10) click the 'Approve' radio button, and click Submit. 11) In the opac tab, click on the 'your personal details' tab. -- the values should be as expected 12) Set the salutation to blank and leave the birth date alone. 13) scroll down and submit 14) repeat steps 8-11. -- the values should be as expected 15) Clear the birth date 16) scroll down and submit 17) repeat steps 8-11. 18) Set the salutation to Mr. and leave the birth date blank. 19) scroll down and submit. 20) repeat steps 8-11. 21) Repeat steps 6-11 for good measure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Assignee|oleonard@myacpl.org |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is this a bug in master as well or a problem with the backport? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #3)
Is this a bug in master as well or a problem with the backport?
Confirmed on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90769&action=edit Bug 23151: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have tried to suggest a counter patch as I do not like the "dummy value", but failed. However I wrote tests before, and they do not pass. Also, a lot of warnings are generated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90764|0 |1 is obsolete| | Attachment #90769|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90795&action=edit Bug 23151: Properly clear/not clear date of birth. The problem is caused by how change is stored: {changed value} || NULL. NULL means no change, but in the case of clearing a date of birth one wants to set it to NULL, which is indistinguishable from the no change value. By adding a DUMMY_DATE '9999-12-31', and using it as an intermediate check, we can set the value to NULL. This required storing the DUMMY_DATE as the change value, then in the case of date of birth displaying blank when listing the changes, and saving undef when the changes are stored. TEST PLAN --------- 0) running this test plan without the patch results in bad data. 1) Ensure the Global System Preference OPACPatronDetails is set to Allow. 2) reset_all in the kohadevbox. 3) log into admin/admin. 4) open up localhost:8080 in one tab, and localhost:8081 in another. 5) In the opac tab, click on the user name, and then the 'your personal details' tab. 5a) Set the first name, so it won't complain. 6) Set the salutation to Mr. and the birth date to any date. 7) scroll down and submit 8) In the staff tab, click home 9) click on the 'patrons requesting modifications' at the bottom of the screen. -- you should see the changes you just made. 10) click the 'Approve' radio button, and click Submit. 11) In the opac tab, click on the 'your personal details' tab. -- the values should be as expected 12) Set the salutation to blank and leave the birth date alone. 13) scroll down and submit 14) repeat steps 8-11. -- the values should be as expected 15) Clear the birth date 16) scroll down and submit 17) repeat steps 8-11. 18) Set the salutation to Mr. and leave the birth date blank. 19) scroll down and submit. 20) repeat steps 8-11. 21) Repeat steps 6-11 for good measure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90796&action=edit Bug 23151: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90795|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 90797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90797&action=edit Bug 23151: Properly clear/not clear date of birth. The problem is caused by how change is stored: {changed value} || NULL. NULL means no change, but in the case of clearing a date of birth one wants to set it to NULL, which is indistinguishable from the no change value. By adding a DUMMY_DATE '9999-12-31', and using it as an intermediate check, we can set the value to NULL. This required storing the DUMMY_DATE as the change value, then in the case of date of birth displaying blank when listing the changes, and saving undef when the changes are stored. TEST PLAN --------- 0) running this test plan without the patch results in bad data. 1) Ensure the Global System Preference OPACPatronDetails is set to Allow. 2) reset_all in the kohadevbox. 3) log into admin/admin. 4) open up localhost:8080 in one tab, and localhost:8081 in another. 5) In the opac tab, click on the user name, and then the 'your personal details' tab. 5a) Set the first name, so it won't complain. 6) Set the salutation to Mr. and the birth date to any date. 7) scroll down and submit 8) In the staff tab, click home 9) click on the 'patrons requesting modifications' at the bottom of the screen. -- you should see the changes you just made. 10) click the 'Approve' radio button, and click Submit. 11) In the opac tab, click on the 'your personal details' tab. -- the values should be as expected 12) Set the salutation to blank and leave the birth date alone. 13) scroll down and submit 14) repeat steps 8-11. -- the values should be as expected 15) Clear the birth date 16) scroll down and submit 17) repeat steps 8-11. 18) Set the salutation to Mr. and leave the birth date blank. 19) scroll down and submit. 20) repeat steps 8-11. 21) Repeat steps 6-11 for good measure. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90796|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 90798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90798&action=edit Bug 23151: Add tests Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90798|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 90799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90799&action=edit Bug 23151: Add tests Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Ed Veal <eveal@mckinneytexas.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90797|0 |1 is obsolete| | Attachment #90799|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90805&action=edit Bug 23151: Modifiy database structure This modifies a fresh install structure, and provides an atomic update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90806&action=edit Bug 23151: Schema changes It is best to regenerate these from scratch. On a kohadevbox: $ misc/devel/update_dbix_class_files.pl --db_name=koha_kohadev --db_user=koha_kohadev --db_passwd=password -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90807&action=edit Bug 23151: Tweak to use the new database structure This will use changed_fields to know whether a borrower field is actually modified. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90808&action=edit Bug 23151: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90809&action=edit Bug 23151: (follow-up) tweaked tests This forces the tests to use the new changed_fields field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal@mckinneytexas.org, | |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- Sorry, I forgot to change the status before Lucas and Ed signed off. DOH! Feel free to try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Mark, what about the update process? We need to have an atomic update file and update the existing rows in DB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- It's in the first patch as a .perl, Jonathan. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #19)
It's in the first patch as a .perl, Jonathan. :)
Sorry, I missed it. However the column need to be set for existing installations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91070&action=edit Bug 23151: (QA follow-up) Fix atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90805|0 |1 is obsolete| | Attachment #90806|0 |1 is obsolete| | Attachment #90807|0 |1 is obsolete| | Attachment #90808|0 |1 is obsolete| | Attachment #90809|0 |1 is obsolete| | Attachment #91070|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91071&action=edit Bug 23151: Modifiy database structure This modifies a fresh install structure, and provides an atomic update. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91072&action=edit Bug 23151: Schema changes It is best to regenerate these from scratch. On a kohadevbox: $ misc/devel/update_dbix_class_files.pl --db_name=koha_kohadev --db_user=koha_kohadev --db_passwd=password Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91073&action=edit Bug 23151: Tweak to use the new database structure This will use changed_fields to know whether a borrower field is actually modified. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91074&action=edit Bug 23151: Add tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91075&action=edit Bug 23151: (follow-up) tweaked tests This forces the tests to use the new changed_fields field. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91076&action=edit Bug 23151: (QA follow-up) Fix atomic update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #20)
However the column need to be set for existing installations.
Still valid, I do not think we should push it without updating the existing entries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Margaret <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret@bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Failed QA |Signed Off --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #28)
(In reply to Jonathan Druart from comment #20)
However the column need to be set for existing installations.
Still valid, I do not think we should push it without updating the existing entries.
I don't believe this update is even possible given we don't have the data we'd need to fix it, and if we did we wouldn't have this bug to begin with ;) In addition, this is a serious problem that is happening *now*. I think we need to get this patched post-haste and we can solve this db update issue on followup report. Right now libraries are losing data that they wouldn't not have lost if this hadn't been set to failed qa. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #30 from Liz Rea <wizzyrea@gmail.com> --- Hi Jonathan, This is causing pretty severe data loss that affects libraries ability to do things like change patron categories based on birth date - if a patron loses their DOB, that process can no longer happen. I propose we let this code through to fix the potential for data loss, and follow it up with a solution that potentially checks the pending modifications at upgrade time for DOB, and if the patron has one, insert that into the pending modification assuming that the patron didn't mean to null their birthdate. This could, of course, err on the side of the library (the patron *might* have meant to delete their DOB, yes. They can always process that modification again if they find it to be incorrect.) This really is a serious problem for libraries with automatic age based category management, and I don't think we can let it sit. The current solution fixes the data loss problem, and there will be a follow up to fix the currently pending at time of upgrade modifications, but I don't see why they have to go in together. I'm happy to file another bug for that 2nd part, if you like, or we can do it on this bug, but I do feel this bug needs to get moving on through. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Brittany <bhenry@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bhenry@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #31 from Ed Veal <eveal@mckinneytexas.org> --- I agree with Liz, if we have a patch to solve the problem moving forward let's get that out there. As we address the issues around the data loss. Ed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91071|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91614&action=edit Bug 23151: Modifiy database structure This modifies a fresh install structure, and provides an atomic update. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91072|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91615&action=edit Bug 23151: Schema changes It is best to regenerate these from scratch. On a kohadevbox: $ misc/devel/update_dbix_class_files.pl --db_name=koha_kohadev --db_user=koha_kohadev --db_passwd=password Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91073|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91616&action=edit Bug 23151: Tweak to use the new database structure This will use changed_fields to know whether a borrower field is actually modified. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91074|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91617&action=edit Bug 23151: Add tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91075|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91618&action=edit Bug 23151: (follow-up) tweaked tests This forces the tests to use the new changed_fields field. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91076|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91619&action=edit Bug 23151: (QA follow-up) Fix atomic update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91620&action=edit Bug 23151: (QA follow-up) Remove debug leftover Removes: Running... Running... Ran Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #41 from Ed Veal <eveal@mckinneytexas.org> --- Great work folks, can this be back ported for those of us that need the fix now? Ed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #42 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #43 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23428 [Bug 23428] Self registration with a verification by email is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #44 from Liz Rea <wizzyrea@gmail.com> --- It appears this patch isn't commpatible with hiding the date of birth using PatronSelfModificationBorrowerUnwantedField - if the field isn't on the screen, it's still going to blank the DOB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23431 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #29)
(In reply to Jonathan Druart from comment #28)
(In reply to Jonathan Druart from comment #20)
However the column need to be set for existing installations.
Still valid, I do not think we should push it without updating the existing entries.
I don't believe this update is even possible given we don't have the data we'd need to fix it, and if we did we wouldn't have this bug to begin with ;)
In addition, this is a serious problem that is happening *now*. I think we need to get this patched post-haste and we can solve this db update issue on followup report. Right now libraries are losing data that they wouldn't not have lost if this hadn't been set to failed qa.
% git checkout before these patches % Create patron's modifications % git checkout master % Approve the patron's modifications => The modifications are lost. So we replaced a data lost, with another... That's why I was insisting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.02,18.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23579 [Bug 23579] error during web install: 'changed_fields' can't have a default value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #46 from Christopher Brannon <cbrannon@cdalibrary.org> --- This bug seems to be back in 19.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Christopher Brannon from comment #46)
This bug seems to be back in 19.11!
Can you please file a new bug with a link to this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Christopher Brannon from comment #46)
This bug seems to be back in 19.11!
FYI, I was unable to reproduce on master. Will try 19.11 next. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #48)
(In reply to Christopher Brannon from comment #46)
This bug seems to be back in 19.11!
FYI, I was unable to reproduce on master. Will try 19.11 next.
Unable to reproduce on 19.11.x either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #49)
(In reply to Kyle M Hall from comment #48)
(In reply to Christopher Brannon from comment #46)
This bug seems to be back in 19.11!
FYI, I was unable to reproduce on master. Will try 19.11 next.
Unable to reproduce on 19.11.x either.
Found it! This bug *requires* dateofbirth in BorrowerUnwantedField which is clearly *not* the same as this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25769 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org