[Bug 12841] New: aqorders fields should not be mapped
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Bug ID: 12841 Summary: aqorders fields should not be mapped Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 5336 introduced some code which should have been introduced by bug 7294. Since the idea behind bug 7294 has been abandoned (map the aqorders fields), the code can be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |12826 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31245&action=edit Bug 12841: aqorders fields should not be mapped Bug 5336 introduced some code which should have been introduced by bug 7294. Since the idea behind bug 7294 has been abandoned (map the aqorders fields), the code can be removed. Test plan: Verify that Koha does not allow you to map the aqorders fields with a MARC subfield. Verify there is no regression on adding/updating an order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31245|0 |1 is obsolete| | CC| |z.tajoli@cineca.it --- Comment #2 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 31573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31573&action=edit sign-off for patch No problems fund on orders with this patch. Test OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31573|0 |1 is obsolete| | --- Comment #3 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 31576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31576&action=edit [SIGN_OFF] Aqorders fields should not be mapped -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31576|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31737&action=edit [PASSED QA] Bug 12841: aqorders fields should not be mapped Bug 5336 introduced some code which should have been introduced by bug 7294. Since the idea behind bug 7294 has been abandoned (map the aqorders fields), the code can be removed. Test plan: Verify that Koha does not allow you to map the aqorders fields with a MARC subfield. Verify there is no regression on adding/updating an order. Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.01 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org