[Bug 15979] New: Use Font Awesome icons subscription deletion confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Bug ID: 15979 Summary: Use Font Awesome icons subscription deletion confirmation dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-detail.pl?subscript ionid=X&op=del OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 15785 If you try to delete a subscription which has not expired or which has linked issues or items you are presented with a confirmation dialog. This dialog should use Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48697&action=edit Bug 15979 - Use Font Awesome icons subscription deletion confirmation dialog When deleting a subscription which has not expired or which has linked issues or items, a dialog asks for confirmation. This patch updates the dialog to use Font Awesome icons. Other minor change: Corrected capitalization in dialog heading. To test, apply the patch and go to Serials. - Locate a subscription which can be deleted and which has not expired, has linked items, or has linked issues. - View the detail page for that subscription. - Choose "Delete subscription" from the "Edit" menu. - Verify that the confirmation dialog is correctly styled. - Verify that the "No, don't delete" button works correctly. - Verify that the "Yes, delete" button deletes the subscription. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48697|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 48816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48816&action=edit Bug 15979 - Use Font Awesome icons subscription deletion confirmation dialog When deleting a subscription which has not expired or which has linked issues or items, a dialog asks for confirmation. This patch updates the dialog to use Font Awesome icons. Other minor change: Corrected capitalization in dialog heading. To test, apply the patch and go to Serials. - Locate a subscription which can be deleted and which has not expired, has linked items, or has linked issues. - View the detail page for that subscription. - Choose "Delete subscription" from the "Edit" menu. - Verify that the confirmation dialog is correctly styled. - Verify that the "No, don't delete" button works correctly. - Verify that the "Yes, delete" button deletes the subscription. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48816|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48841&action=edit Bug 15979 - Use Font Awesome icons subscription deletion confirmation dialog When deleting a subscription which has not expired or which has linked issues or items, a dialog asks for confirmation. This patch updates the dialog to use Font Awesome icons. Other minor change: Corrected capitalization in dialog heading. To test, apply the patch and go to Serials. - Locate a subscription which can be deleted and which has not expired, has linked items, or has linked issues. - View the detail page for that subscription. - Choose "Delete subscription" from the "Edit" menu. - Verify that the confirmation dialog is correctly styled. - Verify that the "No, don't delete" button works correctly. - Verify that the "Yes, delete" button deletes the subscription. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org