[Bug 33808] New: Accessibility: Non-descriptive links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Bug ID: 33808 Summary: Accessibility: Non-descriptive links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org An accessibility report run by the Shaw trust for the British Museum has found some examples of links that are not labelled descriptively enough for screen readers. Extract below: "The text of a link should describe the destination of the link and the link’s purpose. Providing a descriptive link text will allow users to easily determine the function of the link and make educated decisions to click the link or not. If it is not possible to identify the purpose of the link from the link text itself, then this information should be provided in context. Screen reader users have the ability to display and navigate by lists of elements, or jump from element to element. Navigating this way is much quicker than listening to a whole page, however the context provided by paragraphs and other narrative is lost and non-descriptive links become harder to understand. For downloadable links, we recommend that the file type and size of the file is also included in the link text to allow the user to make a decision whether or not to download the file. On the 'opac-shelves.pl?op=view&shelfnumber=148&sortfield=title’ page there is a non-descriptive link labelled ‘Download’, this issue is found on numerous pages tested." This patch addresses similar Download buttons, adding aria-labels and aria-has popups to the links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23003 Assignee|oleonard@myacpl.org |matt.blenkinsop@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 151564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151564&action=edit Bug 33808: Add aria-labels in opac-shelves.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 151565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151565&action=edit Bug 33808: Add aria-labels in opac-basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 151566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151566&action=edit Bug 33808: Add aria-labels in basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 151567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151567&action=edit Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151564|0 |1 is obsolete| | Attachment #151565|0 |1 is obsolete| | Attachment #151566|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151597&action=edit Bug 33808: Add aria-labels in opac-shelves.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151598&action=edit Bug 33808: Add aria-labels in opac-basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151599&action=edit Bug 33808: Add aria-labels in basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard <oleonard@myacpl.org> ---
Bug 33808: Add aria-labels in reports-toolbar.inc
The label on this one, "Select format and download chart" is incorrect. It should be something like "Select format and download report results." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151567|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 151617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151617&action=edit Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Thanks Owen, I've updated the patch as suggested :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151617|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151621&action=edit Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151597|0 |1 is obsolete| | Attachment #151598|0 |1 is obsolete| | Attachment #151599|0 |1 is obsolete| | Attachment #151621|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153495&action=edit Bug 33808: Add aria-labels in opac-shelves.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153496&action=edit Bug 33808: Add aria-labels in opac-basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153497&action=edit Bug 33808: Add aria-labels in basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153498&action=edit Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|23.11.00,23.05.02,22.11.08 |23.11.00,23.05.02,22.11.08, released in| |22.05.16 --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.16 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org