[Bug 13339] New: Cart button doesn't open the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Bug ID: 13339 Summary: Cart button doesn't open the cart Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org It's been pointed out as a bit confusing that clicking the cart button doesn't open the cart - you have to click the words "Items in your cart" to open the cart. That would be ok, except the styling of the words doesn't indicate that it is a link. I think we can provide a better UX here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|NEW |ASSIGNED Version|3.16 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 35475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35475&action=edit Bug 13339 - Cart button doesn't open the cart The link to open the cart no longer triggers the cart popup. Instead, in order to make it more usable with mobile devices, it triggers a menu which displays the count of items in the cart -- something which previously was done with a hover action (something touch-screen devices don't have). Clicking/tapping this menu item is what opens the cart window. Since the cart link is really now a menu trigger rather than just a link, it seems logical to add the small arrow which the lists link has indicating that the link triggers a menu. To test, apply the patch and view any page in a Cart-enabled OPAC. Confirm that the "caret" icon displays correctly when the cart is both empty and when it has contents. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 35635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35635&action=edit [Signed-off] Bug 13339 - Cart button doesn't open the cart The link to open the cart no longer triggers the cart popup. Instead, in order to make it more usable with mobile devices, it triggers a menu which displays the count of items in the cart -- something which previously was done with a hover action (something touch-screen devices don't have). Clicking/tapping this menu item is what opens the cart window. Since the cart link is really now a menu trigger rather than just a link, it seems logical to add the small arrow which the lists link has indicating that the link triggers a menu. To test, apply the patch and view any page in a Cart-enabled OPAC. Confirm that the "caret" icon displays correctly when the cart is both empty and when it has contents. Followed test plan. Icon displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35475|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35635|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35649&action=edit [PASSED QA] Bug 13339 - Cart button doesn't open the cart The link to open the cart no longer triggers the cart popup. Instead, in order to make it more usable with mobile devices, it triggers a menu which displays the count of items in the cart -- something which previously was done with a hover action (something touch-screen devices don't have). Clicking/tapping this menu item is what opens the cart window. Since the cart link is really now a menu trigger rather than just a link, it seems logical to add the small arrow which the lists link has indicating that the link triggers a menu. To test, apply the patch and view any page in a Cart-enabled OPAC. Confirm that the "caret" icon displays correctly when the cart is both empty and when it has contents. Followed test plan. Icon displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, good idea. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to Chris Cormack from comment #5)
Pushed to 3.18.x will be in 3.18.4
Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Thanks, this is an improvement. :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org