[Bug 16709] New: [3.20.x] Bug 11038 is not applied correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 Bug ID: 16709 Summary: [3.20.x] Bug 11038 is not applied correctly Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Staff Client Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 11038 It seems there was a problem during the application of bug 11038 on 3.20.x. The commit 32bc47f6d488f3f2d81a234c029219d5861cf338 add this line in C4/Auth.pm: + IntranetUserJS => C4::Context->preference("IntranetUserJS"), instead of: + IntranetUserCSS => C4::Context->preference("IntranetUserCSS"), And a line that had to be removed is still there in 3.20.x Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 [Bug 11038] Enable use of IntranetUserCSS and intranetcolorstylesheet on staff client login page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 52238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52238&action=edit Bug 16709: Followup of bug 11038 for 3.20.x only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Test plan: 1. Modify IntranetUserCSS and check that changes are not applied to the staff login page 2. Apply patch 3. Check that your changes are now applied to the staff login page 4. Check in the DOM that the IntranetUserCSS code only appear once -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52238|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 52414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52414&action=edit Bug 16709: Followup of bug 11038 for 3.20.x only Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Good catch, bad bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52414|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52533&action=edit Bug 16709: Followup of bug 11038 for 3.20.x only Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Good catch, bad bug Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: remove space and apply same order than in master (CSS then JS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org