[Bug 36360] New: Link ILL requests to surviving patron record when patrons are merged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Bug ID: 36360 Summary: Link ILL requests to surviving patron record when patrons are merged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When patrons are merged, the ILL requests of the deleted patron records are deleted as well. They should be re-linked to the remaining/winning patron record instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@openfifth.co.uk | |, | |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187984&action=edit Bug 36360: Add Illrequest to list of stuff to consider merging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187985&action=edit Bug 36360: Add tests prove t/db_dependent/Koha/Patrons.t Test plan, k-t-d: 1) Enable ILLModule 2) Create an ILL request for patron 'John', visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Type 'John' and pick the only result. Set a type and library. Click 'Create'. 4) Go to patrons search and search for 'jo': <staff_url>/cgi-bin/koha/members/members-home.pl 5) Tick the checkbox for John and someone else from the list. Click 'Merge selected patrons' from the top toolbar 6) Select the other patron (not John) as the 'patron to keep'. Click Merge patrons. 7) Notice '1 Illrequest was merge' message shows. 8) Visit the ILL list table, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 9) Notice the ILL request now belongs to the other patron, not John (who no longer exists). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187984|0 |1 is obsolete| | --- Comment #3 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 189922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189922&action=edit Bug 36360: Add Illrequest to list of stuff to consider merging Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187985|0 |1 is obsolete| | --- Comment #4 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 189923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189923&action=edit Bug 36360: Add tests prove t/db_dependent/Koha/Patrons.t Test plan, k-t-d: 1) Enable ILLModule 2) Create an ILL request for patron 'John', visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Type 'John' and pick the only result. Set a type and library. Click 'Create'. 4) Go to patrons search and search for 'jo': <staff_url>/cgi-bin/koha/members/members-home.pl 5) Tick the checkbox for John and someone else from the list. Click 'Merge selected patrons' from the top toolbar 6) Select the other patron (not John) as the 'patron to keep'. Click Merge patrons. 7) Notice '1 Illrequest was merge' message shows. 8) Visit the ILL list table, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 9) Notice the ILL request now belongs to the other patron, not John (who no longer exists). Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Richard Bridgen <richard.bridgen@nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |richard.bridgen@nhs.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189922|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192247&action=edit Bug 36360: Add Illrequest to list of stuff to consider merging Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189923|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192248&action=edit Bug 36360: Add tests prove t/db_dependent/Koha/Patrons.t Test plan, k-t-d: 1) Enable ILLModule 2) Create an ILL request for patron 'John', visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Type 'John' and pick the only result. Set a type and library. Click 'Create'. 4) Go to patrons search and search for 'jo': <staff_url>/cgi-bin/koha/members/members-home.pl 5) Tick the checkbox for John and someone else from the list. Click 'Merge selected patrons' from the top toolbar 6) Select the other patron (not John) as the 'patron to keep'. Click Merge patrons. 7) Notice '1 Illrequest was merge' message shows. 8) Visit the ILL list table, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 9) Notice the ILL request now belongs to the other patron, not John (who no longer exists). Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36360 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org