[Bug 20603] New: Remove unused subsv from C4::Accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 Bug ID: 20603 Summary: Remove unused subsv from C4::Accounts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org Patch is coming -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove unused subsv from |Remove unused subs from |C4::Accounts |C4::Accounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 74425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74425&action=edit Bug 20603: Remove ModNote, getcredits and getrefunds from C4::Accounts Test plan: 0) Do not apply the patch 1) Run these 3 commands git grep ModNote git grep getcredits git grep getrefunds all should return occurances only in C4/Accounts.pm - the sub definition and in t/db_dependent/Accounts.t 2) Apply the patch 3) Run commands from 1) again, now there should be no occurence 4) prove t/db_dependent/Accounts.t should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18643, 20225 CC| |mtompset@hotmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20225 [Bug 20225] Remove unused script reports/stats.print.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74425|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 74512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74512&action=edit Bug 20603: Remove ModNote, getcredits and getrefunds from C4::Accounts Test plan: 0) Do not apply the patch 1) Run these 3 commands git grep ModNote git grep getcredits git grep getrefunds all should return occurances only in C4/Accounts.pm - the sub definition and in t/db_dependent/Accounts.t 2) Apply the patch 3) Run commands from 1) again, now there should be no occurence 4) prove t/db_dependent/Accounts.t should return green Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74512|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 74602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74602&action=edit Bug 20603: Remove ModNote, getcredits and getrefunds from C4::Accounts Test plan: 0) Do not apply the patch 1) Run these 3 commands git grep ModNote git grep getcredits git grep getrefunds all should return occurances only in C4/Accounts.pm - the sub definition and in t/db_dependent/Accounts.t 2) Apply the patch 3) Run commands from 1) again, now there should be no occurence 4) prove t/db_dependent/Accounts.t should return green Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org