[Bug 42567] New: Remove C4::Koha::GetNormalizedEAN in favor of MetadataExtractor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Bug ID: 42567 Summary: Remove C4::Koha::GetNormalizedEAN in favor of MetadataExtractor Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 42566 C4::Koha::GetNormalizedEAN duplicates logic that belongs in the MetadataExtractor pattern (Bug 34828). This bug adds get_normalized_ean to the flavor-specific extractors: - MARC21: 024$a with indicator 1 = 3 - UNIMARC: 073$a Then exposes it as $biblio->normalized_ean and migrates all callers. Callers to migrate: - C4::Search - C4::ShelfBrowser - opac-shelves.pl, opac-user.pl, opac-showreviews.pl - virtualshelves/shelves.pl Depends on Bug 42566. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42566 [Bug 42566] Remove C4::Koha::GetNormalizedUPC in favor of MetadataExtractor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 198881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198881&action=edit Bug 42567: Remove C4::Koha::GetNormalizedEAN in favor of MetadataExtractor Adds get_normalized_ean to the flavor-specific extractors: - MARC21: 024$a with indicator 1 = 3 - UNIMARC: 073$a Exposes it as $biblio->normalized_ean and migrates all callers. Assisted-by: Sonnet 4.6 (Anthropic) Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha.t \ t/db_dependent/Koha/Biblio.t \ t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/MARC21.t \ t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/UNIMARC.t => SUCCESS: Tests pass 3. Verify EAN numbers still display in OPAC and staff detail pages 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42569 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |jonathan.druart@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42569 [Bug 42569] Refactor Koha::Biblio->get_coins to use MetadataExtractor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies - getting a sha1/fake ancestor error when trying to apply the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 201882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201882&action=edit Bug 42567: Remove C4::Koha::GetNormalizedEAN in favor of MetadataExtractor Adds get_normalized_ean to the flavor-specific extractors: - MARC21: 024$a with indicator 1 = 3 - UNIMARC: 073$a Exposes it as $biblio->normalized_ean and migrates all callers. Assisted-by: Sonnet 4.6 (Anthropic) Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha.t \ t/db_dependent/Koha/Biblio.t \ t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/MARC21.t \ t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/UNIMARC.t => SUCCESS: Tests pass 3. Verify EAN numbers still display in OPAC and staff detail pages 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 201976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201976&action=edit Bug 42567: Remove C4::Koha::GetNormalizedEAN in favor of MetadataExtractor Adds get_normalized_ean to the flavor-specific extractors: - MARC21: 024$a with indicator 1 = 3 - UNIMARC: 073$a Exposes it as $biblio->normalized_ean and migrates all callers. Assisted-by: Sonnet 4.6 (Anthropic) Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha.t \ t/db_dependent/Koha/Biblio.t \ t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/MARC21.t \ t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/UNIMARC.t => SUCCESS: Tests pass 3. Verify EAN numbers still display in OPAC and staff detail pages 4. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Tomás! The patch now applies cleanly. I've signed off, as the tests pass. I couldn't get a 024$a to show on the staff interface or OPAC, both before and after the patch - even with visibility for the framework enabled (also, without the indicator set to 1 and 3). I'm assuming there is some "trick" to get them to display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202338&action=edit Bug 42567: Remove C4::Koha::GetNormalizedEAN in favor of MetadataExtractor Adds get_normalized_ean to the flavor-specific extractors: - MARC21: 024$a with indicator 1 = 3 - UNIMARC: 073$a Exposes it as $biblio->normalized_ean and migrates all callers. Assisted-by: Sonnet 4.6 (Anthropic) Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha.t \ t/db_dependent/Koha/Biblio.t \ t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/MARC21.t \ t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/UNIMARC.t => SUCCESS: Tests pass 3. Verify EAN numbers still display in OPAC and staff detail pages 4. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 203846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203846&action=edit Bug 42567: Remove C4::Koha::GetNormalizedEAN in favor of MetadataExtractor Adds get_normalized_ean to the flavor-specific extractors: - MARC21: 024$a with indicator 1 = 3 - UNIMARC: 073$a Exposes it as $biblio->normalized_ean and migrates all callers. Assisted-by: Sonnet 4.6 (Anthropic) Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha.t \ t/db_dependent/Koha/Biblio.t \ t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/MARC21.t \ t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/UNIMARC.t => SUCCESS: Tests pass 3. Verify EAN numbers still display in OPAC and staff detail pages 4. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 26.05 backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42567 Bug 42567 depends on bug 42566, which changed state. Bug 42566 Summary: Remove C4::Koha::GetNormalizedUPC in favor of MetadataExtractor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42566 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org