http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note that this patch does not depend on bug 12955 and bug 12956 but I recommend to test the enhancement with these bug fixes applied. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32790&action=edit Bug 12958 Followup, more 'gracious' UI? Rewording: Set this owner to all children funds becomes: Propagate to children funds And put the checkbox on the same line Than Owner: rather than on the next line. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31701|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32791&action=edit Bug 12958: Set a fund owner to a fund hierarchy This patch adds the ability to set an owner to a fund hierarchy On editing a fund, if it has children, a new checkbox appears "Set this owner to all children funds". If checked, all the fund hierarchy will herit to this owner. This will facilitate the fund owner modifications. Test plan: - Verify that the new checkbox only appears if the fund has at least a child. - Create a consistent fund hierarchy, something like: fund1 fund11 fund111 fund12 fund2 fund21 - Try to modify a fund owner without checking the checkbox. Verify the children have not been modified. - Try to modify a fund owner with checking the checkbox. Verify all fund hierarchy has been modified. Signed-off-by: Frederic Demians <f.demians@tamil.fr> It works as announced. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, could you take a look at the first = second GUI follow-up? I wonder if we should add a warning, that if the child funds already have an owner, this one will be overwritten. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32822&action=edit Bug 12958 [Alt. label follow-up] Set a fund owner to a fund hierarchy This alternate follow-up modifies the text of the label to (hopefully) make it more clear. The markup has been revised someone to make it more standard, and a warning has been added about overwriting existing data. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32822|0 |1 is obsolete| | --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32847&action=edit Bug 12958 [Alt. label follow-up] Set a fund owner to a fund hierarchy This alternate follow-up modifies the text of the label to (hopefully) make it more clear. The markup has been revised someone to make it more standard, and a warning has been added about overwriting existing data. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Looks good. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32791|0 |1 is obsolete| | Attachment #32847|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32855&action=edit [PASSED QA] Bug 12958: Set a fund owner to a fund hierarchy This patch adds the ability to set an owner to a fund hierarchy On editing a fund, if it has children, a new checkbox appears "Set this owner to all children funds". If checked, all the fund hierarchy will herit to this owner. This will facilitate the fund owner modifications. Test plan: - Verify that the new checkbox only appears if the fund has at least a child. - Create a consistent fund hierarchy, something like: fund1 fund11 fund111 fund12 fund2 fund21 - Try to modify a fund owner without checking the checkbox. Verify the children have not been modified. - Try to modify a fund owner with checking the checkbox. Verify all fund hierarchy has been modified. Signed-off-by: Frederic Demians <f.demians@tamil.fr> It works as announced. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan and Owen! -- You are receiving this mail because: You are watching all bug changes.