[Bug 41688] New: Refund modal and amount as NaN, rejected comma separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Bug ID: 41688 Summary: Refund modal and amount as NaN, rejected comma separator Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Point of Sale Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk Hello @ll The problem here is on the refund modal, when retrieving the default value before being modified it is NaN because in some cases for decimal separators with comma, the recovery fails due to formatting a value already formatted in js. After a quick search I think it's a return of bug 31513 fix -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31513 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 --- Comment #1 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 191871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191871&action=edit Bug 41688: Fix NaN display in POS refund modal Test plan: Prerequisites: CurrencyFormat as 'FR' activated, have already produced a payment (with a comma separator) 1. Go to POS > register > transaction history 2. Click "Issue refund" on any paid transaction 3. Verify "Amount paid" shows correct amount (not NaN) 4. Enter refund amount with comma decimal (e.g. 5,50) 5. Verify no validation error occurs 6. Process refund successfully -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191871|0 |1 is obsolete| | --- Comment #2 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 191872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191872&action=edit Bug 41688: Fix NaN display in POS refund modal Test plan: Prerequisites: CurrencyFormat as 'FR' activated, have already produced a payment (with a comma separator) 1. Go to POS > register > transaction history 2. Click "Issue refund" on any paid transaction 3. Verify "Amount paid" shows correct amount (not NaN but get the value with comma separator) 4. Enter refund amount (point separator is mandatory to valid input) 5. Verify no validation error occurs 6. Process refund successfully -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oh this removes "$Price" filter. Needs to be replaced by "html" filter right ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191872|0 |1 is obsolete| | --- Comment #4 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 192333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192333&action=edit Bug 41688: Fix NaN display in POS refund modal Test plan: Prerequisites: CurrencyFormat as 'FR' activated, have already produced a payment (with a comma separator) 1. Go to POS > register > transaction history 2. Click "Issue refund" on any paid transaction 3. Verify "Amount paid" shows correct amount (not NaN but get the value with comma separator) 4. Enter refund amount (point separator is mandatory to valid input) 5. Verify no validation error occurs 6. Process refund successfully Sponsored-by: BibLibre -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 --- Comment #5 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- (In reply to Fridolin Somers from comment #3)
Oh this removes "$Price" filter. Needs to be replaced by "html" filter right ?
Yes Fred.. my bad :) Fixed ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |BibLibre list of Sponsors| | Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192333|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 192584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192584&action=edit Bug 41688: Fix NaN display in POS refund modal Test plan: Prerequisites: CurrencyFormat as 'FR' activated, have already produced a payment (with a comma separator) 1. Go to POS > register > transaction history 2. Click "Issue refund" on any paid transaction 3. Verify "Amount paid" shows correct amount (not NaN but get the value with comma separator) 4. Enter refund amount (point separator is mandatory to valid input) 5. Verify no validation error occurs 6. Process refund successfully Sponsored-by: BibLibre Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 192585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192585&action=edit Screenshot - refund modal formatting Just attaching a screenshot of the refund form - not sure if it is this bug, but it may need some formatting changes to make it "tidy". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 --- Comment #8 from David Nind <david@davidnind.com> --- NaN = Not a Number -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please fill Assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 [Bug 41585] Refunds don't always appear on the register page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|41585 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41585 [Bug 41585] Refunds don't always appear on the register page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Signed Off |Failed QA --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Why don't you use `$Price on_editing => 1`, like it is in members/boraccount.tt? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 --- Comment #11 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 206985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206985&action=edit Bug 41688: (QA follow-up) replace 'html' filter by ' on_editing => 1' on tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206985|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 --- Comment #12 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 206986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206986&action=edit Bug 41688: (QA follow-up) replace 'html' filter by 'Price on_editing => 1' on tt Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 --- Comment #13 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- (In reply to Jonathan Druart from comment #10)
Why don't you use `$Price on_editing => 1`, like it is in members/boraccount.tt?
Totally agree, thanks for the help -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Refund modal and amount as |Refund modal and amount not |NaN, rejected comma |a number (NaN), rejected |separator |comma separator -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jvinke@austinseminary.edu |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 --- Comment #14 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 207492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207492&action=edit Screenshot - refund modal issue example -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41688 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from John Vinke <jvinke@austinseminary.edu> --- I'm setting to failed QA because I'm noticing a few issues. 1. With this bug, you cannot enter the price using the separator (comma) that is used with this testing plan. That is to say: "40,40" is not accepted, but "40.40" is. 2. The warning that appears under the input field drops trailing zeros instead of going to two decimal points. 3. It is also worth noting that the price displayed in the warning is not using the same separator that is being displayed in the price paid. Perhaps I'm misunderstanding what step 4 of the test plan was. Were you indicating that a period would be required, rather than a comma? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org