[Bug 22520] New: Be Elastic compliant 7.x and 8.x (_doc)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Bug ID: 22520 Summary: Be Elastic compliant 7.x and 8.x (_doc) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: claire.hernandez@biblibre.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 --- Comment #1 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- Using "_doc" despite "data" in Elastic index. (_doc is not allowed in 5.x version (but we need to have 6.x elastic asap)...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86908&action=edit Bug 22560: Forgotten password "token expired" page still shows boxes to reset password This patch modifies the OPAC password recovery template so that the new password entry form doesn't appear if the patron has followed an invalid or expired link. This patch also corrects the markup in the page title. To test, apply the patch and follow the process for resetting a forgotten password. When you follow the password recovery link, modify the URL so that the "uniqueKey" parameter is different. The page should show an error message. The password entry form should not appear. Check the page title in the browser's title bar. It should look correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86908|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #2)
Created attachment 86908 [details] [review]
Sorry, wrong bug number! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes@ub.lu.se --- Comment #4 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Since it's not necessary to use the type name in Elasticsearch 7, it's possible to use data as the type name in Elasticsearch 6, upgrade to Elasticsearch 7, and then no longer use the type name. It would be possible to check if a new index is being created and then use _doc for the type name, but it could complicate things if the indexes had different type names and it was necessary to check which type name they had before using them. One can always recreate the indexes in Elasticsearch 7 if desired. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Which workflow does this break or triggers a warning? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 --- Comment #6 from Kevin Carnes <kevin.carnes@ub.lu.se> --- (In reply to Victor Grousset/tuxayo from comment #5)
Which workflow does this break or triggers a warning?
In ES6, the type is specified in the URL to index a single record, but in ES7, _doc should be used instead. So if ES6 has a type of _doc, the URL for indexing single records doesn't need to be changed when upgrading to ES7. Koha indexes in bulk, so changing the type name doesn't affect the URL for bulk indexing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Koha indexes in bulk, so changing the type name doesn't affect the URL for bulk indexing.
So compat with ES7 is already ok for this? So no action needed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 --- Comment #8 from Kevin Carnes <kevin.carnes@ub.lu.se> --- (In reply to Victor Grousset/tuxayo from comment #7)
Koha indexes in bulk, so changing the type name doesn't affect the URL for bulk indexing.
So compat with ES7 is already ok for this? So no action needed?
That's correct, this bug can be closed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hurray! Thanks for the analysis :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org