[Bug 33426] New: Add client storage of user-selected DataTables configuration to suggestion.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Bug ID: 33426 Summary: Add client storage of user-selected DataTables configuration to suggestion.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: emily.lamancusa@montgomerycountymd.gov Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Depends on: 22276 Bug 22276 added a method to columns_settings.inc to support the use of the DataTables "saveState" option. Making use of that function in suggestion.tt would enable the suggestion table to remember individual users' local changes to the table configuration. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 [Bug 22276] Add client storage of user-selected DataTables configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd love to see that :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #2 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 149222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149222&action=edit Bug 33426: Add DataTables saveState to suggestion.tt To test: 1. In the staff client, go to Purchase Suggestion management page and add a suggestion if needed to make the table display. 2. Make some changes to the table settings (hide/show columns, change sort column, and/or change number of rows to display) 3. Navigate to a different page. 4. Navigate back to Purchase Suggestions page. Note that the table settings have been reset. 5. Apply patch and restart_all 6. Repeat steps 1-4. Note that this time the changes to the table settings were preserved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Katrin Fischer from comment #1)
I'd love to see that :)
Granted :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Should we use this bug as is.. or attempt to generalise the pattern.. I feel like we could move the code into our KohaTable wrappers and make it work for all cases -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Please see bug 33484 for a more global approach to this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome work btw Emily.. I didn't mean to rain on your parade here.. the code works perfectly here and I'll SO on it.. we can perhaps replace with bug 33484 once it's ready and keep your work here credited :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149222|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149446&action=edit Bug 33426: Add DataTables saveState to suggestion.tt To test: 1. In the staff client, go to Purchase Suggestion management page and add a suggestion if needed to make the table display. 2. Make some changes to the table settings (hide/show columns, change sort column, and/or change number of rows to display) 3. Navigate to a different page. 4. Navigate back to Purchase Suggestions page. Note that the table settings have been reset. 5. Apply patch and restart_all 6. Repeat steps 1-4. Note that this time the changes to the table settings were preserved. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Going straight for QA on this one.. it works perfectly as designed.. it's the design of the original bug I dissagree with ;P Making my bug depend on both so we can keep Emily's contribution recorded :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 [Bug 33484] Generalise table saveState for all tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #9 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks Martin! :) I agree that generalizing it is a better approach - working on testing yours now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149446|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149973&action=edit Bug 33426: Add DataTables saveState to suggestion.tt To test: 1. In the staff client, go to Purchase Suggestion management page and add a suggestion if needed to make the table display. 2. Make some changes to the table settings (hide/show columns, change sort column, and/or change number of rows to display) 3. Navigate to a different page. 4. Navigate back to Purchase Suggestions page. Note that the table settings have been reset. 5. Apply patch and restart_all 6. Repeat steps 1-4. Note that this time the changes to the table settings were preserved. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Needs nice release notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This allows Koha to release notes| |remember the changes that a | |user has made to the | |columns settings on the | |Purchase Suggestions | |Management page, so that | |the columns settings and | |sorts are kept when | |reloading the page. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I don't think there is anything to document here. Feel free to reopen with more details if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 [Bug 38192] DT - State not restored correctly on suggestion tables -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org