[Bug 18083] New: Don't show 'library' selection on popular titles page for single-branch libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Bug ID: 18083 Summary: Don't show 'library' selection on popular titles page for single-branch libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org On the 'popular titles' page in the OPAC there is a search filter labelled "From" that offers you to select a library branch. For a library with only one branch this makes no sense and it would be nice if it was automatically hidden for single-branch libraries. Note: Currently not possible to hide with CSS only either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Te Rauhina Jackson <terauhina.jackson@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 --- Comment #1 from Te Rauhina Jackson <terauhina.jackson@gmail.com> --- Created attachment 70542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70542&action=edit Bug 18083: Don't show 'library' selection on popular titles page for single-branch libraries This patch hides the search filter labelled "From" that offers you to select a library branch which is located on the 'popular titles' page on the OPAC. It is hidden when the library only has one branchas it would be unneccessary to have an option for other branches when there is only one. Test Plan: 1) Make sure you have a single-branch library 2) Make sure OPACTopIssue is allowed in the OPAC preferences 3) In the OPAC, got to 'Most Popular' page 4) Check that there is no "From" filter in the refine search 5) Create a new branch so that you have more than one branch 6) Check that there is a "From" filter in the refine search on the Most Popular page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |terauhina.jackson@gmail.com CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70542|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70623&action=edit Bug 18083: Don't show 'library' selection on popular titles page for single-branch libraries This patch hides the search filter labelled "From" that offers you to select a library branch which is located on the 'popular titles' page on the OPAC. It is hidden when the library only has one branchas it would be unneccessary to have an option for other branches when there is only one. Test Plan: 1) Make sure you have a single-branch library 2) Make sure OPACTopIssue is allowed in the OPAC preferences 3) In the OPAC, got to 'Most Popular' page 4) Check that there is no "From" filter in the refine search 5) Create a new branch so that you have more than one branch 6) Check that there is a "From" filter in the refine search on the Most Popular page. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended white space on second change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70771&action=edit Bug 18083: Simplify the condition - if there are more than 1 library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Enhancement, not backported for 17.11. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org