http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11911&action=edit Bug 8708 - RSS feed for new comments is broken Removing white space from the beginning of the file so that XML processing will work correctly. Before the patch, viewing the page (/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser which supports RSS handling (ex: Firefox) will show you unformatted and broken-looking text. After the patch the page will trigger the browser's built-in RSS-handling format. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Owen, I have not tested this patch. But if it just removes boundary characters, I think a comment is welcomed. Indeed if a stubborn of alignment and indentation (like me !) read that in the future, he would certainly re-add them :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #4 from Magnus Enger <magnus@enger.priv.no> --- Maybe a TT-comment that says "Make sure there are no spaces/newlines here, it will ruin the XML processing"? And use [%- and -%] to remove whitespace introduced by the comment? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11911|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11918&action=edit [SIGNED-OFF] Bug 8708 - RSS feed for new comments is broken Removing white space from the beginning of the file so that XML processing will work correctly. Before the patch, viewing the page (/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser which supports RSS handling (ex: Firefox) will show you unformatted and broken-looking text. After the patch the page will trigger the browser's built-in RSS-handling format. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> The recent comments feed works as expected now. Signing off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11918|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11984&action=edit Bug 8708 [Revised] RSS feed for new comments is broken Removing white space from the beginning of the file so that XML processing will work correctly. Before the patch, viewing the page (/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser which supports RSS handling (ex: Firefox) will show you unformatted and broken-looking text. After the patch the page will trigger the browser's built-in RSS-handling format. Revision: Template now includes comment pointing out that the <xml> declaration must not have any white space before it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Thank you Owen. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.