[Bug 23376] New: Cleanup order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Bug ID: 23376 Summary: Cleanup order receive page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91774&action=edit Bug 23376: Clean up order recipt page This patchset switches from using DB lookups to using an order object for most things on orderreceive.pl It simplifies the script and makes minimal changes to the template To test: 1 - Place some orders and receive them 2 - Have orders with or without subscriptions attached 3 - Try with different AcqCreateItems settings 4 - Apply patch 5 - No behaviour should change 6 - Read code to ensure things make sense -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91857&action=edit Bug 23376: Move AcqCreateItem logic to template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91858&action=edit Bug 23376: Remove unneeded 'count' parameter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |agustinmoyano@theke.io --- Comment #4 from Agustín Moyano <agustinmoyano@theke.io> --- When I try to apply this, I get the following 13:47 $ git bz apply 23376 Bug 23376 - Cleanup order receive page 91774 - Bug 23376: Clean up order recipt page 91857 - Bug 23376: Move AcqCreateItem logic to template 91858 - Bug 23376: Remove unneeded 'count' parameter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23376: Clean up order recipt page Using index info to reconstruct a base tree... M acqui/orderreceive.pl M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt Auto-merging acqui/orderreceive.pl CONFLICT (content): Merge conflict in acqui/orderreceive.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 23376: Clean up order recipt page hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /var/folders/97/nr6_vjn53dl2csvdgtcy_8f40000gp/T/Bug-23376-Clean-up-order-recipt-page-Q2iLmH.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91774|0 |1 is obsolete| | Attachment #91857|0 |1 is obsolete| | Attachment #91858|0 |1 is obsolete| | --- Comment #5 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 110692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110692&action=edit Bug 23376: Clean up order recipt page This patchset switches from using DB lookups to using an order object for most things on orderreceive.pl It simplifies the script and makes minimal changes to the template To test: 1 - Place some orders and receive them 2 - Have orders with or without subscriptions attached 3 - Try with different AcqCreateItems settings 4 - Apply patch 5 - No behaviour should change 6 - Read code to ensure things make sense Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #6 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 110693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110693&action=edit Bug 23376: Move AcqCreateItem logic to template Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #7 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 110694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110694&action=edit Bug 23376: Remove unneeded 'count' parameter Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #8 from Agustín Moyano <agustinmoyano@theke.io> --- I took the liberty to rebase and signoff all at the same time. Nick, could you please check that rebase it's ok? Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Heh, I harasses Agustin before testing, but yes, the rebase looks great, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110692|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111247&action=edit Bug 23376: Clean up order recipt page This patchset switches from using DB lookups to using an order object for most things on orderreceive.pl It simplifies the script and makes minimal changes to the template To test: 1 - Place some orders and receive them 2 - Have orders with or without subscriptions attached 3 - Try with different AcqCreateItems settings 4 - Apply patch 5 - No behaviour should change 6 - Read code to ensure things make sense Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110693|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111248&action=edit Bug 23376: Move AcqCreateItem logic to template Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110694|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111249&action=edit Bug 23376: Remove unneeded 'count' parameter Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111250&action=edit Bug 23376: (QA follow-up) Remove authnotrequired The rebased patchset subsequnetly re-introduced the now deprecated use of authnotrequired on staff client controllers. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice bit of cleaning up, thanks. All works as expected still, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cleanup order receive page |Cleanup order receive page | |code CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nice one, Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #17 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 111378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111378&action=edit Bug 23376: (follow-up) Fix subscription bug in orderreceive.tt When order has subscription, general order variable gets replaced by other order variable in FOR loop -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Agustín Moyano from comment #17)
Created attachment 111378 [details] [review] Bug 23376: (follow-up) Fix subscription bug in orderreceive.tt
When order has subscription, general order variable gets replaced by other order variable in FOR loop
Pushed to master, thanks Agustin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111750&action=edit Bug 23376: If a single item is returned we cannot count -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26730 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26730 [Bug 26730] Cannot receive orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 [Bug 21811] Add warning when order receive form is saved without entering 'quantity received' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #19)
Created attachment 111750 [details] [review] Bug 23376: If a single item is returned we cannot count
"order" is a Koha::Acquisition::Order and so order->items will return a Koha::Items set, should not then it be [% order.items.count %] instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've tested some bugs with the patch as proposed, but not sure if there are side effects I have missed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I've tried with count and it did not work (not sure why actually!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #19)
Created attachment 111750 [details] [review] Bug 23376: If a single item is returned we cannot count
Patch pushed to master for 20.11.00, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27671 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27671 [Bug 27671] Missing include in orderreceive.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28881 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 [Bug 28881] Suggestion not displayed on the order receive page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28627 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi --- Comment #25 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- We ran into a problem with our orders receive page and would like to know if anyone has run into same kind of issue. It seems if order.quantityreceived is more than 0 page orderreceive.pl/template orderreceive.tt dies on line 323 which reads [% IF ( order.items.count ) %]. In logs we have: "Template process failed: undef error - The method Koha::Item->count is not covered by tests!" Changing order.items.count to items.count doesn't produce error but isn't really helpful since now there's no value on input "Quantity received", just 0 (this could also be a separate problem). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Emmi Takkinen from comment #25)
We ran into a problem with our orders receive page and would like to know if anyone has run into same kind of issue. It seems if order.quantityreceived is more than 0 page orderreceive.pl/template orderreceive.tt dies on line 323 which reads [% IF ( order.items.count ) %]. In logs we have:
"Template process failed: undef error - The method Koha::Item->count is not covered by tests!"
Changing order.items.count to items.count doesn't produce error but isn't really helpful since now there's no value on input "Quantity received", just 0 (this could also be a separate problem).
It should be orders.items. It's certainly fixed on master since bug 29844. Weird that it has not been reported before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #27 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Jonathan Druart from comment #26)
(In reply to Emmi Takkinen from comment #25)
We ran into a problem with our orders receive page and would like to know if anyone has run into same kind of issue. It seems if order.quantityreceived is more than 0 page orderreceive.pl/template orderreceive.tt dies on line 323 which reads [% IF ( order.items.count ) %]. In logs we have:
"Template process failed: undef error - The method Koha::Item->count is not covered by tests!"
Changing order.items.count to items.count doesn't produce error but isn't really helpful since now there's no value on input "Quantity received", just 0 (this could also be a separate problem).
It should be orders.items. It's certainly fixed on master since bug 29844.
Weird that it has not been reported before.
Yep, changing order.items to orders.items fixed error. I'll provide patch here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #28 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 131857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131857&action=edit Bug 23376: Fix template error on order receive page Order receive page dies on error 500 if orders quantityreceived is more than 0. The error logs reads: "Template process failed: undef error - The method Koha::Item->count is not covered by tests!" In template orderreceive.tt we have "order.items.count" not "orders.items.count" as it should be. Note! It seems that this error doesn't occur if template param edit is set as 1. To test: 1. Find order with quantityreceived value more than 0. 2. Try to receive this order. => Error 500 page is displayed. 3. Apply patch 4. Repeat steps 1 and 2. => Order receive page is displayed normally. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Emmi Takkinen from comment #28)
Created attachment 131857 [details] [review] Bug 23376: Fix template error on order receive page
Order receive page dies on error 500 if orders quantityreceived is more than 0. The error logs reads: "Template process failed: undef error - The method Koha::Item->count is not covered by tests!" In template orderreceive.tt we have "order.items.count" not "orders.items.count" as it should be. Note! It seems that this error doesn't occur if template param edit is set as 1.
To test: 1. Find order with quantityreceived value more than 0. 2. Try to receive this order. => Error 500 page is displayed. 3. Apply patch 4. Repeat steps 1 and 2. => Order receive page is displayed normally.
Sponsored-by: Koha-Suomi Oy
Please move this to a new bug, dependent on this one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30321 [Bug 30321] Order receive page dies if quantity received is more than 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131857|0 |1 is obsolete| | Attachment #131857|1 |0 is patch| | --- Comment #30 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Comment on attachment 131857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131857 Bug 23376: Fix template error on order receive page Created bug 30321 and obsoleted patch provided here. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org