[Bug 22451] New: Asset plugin is using the version from the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Bug ID: 22451 Summary: Asset plugin is using the version from the DB Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Should not be retrieved with Koha::Version? See bug 20658 comment 13. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86034&action=edit Bug 22451: Make Asset plugin use Koha::version instead of version from db Test plan: Apply the patch a try to use Koha, css and js files should be used normally -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86035&action=edit Bug 22451: Update test Test plan: prove t/db_dependent/Koha/Template/Plugin/Asset.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86036&action=edit Bug 22451: Use Asset everywhere Test plan: Use installer and onboaarding tool, make sure the js and css files are loaded -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Depends on| |20658 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 [Bug 20658] Move template JavaScript to the footer: Installer and onboarding -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. I'd say there is a dot missing: $1$2$3 should be $1.$2$3 to match the value in the DB 2. I do not understand the changes in the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86034|0 |1 is obsolete| | Attachment #86035|0 |1 is obsolete| | Attachment #86036|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86115&action=edit Bug 22451: Make Asset plugin use Koha::version instead of version from db Test plan: Apply the patch a try to use Koha, css and js files should be used normally -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86116&action=edit Bug 22451: Update test Test plan: prove t/db_dependent/Koha/Template/Plugin/Asset.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86117&action=edit Bug 22451: Use Asset everywhere Test plan: Use installer and onboaarding tool, make sure the js and css files are loaded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #5)
1. I'd say there is a dot missing: $1$2$3 should be $1.$2$3 to match the value in the DB $1 is for first two version parts with dot... so dot is here, but I agree it is not obvious... maybe better to format regex with 4 parts to make it better readable - i updated the first patch
2. I do not understand the changes in the tests.
When database is not fully updated, then the test could fail if using version preference... maybe a bit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86115|0 |1 is obsolete| | --- Comment #10 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 87821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87821&action=edit Bug 22451: Make Asset plugin use Koha::version instead of version from db Test plan: Apply the patch a try to use Koha, css and js files should be used normally Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86116|0 |1 is obsolete| | --- Comment #11 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 87822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87822&action=edit Bug 22451: Update test Test plan: prove t/db_dependent/Koha/Template/Plugin/Asset.t Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86117|0 |1 is obsolete| | --- Comment #12 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 87823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87823&action=edit Bug 22451: Use Asset everywhere Test plan: Use installer and onboaarding tool, make sure the js and css files are loaded Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87821|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87897&action=edit Bug 22451: Make Asset plugin use Koha::version instead of version from db Test plan: Apply the patch a try to use Koha, css and js files should be used normally Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87822|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87899&action=edit Bug 22451: Update test Test plan: prove t/db_dependent/Koha/Template/Plugin/Asset.t Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87823|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87900&action=edit Bug 22451: Use Asset everywhere Test plan: Use installer and onboaarding tool, make sure the js and css files are loaded Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18308 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 [Bug 18308] Default value of minPasswordLength should be increased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Bug 22451 depends on bug 20658, which changed state. Bug 20658 Summary: Move template JavaScript to the footer: Installer and onboarding https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependency for 18.05.x, not backporting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org