[Bug 26758] New: Correct OPAC ILL requests page markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Bug ID: 26758 Summary: Correct OPAC ILL requests page markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 20168 There are some aspects of the OPAC ILL requests page which I missed during the upgrade to Bootstrap 4: Menu and button markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26706 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26706 [Bug 26706] Fix btn-default styling for better contrast -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112085&action=edit Bug 26758: Correct OPAC ILL requests page markup This patch makes some corrections to the OPAC ILL page which should have been included in the upgrade to Bootstrap 4. To test you must have Interlibrary loan configured and enabled in the OPAC. Enter some text in the ILLModuleCopyrightClearance system preference. - Log in to the OPAC and go to the "your interlibrary loan requests" page. - If you have only one ILL backend set up you should see a "Create a new request" button which is styled correctly. - This patch makes corrections to the menu which displays if you have more than one ILL backend set up, so it would be ideal to be able to test it. - Upon clickng the "new request" button (or selecting a backend from the new request menu) you should be prompted to choose Yes or No in response to the ILLModuleCopyrightClearance text. The buttons should be styled green and red, respectively. - On the new request entry page the "Add new field" and "Create" buttons should be styled in the "secondary" grey style. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112085|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 112766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112766&action=edit Bug 26758: Correct OPAC ILL requests page markup This patch makes some corrections to the OPAC ILL page which should have been included in the upgrade to Bootstrap 4. To test you must have Interlibrary loan configured and enabled in the OPAC. Enter some text in the ILLModuleCopyrightClearance system preference. - Log in to the OPAC and go to the "your interlibrary loan requests" page. - If you have only one ILL backend set up you should see a "Create a new request" button which is styled correctly. - This patch makes corrections to the menu which displays if you have more than one ILL backend set up, so it would be ideal to be able to test it. - Upon clickng the "new request" button (or selecting a backend from the new request menu) you should be prompted to choose Yes or No in response to the ILLModuleCopyrightClearance text. The buttons should be styled green and red, respectively. - On the new request entry page the "Add new field" and "Create" buttons should be styled in the "secondary" grey style. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 112767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112767&action=edit Screenshots - After patch applied I've attached screenshots of the pages after the patch was applied. Just to note that I found the black text on a grey background hard to read for the 'Add new field' and 'Create' buttons. My notes from testing ===================== I tested using koha-testing-docker and setup two ILL backends: FreeForm and Koha. Instructions are available at https://wiki.koha-community.org/wiki/ILL_backends 1. Create an Illbackends directory outside the koha root: mkdir /usr/share/koha/lib/Koha/Illbackends 2. Change to the newly cerated directory: cd /usr/share/koha/lib/Koha/Illbackends 3. Clone the FreeForm and Koha backends: i. git clone https://github.com/PTFS-Europe/koha-ill-freeform.git ii. git clone https://github.com/PTFS-Europe/koha-ill-koha.git 4. Rename the directories: i. mv koha-ill-freeform FreeForm ii. mv koha-ill-koha Koha 5. Setup symbolic links to these directories: i. mkdir /kohdevebox/koha/Koha/Illbackends ii. ln -s /usr/share/koha/lib/Koha/Illbackends/FreeForm /kohadevbox/koha/Koha/Illbackends/ iii. ln -s /usr/share/koha/lib/Koha/Illbackends/Koha /kohadevbox/koha/Koha/Illbackends/ 6. Change ownership (not sure if this is required): i. chown -R kohdev-koha:kohadev-koha /kohdevebox/koha/Koha/Illbackends ii. chown -R kohdev-koha:kohadev-koha /usr/share/koha/lib/Koha/Illbackends 7. Enable interlibrary loans system preference: ILLModule 8. Add some text to the ILLModuleCopyrightClearance system preference. 9. Restart everything: i. flush_memcached ii. restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112766|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112771&action=edit Bug 26758: Correct OPAC ILL requests page markup This patch makes some corrections to the OPAC ILL page which should have been included in the upgrade to Bootstrap 4. To test you must have Interlibrary loan configured and enabled in the OPAC. Enter some text in the ILLModuleCopyrightClearance system preference. - Log in to the OPAC and go to the "your interlibrary loan requests" page. - If you have only one ILL backend set up you should see a "Create a new request" button which is styled correctly. - This patch makes corrections to the menu which displays if you have more than one ILL backend set up, so it would be ideal to be able to test it. - Upon clickng the "new request" button (or selecting a backend from the new request menu) you should be prompted to choose Yes or No in response to the ILLModuleCopyrightClearance text. The buttons should be styled green and red, respectively. - On the new request entry page the "Add new field" and "Create" buttons should be styled in the "secondary" grey style. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Bug 26758 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org