https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Previous comment describes the behavior I'm seeing on a partner site on 19.11. On my test site, on both master and 19.11.x, Koha simply ignores the very large cardnumber, and falls back to the next longest card. I'm not sure what makes the difference there. Either way, it's not working as desired. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107492&action=edit Bug 26035: Add tests to highlight the problem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- So if we don't cast the cardnumber as an integer, mysql doesn't know how to properly determine the highest cardnumber. It treats them as as strings and oputs 42 higher than 218250005. If we replace "CAST(cardnumber AS SIGNED" with "(cardnumber + 0)," the math forces mysql to treat it as a number, but we end up with a cardnumber in scientific notation if our existing biggest cardnumber is as big as the initial example (603628999632182575912). I played around with "use bigint" and "use Math::BigInt" but didn't get quite work. They both went from 603628999632182575912 to 603628999630000000001, suggesting that it's still going to scientific notation and then back again poorly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 107522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107522&action=edit Bug 26035: AutoMemberNum should support cardnumbers up to 32 characters To test: 1- create a patron with cardnumber 12345678901234567890123456789012 (or any 32 character number) 2- turn on AutoMemberNum 3- create a new patron, save without a cardnumber 4- confirm that new patron has a cardnumber one more than the number from step 1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bwsdonna@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a problem noted by the QA script - can you please check? FAIL Koha/Patron.pm FAIL valid Useless use of a constant (1) in void context I also have some issues with the unit tests failing: # Failed test 'No tests run for subtest "fixup_cardnumber"' # at t/db_dependent/Koha/Patrons.t line 2237. Can't call method "cardnumber" on an undefined value at t/db_dependent/Koha/Patrons.t line 2219. # Looks like your test exited with 2 just after 42. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 1/42 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 512 Tests: 42 Failed: 1) Failed test: 42 Non-zero exit status: 2 Files=1, Tests=42, 29 wallclock secs ( 0.08 usr 0.01 sys + 22.72 cusr 4.31 csys = 27.12 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|andrewfh@dubcolib.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.